[CMake] Include dependency on cxx-headers in compiler-rt tests

[phosek]

Summary

The missing dependency was revealed by D97572.

[ldionne]

compiler-rt/test/profile/CMakeLists.txt

12 ↗

(On Diff #334595)

As I've said in https://bugs.chromium.org/p/chromium/issues/detail?id=1194745, I think the right fix would be to make sure that we run these tests against a properly installed copy of Clang + libc++. Instead, what this will do is add a -I path/to/configured/include/c++/v1 argument to the compiler, which should hopefully work but also exposes an implementation detail of libc++'s build (the cxx-headers target) to compiler-rt.

TLDR, I think this will work but it's not the ideal fix IMO.

[phosek]

compiler-rt/test/profile/CMakeLists.txt

12 ↗

(On Diff #334595)

I agree, but we still need to ensure that those headers are in place before we use them so we're still going to need that dependency.

[ldionne]

compiler-rt/test/profile/CMakeLists.txt

12 ↗

(On Diff #334595)

We could do that by ensuring that the compiler-rt build as a whole installs libc++ before running its tests, and then running against the just-installed library (both headers and dylib). But let's do this if it fixes the build now.

[ldionne]

I'd be curious to hear if that solves @thakis 's problems though.

[vitalybuka]

This probably breaks the bot https://lab.llvm.org/buildbot/#/builders/37/builds/3296

[phosek]

In D99706#2665635, @vitalybuka wrote:

This probably breaks the bot https://lab.llvm.org/buildbot/#/builders/37/builds/3296

Thanks for the heads up, I accidentally used set(...) instead of list(APPEND ...), it should be addressed by b0d286b03c6e20e57fd2ecf3ea7935669083f3e5.

compiler-rt/test/CMakeLists.txt

if(NOT COMPILER_RT_STANDALONE_BUILD AND NOT LLVM_RUNTIMES_BUILD)
     # Use LLVM utils and Clang from the same build tree.
     list(APPEND SANITIZER_COMMON_LIT_TEST_DEPS
       clang clang-resource-headers FileCheck count not llvm-config llvm-nm llvm-objdump
       llvm-readelf llvm-readobj llvm-size llvm-symbolizer compiler-rt-headers sancov)
     if (WIN32)
       list(APPEND SANITIZER_COMMON_LIT_TEST_DEPS KillTheDoctor)
     endif()
   endif()
+  # Tests use C++ standard library headers.
+  if (TARGET cxx-headers OR HAVE_LIBCXX)
+    set(SANITIZER_COMMON_LIT_TEST_DEPS cxx-headers)
+  endif()
 endif()
 
 function(compiler_rt_test_runtime runtime)
   string(TOUPPER ${runtime} runtime_uppercase)
   if(COMPILER_RT_HAS_${runtime_uppercase})
     add_subdirectory(${runtime})
     foreach(directory ${ARGN})
       add_subdirectory(${directory})