This is an archive of the discontinued LLVM Phabricator instance.

[test, HardwareLoops] Fix use of var defined in CHECK-NOT
ClosedPublic

Authored by thopre on Mar 30 2021, 6:56 AM.

Details

Summary

LLVM test Transforms/HardwareLoops/ARM/structure.ll tries to check for
the absence of a sequence of instructions with several CHECK-NOT with
one of those directives using a variable defined in another. However
CHECK-NOT are checked independently so that is using a variable defined
in a pattern that should not occur in the input.

This commit only checks for the absence of llvm.loop.decrement.i32 which
rules out the presence of the whole sequence and does not involve an
undefined variable.

Diff Detail

Event Timeline

thopre created this revision.Mar 30 2021, 6:56 AM
thopre requested review of this revision.Mar 30 2021, 6:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2021, 6:56 AM
dmgreen accepted this revision.Mar 30 2021, 7:02 AM

SGTM. Thanks.

This revision is now accepted and ready to land.Mar 30 2021, 7:02 AM
This revision was landed with ongoing or failed builds.Mar 30 2021, 7:06 AM
This revision was automatically updated to reflect the committed changes.