This is an archive of the discontinued LLVM Phabricator instance.

[MC][ARM] add .w suffixes for ORN/ORNS T1
ClosedPublic

Authored by nickdesaulniers on Mar 29 2021, 1:51 PM.

Details

Summary

See also:
F5.1.128 ORN, ORNS (register) T1 shift or rotate by value variant
of the Arm ARM.

Link: https://github.com/ClangBuiltLinux/linux/issues/1309

Diff Detail

Event Timeline

nickdesaulniers requested review of this revision.Mar 29 2021, 1:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 29 2021, 1:51 PM
DavidSpickett added inline comments.Mar 30 2021, 3:04 AM
llvm/test/MC/ARM/basic-thumb2-instructions.s
1884

Initially I thought that we shouldn't be allowing the flag setting S variant for v7 since it's not listed in the documentation. However that's just because on v7 they always set the flags so S or not it's the same thing.

1890

Add a .w check for one or more of the shift variants and the immediate.

  • add support and test coverage for immediates, and shifted register operands
nickdesaulniers marked an inline comment as done.Mar 31 2021, 2:55 PM
DavidSpickett accepted this revision.Apr 1 2021, 2:16 AM
This revision is now accepted and ready to land.Apr 1 2021, 2:16 AM
This revision was landed with ongoing or failed builds.Apr 1 2021, 10:27 AM
This revision was automatically updated to reflect the committed changes.