This is an archive of the discontinued LLVM Phabricator instance.

Differential D99464

MLIR][STD] Fold trunci (sexti).
ClosedPublic

Authored by ergawy on Mar 28 2021, 2:55 AM.

Details

Reviewers
mehdi_amini
Commits
rGc52a5f2aa796: MLIR][STD] Fold trunci (sexti).
Summary

This patch folds the following pattern:

%arg0 = ...
%0 = sexti %arg0 : i1 to i8
%1 = trunci %0 : i8 to i1

into just %arg0.

Diff Detail

Event Timeline

ergawy created this revision.Mar 28 2021, 2:55 AM
Herald added subscribers: dcaballe, cota, teijeong and 16 others. · View Herald TranscriptMar 28 2021, 2:55 AM
ergawy requested review of this revision.Mar 28 2021, 2:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2021, 2:55 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
ergawy added a reviewer: mehdi_amini.Mar 28 2021, 2:56 AM
ergawy updated this revision to Diff 333712.Mar 28 2021, 3:00 AM
  • Rearrange code a bit.
Harbormaster completed remote builds in B95995: Diff 333711.Mar 28 2021, 3:30 AM
Harbormaster completed remote builds in B95996: Diff 333712.Mar 28 2021, 3:39 AM
mehdi_amini accepted this revision.Mar 28 2021, 9:55 AM
This revision is now accepted and ready to land.Mar 28 2021, 9:55 AM
Closed by commit rGc52a5f2aa796: MLIR][STD] Fold trunci (sexti). (authored by ergawy). · Explain WhyMar 28 2021, 11:49 PM
This revision was automatically updated to reflect the committed changes.
ergawy added a commit: rGc52a5f2aa796: MLIR][STD] Fold trunci (sexti)..

Revision Contents

PathSize
mlir/
lib/
Dialect/
StandardOps/
IR/
4 lines
test/
Transforms/
11 lines

Diff 333712

mlir/lib/Dialect/StandardOps/IR/Ops.cpp

Show First 20 Lines • Show All 2,177 Lines • ▼ Show 20 Lines if (srcType.cast<IntegerType>().getWidth() <=
return op.emitError("operand type ") return op.emitError("operand type ")
<< srcType << " must be wider than result type " << dstType; << srcType << " must be wider than result type " << dstType;
return success(); return success();
} }
OpFoldResult TruncateIOp::fold(ArrayRef<Attribute> operands) { OpFoldResult TruncateIOp::fold(ArrayRef<Attribute> operands) {
// trunci(zexti(a)) -> a // trunci(zexti(a)) -> a
if (matchPattern(getOperand(), m_Op<ZeroExtendIOp>())) // trunci(sexti(a)) -> a
if (matchPattern(getOperand(), m_Op<ZeroExtendIOp>()) ||
matchPattern(getOperand(), m_Op<SignExtendIOp>()))
return getOperand().getDefiningOp()->getOperand(0); return getOperand().getDefiningOp()->getOperand(0);
return nullptr; return nullptr;
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// UnsignedDivIOp // UnsignedDivIOp
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
▲ Show 20 Lines • Show All 95 Lines • Show Last 20 Lines

mlir/test/Transforms/canonicalize.mlir

Show First 20 Lines • Show All 1,103 Lines • ▼ Show 20 Lines
func @do_not_fold_trunci_vector(%arg0: vector<4xi1>) -> vector<4xi2> attributes {} { func @do_not_fold_trunci_vector(%arg0: vector<4xi1>) -> vector<4xi2> attributes {} {
// CHECK-NEXT: zexti %[[ARG0]] : vector<4xi1> to vector<4xi8> // CHECK-NEXT: zexti %[[ARG0]] : vector<4xi1> to vector<4xi8>
// CHECK-NEXT: %[[RES:[0-9a-z]*]] = trunci %{{.*}} : vector<4xi8> to vector<4xi2> // CHECK-NEXT: %[[RES:[0-9a-z]*]] = trunci %{{.*}} : vector<4xi8> to vector<4xi2>
// CHECK-NEXT: return %[[RES]] : vector<4xi2> // CHECK-NEXT: return %[[RES]] : vector<4xi2>
%0 = zexti %arg0 : vector<4xi1> to vector<4xi8> %0 = zexti %arg0 : vector<4xi1> to vector<4xi8>
%1 = trunci %0 : vector<4xi8> to vector<4xi2> %1 = trunci %0 : vector<4xi8> to vector<4xi2>
return %1 : vector<4xi2> return %1 : vector<4xi2>
} }
// -----
// CHECK-LABEL: func @fold_trunci_sexti
// CHECK-SAME: (%[[ARG0:[0-9a-z]*]]: i1)
func @fold_trunci_sexti(%arg0: i1) -> i1 attributes {} {
// CHECK-NEXT: return %[[ARG0]] : i1
%0 = sexti %arg0 : i1 to i8
%1 = trunci %0 : i8 to i1
return %1 : i1
}