This is an archive of the discontinued LLVM Phabricator instance.

Differential D99318

[lld-macho] Add time tracing for LTO
ClosedPublic

Authored by int3 on Mar 24 2021, 11:18 PM.

Details

Reviewers
oontvoo
Group Reviewers
Restricted Project
Commits
rGae7aa9ed151d: [lld-macho] Add time tracing for LTO
Summary

The test is similar to the one used for LLD-ELF.

Diff Detail

Event Timeline

int3 created this revision.Mar 24 2021, 11:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2021, 11:18 PM
Herald added subscribers: steven_wu, hiraditya, inglorion. · View Herald Transcript
int3 requested review of this revision.Mar 24 2021, 11:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2021, 11:18 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B95636: Diff 333215.Mar 24 2021, 11:19 PM
oontvoo accepted this revision.Mar 25 2021, 9:59 AM
oontvoo added a subscriber: oontvoo.

Cool!

This revision is now accepted and ready to land.Mar 25 2021, 9:59 AM
tschuett added a subscriber: tschuett.Mar 25 2021, 10:03 AM
tschuett added inline comments.
lld/test/MachO/thinlto-time-trace.ll
23

British english?

int3 marked an inline comment as done.Mar 25 2021, 10:53 AM
int3 added inline comments.
lld/test/MachO/thinlto-time-trace.ll
23

ah this was copypasta

int3 updated this revision to Diff 333348.Mar 25 2021, 10:53 AM
int3 marked an inline comment as done.

USA USA USA

Harbormaster completed remote builds in B95723: Diff 333348.Mar 25 2021, 10:59 AM
This revision was landed with ongoing or failed builds.Mar 26 2021, 3:14 PM
Closed by commit rGae7aa9ed151d: [lld-macho] Add time tracing for LTO (authored by int3). · Explain Why
This revision was automatically updated to reflect the committed changes.
int3 added a commit: rGae7aa9ed151d: [lld-macho] Add time tracing for LTO.

Revision Contents

PathSize
lld/
MachO/
2 lines
test/
MachO/
45 lines

Diff 333215

lld/MachO/LTO.cpp

Show All 34 Linesstatic lto::Config createConfig() {
c.MAttrs = getMAttrs(); c.MAttrs = getMAttrs();
c.UseNewPM = config->ltoNewPassManager; c.UseNewPM = config->ltoNewPassManager;
c.PreCodeGenPassesHook = [](legacy::PassManager &pm) { c.PreCodeGenPassesHook = [](legacy::PassManager &pm) {
pm.add(createObjCARCContractPass()); pm.add(createObjCARCContractPass());
}; };
if (config->saveTemps) if (config->saveTemps)
checkError(c.addSaveTemps(config->outputFile.str() + ".", checkError(c.addSaveTemps(config->outputFile.str() + ".",
/*UseInputModulePath=*/true)); /*UseInputModulePath=*/true));
c.TimeTraceEnabled = config->timeTraceEnabled;
c.TimeTraceGranularity = config->timeTraceGranularity;
return c; return c;
} }
BitcodeCompiler::BitcodeCompiler() { BitcodeCompiler::BitcodeCompiler() {
lto::ThinBackend backend = lto::ThinBackend backend =
lto::createInProcessThinBackend(heavyweight_hardware_concurrency()); lto::createInProcessThinBackend(heavyweight_hardware_concurrency());
ltoObj = std::make_unique<lto::LTO>(createConfig(), backend); ltoObj = std::make_unique<lto::LTO>(createConfig(), backend);
} }
▲ Show 20 Lines • Show All 78 Lines • Show Last 20 Lines

lld/test/MachO/thinlto-time-trace.ll

  • This file was added.
; REQUIRES: x86
; RUN: rm -rf %t; split-file %s %t
; Test ThinLTO with time trace
; RUN: opt -module-summary %t/f.s -o %t/f.o
; RUN: opt -module-summary %t/g.s -o %t/g.o
; RUN: %lld --time-trace --time-trace-granularity=0 -dylib %t/f.o %t/g.o -o %t/libTest.dylib
; RUN: cat %t/libTest.dylib.time-trace \
; RUN: | %python -c 'import json, sys; json.dump(json.loads(sys.stdin.read()), sys.stdout, sort_keys=True, indent=2)' \
; RUN: | FileCheck %s
; CHECK: "traceEvents": [
; Check fields for an event are present
; CHECK: "args":
; CHECK-NEXT: "detail":
; CHECK: "dur":
; CHECK-NEXT: "name":
; CHECK-NEXT: "ph":
; CHECK-NEXT: "pid":
; CHECK-NEXT: "tid":
; CHECK-NEXT: "ts":
; Check that an optimisation event is present
tschuettUnsubmitted
Done
ReplyInline Actions

British english?

tschuett: British english?
int3AuthorUnsubmitted
Done
ReplyInline Actions

ah this was copypasta

int3: ah this was copypasta
; CHECK: "name": "OptModule"
;--- f.s
target triple = "x86_64-apple-darwin"
target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
declare void @g(...)
define void @f() {
entry:
call void (...) @g()
ret void
}
;--- g.s
target triple = "x86_64-apple-darwin"
target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
define void @g() {
entry:
ret void
}