This is an archive of the discontinued LLVM Phabricator instance.

Differential D99209

[AArch64] Support .arch_extension pan
ClosedPublic

Authored by mcgrathr on Mar 23 2021, 12:50 PM.

Details

Reviewers
phosek
Commits
rG3cb234698239: [AArch64] Support .arch_extension pan
Summary

This makes the behavior consistent with the GNU assembler.

Diff Detail

Event Timeline

mcgrathr created this revision.Mar 23 2021, 12:50 PM
Herald added subscribers: danielkiss, hiraditya, kristof.beyls. · View Herald TranscriptMar 23 2021, 12:50 PM
mcgrathr requested review of this revision.Mar 23 2021, 12:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2021, 12:50 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B95329: Diff 332764.Mar 23 2021, 5:32 PM
phosek accepted this revision.Mar 23 2021, 11:02 PM

LGTM

This revision is now accepted and ready to land.Mar 23 2021, 11:02 PM
Closed by commit rG3cb234698239: [AArch64] Support .arch_extension pan (authored by mcgrathr). · Explain WhyMar 24 2021, 11:29 AM
This revision was automatically updated to reflect the committed changes.
mcgrathr added a commit: rG3cb234698239: [AArch64] Support .arch_extension pan.

Revision Contents

PathSize
llvm/
lib/
Target/
AArch64/
AsmParser/
2 lines
test/
MC/
AArch64/
4 lines

Diff 332764

llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp

Show First 20 Lines • Show All 2,900 Lines • ▼ Show 20 Lines const FeatureBitset Features;
{"simd", {AArch64::FeatureNEON}}, {"simd", {AArch64::FeatureNEON}},
{"ras", {AArch64::FeatureRAS}}, {"ras", {AArch64::FeatureRAS}},
{"lse", {AArch64::FeatureLSE}}, {"lse", {AArch64::FeatureLSE}},
{"predres", {AArch64::FeaturePredRes}}, {"predres", {AArch64::FeaturePredRes}},
{"ccdp", {AArch64::FeatureCacheDeepPersist}}, {"ccdp", {AArch64::FeatureCacheDeepPersist}},
{"mte", {AArch64::FeatureMTE}}, {"mte", {AArch64::FeatureMTE}},
{"memtag", {AArch64::FeatureMTE}}, {"memtag", {AArch64::FeatureMTE}},
{"tlb-rmi", {AArch64::FeatureTLB_RMI}}, {"tlb-rmi", {AArch64::FeatureTLB_RMI}},
{"pan", {AArch64::FeaturePAN}},
{"pan-rwv", {AArch64::FeaturePAN_RWV}}, {"pan-rwv", {AArch64::FeaturePAN_RWV}},
{"ccpp", {AArch64::FeatureCCPP}}, {"ccpp", {AArch64::FeatureCCPP}},
{"rcpc", {AArch64::FeatureRCPC}}, {"rcpc", {AArch64::FeatureRCPC}},
{"rng", {AArch64::FeatureRandGen}}, {"rng", {AArch64::FeatureRandGen}},
{"sve", {AArch64::FeatureSVE}}, {"sve", {AArch64::FeatureSVE}},
{"sve2", {AArch64::FeatureSVE2}}, {"sve2", {AArch64::FeatureSVE2}},
{"sve2-aes", {AArch64::FeatureSVE2AES}}, {"sve2-aes", {AArch64::FeatureSVE2AES}},
{"sve2-sm4", {AArch64::FeatureSVE2SM4}}, {"sve2-sm4", {AArch64::FeatureSVE2SM4}},
{"sve2-sha3", {AArch64::FeatureSVE2SHA3}}, {"sve2-sha3", {AArch64::FeatureSVE2SHA3}},
{"sve2-bitperm", {AArch64::FeatureSVE2BitPerm}}, {"sve2-bitperm", {AArch64::FeatureSVE2BitPerm}},
{"ls64", {AArch64::FeatureLS64}}, {"ls64", {AArch64::FeatureLS64}},
{"xs", {AArch64::FeatureXS}}, {"xs", {AArch64::FeatureXS}},
{"pauth", {AArch64::FeaturePAuth}}, {"pauth", {AArch64::FeaturePAuth}},
{"flagm", {AArch64::FeatureFlagM}}, {"flagm", {AArch64::FeatureFlagM}},
// FIXME: Unsupported extensions // FIXME: Unsupported extensions
{"pan", {}},
{"lor", {}}, {"lor", {}},
{"rdma", {}}, {"rdma", {}},
{"profile", {}}, {"profile", {}},
}; };
static void setRequiredFeatureString(FeatureBitset FBS, std::string &Str) { static void setRequiredFeatureString(FeatureBitset FBS, std::string &Str) {
if (FBS[AArch64::HasV8_1aOps]) if (FBS[AArch64::HasV8_1aOps])
Str += "ARMv8.1a"; Str += "ARMv8.1a";
▲ Show 20 Lines • Show All 3,417 Lines • Show Last 20 Lines

llvm/test/MC/AArch64/directive-arch_extension.s

Show First 20 Lines • Show All 50 Lines • ▼ Show 20 Lines
.arch_extension memtag .arch_extension memtag
irg x0, x1 irg x0, x1
// CHECK: irg x0, x1 // CHECK: irg x0, x1
.arch_extension tlb-rmi .arch_extension tlb-rmi
tlbi vmalle1os tlbi vmalle1os
// CHECK: tlbi vmalle1os // CHECK: tlbi vmalle1os
.arch_extension pan
mrs x0, pan
// CHECK: mrs x0, PAN
.arch_extension pan-rwv .arch_extension pan-rwv
at s1e1wp, x2 at s1e1wp, x2
// CHECK: at s1e1wp, x2 // CHECK: at s1e1wp, x2
.arch_extension ccpp .arch_extension ccpp
dc cvap, x7 dc cvap, x7
// CHECK: dc cvap, x7 // CHECK: dc cvap, x7
Show All 15 Lines