This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Reserve ELF code
ClosedPublic

Authored by t-tye on Mar 22 2021, 3:30 PM.

Details

Summary

Reserve AMD GPU ELF machine code 0x040.

Minor AMDGPUUsage format consistency change.

Diff Detail

Event Timeline

t-tye created this revision.Mar 22 2021, 3:30 PM
t-tye requested review of this revision.Mar 22 2021, 3:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2021, 3:30 PM

probably update the title to reflect there is more than one change in the commit?

llvm/include/llvm/BinaryFormat/ELF.h
736–737

move this to line 736. make line 737 empty.

kzhuravl requested changes to this revision.Mar 22 2021, 4:16 PM

you also should add reserved number to docs.

This revision now requires changes to proceed.Mar 22 2021, 4:16 PM
t-tye updated this revision to Diff 332497.Mar 22 2021, 7:00 PM

Address review comments.

t-tye updated this revision to Diff 332514.Mar 22 2021, 8:47 PM

Address review comments.

kzhuravl accepted this revision.Mar 22 2021, 8:48 PM

Thanks.

llvm/include/llvm/BinaryFormat/ELF.h
736–737

move this to line 736. make line 737 empty.

This revision is now accepted and ready to land.Mar 22 2021, 8:48 PM
This revision was landed with ongoing or failed builds.Mar 22 2021, 9:31 PM
This revision was automatically updated to reflect the committed changes.