This is an archive of the discontinued LLVM Phabricator instance.

Differential D99060

Fix the order of directives and the target string
ClosedPublic

Authored by Chia-hungDuan on Mar 22 2021, 2:18 AM.

Details

Reviewers
jpienaar
Commits
rGcec244354bb1: Fix the order of directives and the target string
Summary

In the original structure, it will try to match CHECK-LABEL first then see if
the subsequent doesn't have the target strings. This is not what we are
expected. We are expecting the two functions which will be deleted should be
matched before CHECK-LABEL. Also fixed the function names.

Diff Detail

Unit TestsFailed

TimeTest
90 msx64 windows > MLIR.Conversion/PDLToPDLInterp::pdl-to-pdl-interp-matcher.mlir

Event Timeline

Chia-hungDuan created this revision.Mar 22 2021, 2:18 AM
Herald added subscribers: dcaballe, cota, teijeong and 16 others. · View Herald TranscriptMar 22 2021, 2:18 AM
Chia-hungDuan requested review of this revision.Mar 22 2021, 2:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2021, 2:18 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Chia-hungDuan added a reviewer: jpienaar.Mar 22 2021, 2:43 AM
Harbormaster completed remote builds in B94949: Diff 332222.Mar 22 2021, 3:37 AM
jpienaar accepted this revision.Mar 22 2021, 6:22 AM

Good catch

This revision is now accepted and ready to land.Mar 22 2021, 6:22 AM
This revision was landed with ongoing or failed builds.Mar 22 2021, 11:10 AM
Closed by commit rGcec244354bb1: Fix the order of directives and the target string (authored by Chia-hungDuan, committed by jpienaar). · Explain Why
This revision was automatically updated to reflect the committed changes.
jpienaar added a commit: rGcec244354bb1: Fix the order of directives and the target string.

Revision Contents

PathSize
mlir/
test/
mlir-reduce/
6 lines

Diff 332222

mlir/test/mlir-reduce/dce-test.mlir

// UNSUPPORTED: system-windows // UNSUPPORTED: system-windows
// RUN: mlir-reduce %s -test %S/failure-test.sh -pass-test DCE | FileCheck %s // RUN: mlir-reduce %s -test %S/failure-test.sh -pass-test DCE | FileCheck %s
// This input should be reduced by the pass pipeline so that only // This input should be reduced by the pass pipeline so that only
// the @simple1 function remains as the other functions should be // the @simple1 function remains as the other functions should be
// removed by the dead code elimination pass. // removed by the dead code elimination pass.
// CHECK-LABEL: func @simple1(%arg0: i1, %arg1: memref<2xf32>, %arg2: memref<2xf32>) {
// CHECK-NOT: func @dead_nested_function // CHECK-NOT: func private @dead_private_function
func private @dead_private_function() func private @dead_private_function()
// CHECK-NOT: func @dead_nested_function // CHECK-NOT: func nested @dead_nested_function
func nested @dead_nested_function() func nested @dead_nested_function()
// CHECK-LABEL: func @simple1(%arg0: i1, %arg1: memref<2xf32>, %arg2: memref<2xf32>) {
func @simple1(%arg0: i1, %arg1: memref<2xf32>, %arg2: memref<2xf32>) { func @simple1(%arg0: i1, %arg1: memref<2xf32>, %arg2: memref<2xf32>) {
"test.crashOp" () : () -> () "test.crashOp" () : () -> ()
return return
} }