This is an archive of the discontinued LLVM Phabricator instance.

Differential D98985

[test] Enable check-lsan on aarch64-*-linux
ClosedPublic

Authored by MaskRay on Mar 19 2021, 1:37 PM.

Details

Reviewers
resistor
vitalybuka
Group Reviewers
Restricted Project
Commits
rGfdf97bc73891: [test] Enable check-lsan on aarch64-*-linux
Summary

check-lsan passed on an aarch64-*-linux machine.

Unsupport many_tls_keys_pthread.cpp for now: it requires GetTls to include
specific_1stblock and specific in struct pthread.

Diff Detail

Event Timeline

MaskRay created this revision.Mar 19 2021, 1:37 PM
Herald added subscribers: danielkiss, s.egerton, simoncook, kristof.beyls. · View Herald TranscriptMar 19 2021, 1:37 PM
MaskRay requested review of this revision.Mar 19 2021, 1:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 19 2021, 1:37 PM
resistor accepted this revision.Mar 19 2021, 1:38 PM
This revision is now accepted and ready to land.Mar 19 2021, 1:38 PM
Harbormaster completed remote builds in B94782: Diff 331992.Mar 19 2021, 3:49 PM
MaskRay updated this revision to Diff 332031.Mar 19 2021, 4:30 PM
MaskRay edited the summary of this revision. (Show Details)

Unsupport one test.

D98926 can make new support easier.

Harbormaster completed remote builds in B94811: Diff 332031.Mar 19 2021, 5:05 PM
vitalybuka accepted this revision.Mar 23 2021, 10:58 AM
MaskRay updated this revision to Diff 332733.Mar 23 2021, 11:10 AM

Improve a comment

This revision was landed with ongoing or failed builds.Mar 23 2021, 11:11 AM
Closed by commit rGfdf97bc73891: [test] Enable check-lsan on aarch64-*-linux (authored by MaskRay). · Explain Why
This revision was automatically updated to reflect the committed changes.
MaskRay added a commit: rGfdf97bc73891: [test] Enable check-lsan on aarch64-*-linux.
Harbormaster completed remote builds in B95308: Diff 332733.Mar 23 2021, 3:40 PM
MaskRay mentioned this in rG04dbb63400c5: [lsan][test] Enable many_tls_keys_pthread.cpp and disable swapcontext..Mar 26 2021, 11:26 AM

Revision Contents

PathSize
compiler-rt/
test/
lsan/
TestCases/
5 lines
2 lines

Diff 332734

compiler-rt/test/lsan/TestCases/many_tls_keys_pthread.cpp

// Test that lsan handles tls correctly for many threads // Test that lsan handles tls correctly for many threads
// RUN: LSAN_BASE="report_objects=1:use_stacks=0:use_registers=0" // RUN: LSAN_BASE="report_objects=1:use_stacks=0:use_registers=0"
// RUN: %clangxx_lsan %s -o %t // RUN: %clangxx_lsan %s -o %t
// RUN: %env_lsan_opts=$LSAN_BASE:"use_tls=0" not %run %t 2>&1 | FileCheck %s // RUN: %env_lsan_opts=$LSAN_BASE:"use_tls=0" not %run %t 2>&1 | FileCheck %s
// RUN: %env_lsan_opts=$LSAN_BASE:"use_tls=1" %run %t 2>&1 // RUN: %env_lsan_opts=$LSAN_BASE:"use_tls=1" %run %t 2>&1
// RUN: %env_lsan_opts="" %run %t 2>&1 // RUN: %env_lsan_opts="" %run %t 2>&1
// Patch r303906 did not fix all the problems. // On glibc, this requires the range returned by GetTLS to include
// UNSUPPORTED: arm-linux,armhf-linux // specific_1stblock and specific in `struct pthread`.
// UNSUPPORTED: arm-linux, armhf-linux, aarch64
// TSD on NetBSD does not use TLS // TSD on NetBSD does not use TLS
// UNSUPPORTED: netbsd // UNSUPPORTED: netbsd
#include <assert.h> #include <assert.h>
#include <limits.h> #include <limits.h>
#include <pthread.h> #include <pthread.h>
#include <stdlib.h> #include <stdlib.h>
▲ Show 20 Lines • Show All 60 Lines • Show Last 20 Lines

compiler-rt/test/lsan/lit.common.cfg.py

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Lines
config.substitutions.append( ("%clang ", build_invocation(clang_cflags)) ) config.substitutions.append( ("%clang ", build_invocation(clang_cflags)) )
config.substitutions.append( ("%clangxx ", build_invocation(clang_cxxflags)) ) config.substitutions.append( ("%clangxx ", build_invocation(clang_cxxflags)) )
config.substitutions.append( ("%clang_lsan ", build_invocation(clang_lsan_cflags)) ) config.substitutions.append( ("%clang_lsan ", build_invocation(clang_lsan_cflags)) )
config.substitutions.append( ("%clangxx_lsan ", build_invocation(clang_lsan_cxxflags)) ) config.substitutions.append( ("%clangxx_lsan ", build_invocation(clang_lsan_cxxflags)) )
# LeakSanitizer tests are currently supported on # LeakSanitizer tests are currently supported on
# Android{aarch64, x86, x86_64}, x86-64 Linux, PowerPC64 Linux, arm Linux, mips64 Linux, s390x Linux and x86_64 Darwin. # Android{aarch64, x86, x86_64}, x86-64 Linux, PowerPC64 Linux, arm Linux, mips64 Linux, s390x Linux and x86_64 Darwin.
supported_android = config.android and config.target_arch in ['x86_64', 'i386', 'aarch64'] and 'android-thread-properties-api' in config.available_features supported_android = config.android and config.target_arch in ['x86_64', 'i386', 'aarch64'] and 'android-thread-properties-api' in config.available_features
supported_linux = (not config.android) and config.host_os == 'Linux' and config.host_arch in ['x86_64', 'ppc64', 'ppc64le', 'mips64', 'riscv64', 'arm', 'armhf', 'armv7l', 's390x'] supported_linux = (not config.android) and config.host_os == 'Linux' and config.host_arch in ['aarch64', 'x86_64', 'ppc64', 'ppc64le', 'mips64', 'riscv64', 'arm', 'armhf', 'armv7l', 's390x']
supported_darwin = config.host_os == 'Darwin' and config.target_arch in ['x86_64'] supported_darwin = config.host_os == 'Darwin' and config.target_arch in ['x86_64']
supported_netbsd = config.host_os == 'NetBSD' and config.target_arch in ['x86_64', 'i386'] supported_netbsd = config.host_os == 'NetBSD' and config.target_arch in ['x86_64', 'i386']
if not (supported_android or supported_linux or supported_darwin or supported_netbsd): if not (supported_android or supported_linux or supported_darwin or supported_netbsd):
config.unsupported = True config.unsupported = True
# Don't support Thumb due to broken fast unwinder # Don't support Thumb due to broken fast unwinder
if re.search('mthumb', config.target_cflags) is not None: if re.search('mthumb', config.target_cflags) is not None:
config.unsupported = True config.unsupported = True
config.suffixes = ['.c', '.cpp', '.mm'] config.suffixes = ['.c', '.cpp', '.mm']