Page MenuHomePhabricator

NFC: Break up the mlir python bindings into individual sources.
ClosedPublic

Authored by stellaraccident on Mar 19 2021, 11:58 AM.

Details

Summary
  • IRModules.cpp -> (IRCore.cpp, IRAffine.cpp, IRAttributes.cpp, IRTypes.cpp).
  • The individual pieces now compile in the 5-15s range whereas IRModules.cpp was starting to approach a minute (didn't capture a before time).
  • More fine grained splitting is possible, but this represents the most obvious.

Diff Detail

Event Timeline

stellaraccident requested review of this revision.Mar 19 2021, 11:58 AM
This revision is now accepted and ready to land.Mar 19 2021, 12:31 PM
This revision was landed with ongoing or failed builds.Mar 19 2021, 1:34 PM
This revision was automatically updated to reflect the committed changes.

I was bugged about this, just not reached the point to split it up myself yet :)

I was bugged about this, just not reached the point to split it up myself yet :)

Yeah, same here - been meaning to do it since we discussed it weeks (months?) ago.