This is an archive of the discontinued LLVM Phabricator instance.

Differential D98853

[test] Fix incorrect use of string variable use
ClosedPublic

Authored by thopre on Mar 18 2021, 3:56 AM.

Details

Reviewers
tellenbach
ostannard
samparker
chill
pbarrio
Commits
rGb79044391eb2: [test] Fix incorrect use of string variable use
Summary

LLVM test CodeGen/AArch64/machine-outliner-retaddr-sign-thunk.ll uses
a string substitution block that contains a regex matching block. This
seems like as a copy/paste from other similar test where the match also
defines a variable, hence the [[]] syntax. In this case however this is
a CHECK-NOT variable so nothing should match. No variable definition is
thus expected and the square brackets can be dropped.

Diff Detail

Event Timeline

thopre created this revision.Mar 18 2021, 3:56 AM
Herald added a subscriber: kristof.beyls. · View Herald TranscriptMar 18 2021, 3:56 AM
thopre requested review of this revision.Mar 18 2021, 3:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2021, 3:56 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
thopre mentioned this in D98691: [FileCheck] Fix PR49531: invalid use of string var.Mar 18 2021, 4:01 AM
chill accepted this revision.Mar 18 2021, 4:13 AM
This revision is now accepted and ready to land.Mar 18 2021, 4:13 AM
Harbormaster completed remote builds in B94426: Diff 331512.Mar 18 2021, 4:37 AM
Closed by commit rGb79044391eb2: [test] Fix incorrect use of string variable use (authored by thopre). · Explain WhyMar 18 2021, 5:19 AM
This revision was automatically updated to reflect the committed changes.
thopre added a commit: rGb79044391eb2: [test] Fix incorrect use of string variable use.

Revision Contents

PathSize
llvm/
test/
CodeGen/
AArch64/
2 lines

Diff 331526

llvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-thunk.ll

Show First 20 Lines • Show All 61 Lines • ▼ Show 20 Lines
entry: entry:
%call = tail call i32 %fptr(i32 1, i32 2, i32 3, i32 4) %call = tail call i32 %fptr(i32 1, i32 2, i32 3, i32 4)
%add = add nsw i32 %call, 88 %add = add nsw i32 %call, 88
ret i32 %add ret i32 %add
} }
attributes #0 = { "sign-return-address"="non-leaf" } attributes #0 = { "sign-return-address"="non-leaf" }
; CHECK-NOT: [[OUTLINED_FUNCTION_{{.*}}]] ; CHECK-NOT: OUTLINED_FUNCTION_{{.*}}
; CHECK-NOT: .cfi_b_key_frame ; CHECK-NOT: .cfi_b_key_frame
; CHECK-NOT: paci{{[a,b]}}sp ; CHECK-NOT: paci{{[a,b]}}sp
; CHECK-NOT: hint #2{{[5,7]}} ; CHECK-NOT: hint #2{{[5,7]}}
; CHECK-NOT: .cfi_negate_ra_state ; CHECK-NOT: .cfi_negate_ra_state
; CHECK-NOT: auti{{[a,b]}}sp ; CHECK-NOT: auti{{[a,b]}}sp
; CHECK-NOT: hint #{{[29,31]}} ; CHECK-NOT: hint #{{[29,31]}}