This is an archive of the discontinued LLVM Phabricator instance.

Differential D98667

Support !heapallocsite attachments in stripNonLineTableDebugInfo().
ClosedPublic

Authored by aprantl on Mar 15 2021, 4:25 PM.

Details

Reviewers
vsk
MaskRay
dexonsmith
Commits
rGb04c87e05376: Support !heapallocsite attachments in stripNonLineTableDebugInfo().
Summary

They point into the DIType type system, so they need to be stripped as well.




rdar://75341300
Diff Detail
Event Timeline
aprantl created this revision.Mar 15 2021, 4:25 PM
Herald added subscribers: dexonsmith, ormris, hiraditya.  ·  View Herald TranscriptMar 15 2021, 4:25 PM
aprantl requested review of this revision.Mar 15 2021, 4:25 PM
Herald added a project: Restricted Project.  ·  View Herald TranscriptMar 15 2021, 4:25 PM
aprantl added a child revision: D98668: Support !heapallocsite attachments in StripDebugInfo().     .Mar 15 2021, 4:28 PM
aprantl retitled this revision from Support !heapallocsite attachments in StripTableDebugInfo(). to Support !heapallocsite attachments in stripNonLineTableDebugInfo()..
aprantl added a reviewer: MaskRay.Mar 15 2021, 4:43 PM
dexonsmith accepted this revision.Mar 15 2021, 5:14 PM
LGTM.
This revision is now accepted and ready to land.Mar 15 2021, 5:14 PM
Harbormaster completed remote builds in B93940: Diff 330837.Mar 15 2021, 6:09 PM
vsk mentioned this in D98668: Support !heapallocsite attachments in StripDebugInfo().     .Mar 16 2021, 9:59 AM
This revision was landed with ongoing or failed builds.Mar 16 2021, 10:05 AM
Closed by commit rGb04c87e05376: Support !heapallocsite attachments in stripNonLineTableDebugInfo(). (authored by aprantl).  ·  Explain Why
This revision was automatically updated to reflect the committed changes.
aprantl added a commit: rGb04c87e05376: Support !heapallocsite attachments in stripNonLineTableDebugInfo()..
Revision Contents
PathSize
llvm/
lib/
IR/
4 lines
test/
Transforms/
Util/
46 lines
Diff 331027
llvm/lib/IR/DebugInfo.cpp
Show First 20 Lines • Show All 648 Lines • ▼ Show 20 Lines    for (auto &BB : F) {




        if (I.getDebugLoc() != DebugLoc())
        if (I.getDebugLoc() != DebugLoc())

          I.setDebugLoc(remapDebugLoc(I.getDebugLoc()));
          I.setDebugLoc(remapDebugLoc(I.getDebugLoc()));




        // Remap DILocations in llvm.loop attachments.
        // Remap DILocations in llvm.loop attachments.

        updateLoopMetadataDebugLocations(I, [&](const DILocation &Loc) {
        updateLoopMetadataDebugLocations(I, [&](const DILocation &Loc) {

          return remapDebugLoc(&Loc).get();
          return remapDebugLoc(&Loc).get();

        });
        });



        // Strip heapallocsite attachments, they point into the DIType system.

        if (I.hasMetadataOtherThanDebugLoc())

          I.setMetadata("heapallocsite", nullptr);

      }
      }

    }
    }

  }
  }




  // Create a new llvm.dbg.cu, which is equivalent to the one
  // Create a new llvm.dbg.cu, which is equivalent to the one

  // -gline-tables-only would have created.
  // -gline-tables-only would have created.

  for (auto &NMD : M.getNamedMDList()) {
  for (auto &NMD : M.getNamedMDList()) {

    SmallVector<MDNode *, 8> Ops;
    SmallVector<MDNode *, 8> Ops;

▲ Show 20 Lines • Show All 819 Lines • Show Last 20 Lines
llvm/test/Transforms/Util/strip-nonlinetable-debuginfo-heapallocsite.ll
  • This file was added.
; RUN: opt -S -strip-nonlinetable-debuginfo %s -o - |  FileCheck %s

; int *get() { return new int[256]; }

; ModuleID = '/tmp/heapallocsite.cpp'

source_filename = "/tmp/heapallocsite.cpp"

target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"

target triple = "x86_64-apple-macosx11.0.0"



; Function Attrs: noinline optnone ssp uwtable mustprogress

define dso_local i32* @_Z3getv() #0 !dbg !8 {

entry:

; CHECK-LABEL: entry:

; CHECK-NOT: !heapallocsite

  %call = call noalias nonnull i8* @_Znam(i64 1024) #2, !dbg !14, !heapallocsite !13

  %0 = bitcast i8* %call to i32*, !dbg !14

  ret i32* %0, !dbg !15

}



; Function Attrs: nobuiltin allocsize(0)

declare nonnull i8* @_Znam(i64) #1



attributes #0 = { noinline optnone ssp uwtable mustprogress }

attributes #1 = { nobuiltin allocsize(0) "frame-pointer"="all" }

attributes #2 = { builtin allocsize(0) }



!llvm.dbg.cu = !{!0}

!llvm.module.flags = !{!3, !4, !5, !6}

!llvm.ident = !{!7}



; CHECK-LABEL: !0 =

; CHECK-NOT: !DIBasicType(name: "int"

!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus_14, file: !1, producer: "clang version 13.0.0 (git@github.com:llvm/llvm-project 6d4ce49dae17715de502acbd50ab4c9b3c18215b)", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, enums: !2, nameTableKind: None, sysroot: "/")

!1 = !DIFile(filename: "/tmp/heapallocsite.cpp", directory: "/Volumes/Data/llvm-project")

!2 = !{}

!3 = !{i32 7, !"Dwarf Version", i32 4}

!4 = !{i32 2, !"Debug Info Version", i32 3}

!5 = !{i32 1, !"wchar_size", i32 4}

!6 = !{i32 7, !"PIC Level", i32 2}

!7 = !{!"clang version 13.0.0 (git@github.com:llvm/llvm-project 6d4ce49dae17715de502acbd50ab4c9b3c18215b)"}

!8 = distinct !DISubprogram(name: "get", linkageName: "_Z3getv", scope: !9, file: !9, line: 1, type: !10, scopeLine: 1, flags: DIFlagPrototyped, spFlags: DISPFlagDefinition, unit: !0, retainedNodes: !2)

!9 = !DIFile(filename: "/tmp/heapallocsite.cpp", directory: "")

!10 = !DISubroutineType(types: !11)

!11 = !{!12}

!12 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !13, size: 64)

!13 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed)

!14 = !DILocation(line: 1, column: 21, scope: !8)

!15 = !DILocation(line: 1, column: 14, scope: !8)