[cmake] Link to libnetwork on Haiku in llvm-jitlink

[nielx]

Summary

The system's network API is in libnetwork.so, so we explicitly need to link to them on Haiku. This patch is similar to https://reviews.llvm.org/D97633.

[nielx]

Adding reviewer ASDenysPetrov (you recently reviewed some other work on this tool)

[ASDenysPetrov]

In D98405#2639463, @nielx wrote:

Adding reviewer ASDenysPetrov (you recently reviewed some other work on this tool)

Sorry, I have to refuse your invitation. I have no competence in this. I was a reviewer for other revisions just because I've accidentally discovered fails of several tests on my environment (Windows+GCC+MSYS2), found a causer and raised an issue. I was just testing those patches using my specific environment and giving feedbacks, but not verifing the correctness.

[serge-sans-paille]

You may need to do the same change in llvm/tools/llvm-jitlink/CMakeLists.txt, which makes me think it may valuable to implement a decent check à la autoconf to check for the actual symbol you're looking for, probably based on a sequence of CHECK_LIBRARY_EXISTS. Would you be ok to do that change?

[nielx]

In D98405#2673557, @serge-sans-paille wrote:

You may need to do the same change in llvm/tools/llvm-jitlink/CMakeLists.txt, which makes me think it may valuable to implement a decent check à la autoconf to check for the actual symbol you're looking for, probably based on a sequence of CHECK_LIBRARY_EXISTS. Would you be ok to do that change?

Thank you for having a look at the patch, I appreciate it!

Not sure whether I fully understand you, but I made the change both in llvm/tools/llvm-jitlink/CMakeLists.txt and llvm/tools/llvm-jitlink/llvm-jitlink-executor/CMakeLists.txt, is there another place that links to the network symbols?

About making it more generic, I would be okay looking into that, but I am slightly doubtful of the added value. The Haiku ABI is stable, and there is no version in existence that has these symbols in another place. I therefore don't know what the added value would be of doing a dynamic check for something that's by definition static.

[lhames]

If we acquire too many of these special cases then we should consider creating some more generic CMake infrastructure for them, but I think for now this is fine as-is.

Do you have commit access? If not please let me know and I can commit on your behalf.

[nielx]

In D98405#2739133, @lhames wrote:

Do you have commit access? If not please let me know and I can commit on your behalf.

I do not have commit access, so I appreciate the help there.

llvm/tools/llvm-jitlink/CMakeLists.txt

set(LLVM_LINK_COMPONENTS
   )
 
 add_llvm_tool(llvm-jitlink
   llvm-jitlink.cpp
   llvm-jitlink-elf.cpp
   llvm-jitlink-macho.cpp
   )
 
+if(${CMAKE_SYSTEM_NAME} MATCHES "Haiku")
+  target_link_libraries(llvm-jitlink PRIVATE network)
+endif()
+
 if(${CMAKE_SYSTEM_NAME} MATCHES "SunOS")
   target_link_libraries(llvm-jitlink PRIVATE socket nsl)
 endif()
 
 export_executable_symbols(llvm-jitlink)

llvm/tools/llvm-jitlink/llvm-jitlink-executor/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
   OrcShared
   OrcTargetProcess
   Support
   )
 
 add_llvm_utility(llvm-jitlink-executor
   llvm-jitlink-executor.cpp
 
   DEPENDS
   intrinsics_gen
 )
 
+if(${CMAKE_SYSTEM_NAME} MATCHES "Haiku")
+  target_link_libraries(llvm-jitlink-executor PRIVATE network)
+endif()
+
 if(${CMAKE_SYSTEM_NAME} MATCHES "SunOS")
   target_link_libraries(llvm-jitlink-executor PRIVATE socket)
 endif()
 
 export_executable_symbols(llvm-jitlink-executor)