[cmake] Link socket/nsl on SunOS in llvm-jitlink

[nikic]

Summary

llvm-jitlink and llvm-jitlink-executor make use of APIs that are part of the socket and nsl libraries on SunOS systems (Solaris and Illumos). Make sure they get linked.

Ran into this in Rust CI when cross-compiling LLVM 12 to these targets.

My cmake-foo is rather weak, so I took inspiration from this check for SunOS: https://github.com/llvm/llvm-project/blob/ca5247bb1770a1dfa56b78303d99f1cc9a0a06ee/llvm/utils/benchmark/src/CMakeLists.txt#L43-L45

[serge-sans-paille]

llvm/tools/llvm-jitlink/CMakeLists.txt

28

Are socket and nsl libraries standard and always available, or should we check for them?

llvm/tools/llvm-jitlink/llvm-jitlink-executor/CMakeLists.txt

14

debug leftover?

[nikic]

Remove debug code

[nikic]

llvm/tools/llvm-jitlink/CMakeLists.txt

28

For Solaris-like systems, I believe so. The closest to official documentation on the topic I found is that Oracle man pages list -lsocket -lnsl for socket-related APIs: https://docs.oracle.com/cd/E86824_01/html/E54774/socket-3socket.html

I originally used find_library() but then switched to checking the system after seeing that we already have a couple of checks like this.

llvm/tools/llvm-jitlink/llvm-jitlink-executor/CMakeLists.txt

14

Ooops, indeed :)

[serge-sans-paille]

LGTM then, obviously I trust you on the portability aspect ;-)

llvm/tools/llvm-jitlink/CMakeLists.txt

set(LLVM_LINK_COMPONENTS
   )
 
 add_llvm_tool(llvm-jitlink
   llvm-jitlink.cpp
   llvm-jitlink-elf.cpp
   llvm-jitlink-macho.cpp
   )
 
+if(${CMAKE_SYSTEM_NAME} MATCHES "SunOS")
+  target_link_libraries(llvm-jitlink PRIVATE socket nsl)
+endif()
+
 export_executable_symbols(llvm-jitlink)

llvm/tools/llvm-jitlink/llvm-jitlink-executor/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
   OrcShared
   OrcTargetProcess
   Support
   )
 
 add_llvm_utility(llvm-jitlink-executor
   llvm-jitlink-executor.cpp
 
   DEPENDS
   intrinsics_gen
 )
 
+if(${CMAKE_SYSTEM_NAME} MATCHES "SunOS")
+  target_link_libraries(llvm-jitlink-executor PRIVATE socket)
+endif()
+
 export_executable_symbols(llvm-jitlink-executor)