Page MenuHomePhabricator

[mlir] Remove unnecessary copying of pass options
ClosedPublic

Authored by csigg on Mar 10 2021, 12:38 PM.

Details

Summary

I missed a comment in D98279 that you don't need to copy pass options.

Diff Detail

Event Timeline

csigg created this revision.Mar 10 2021, 12:38 PM
csigg requested review of this revision.Mar 10 2021, 12:38 PM

I'm wondering though, wouldn't it be cleaner to implement the copy c'tor for Pass::Option so that passes (like SerializeToBlobPass here) can use the default copy c'tor?

rriddle accepted this revision.Mar 10 2021, 12:51 PM
This revision is now accepted and ready to land.Mar 10 2021, 12:51 PM
This revision was landed with ongoing or failed builds.Mar 10 2021, 12:55 PM
This revision was automatically updated to reflect the committed changes.