This is an archive of the discontinued LLVM Phabricator instance.

[ValueTypes][RISCV] Add MVT for v1f16.
ClosedPublic

Authored by craig.topper on Mar 10 2021, 11:56 AM.

Details

Summary

RISCV makes all fixed vector MVTs with size less than or equal
to a command line option legal.

This didn't include v1f16 because it was missing but did include v1f32 and v1f64.

One test is affectd where we did test this type, but it is a horizontal
reduction so it is non-sensical. Perhaps we should canonicalize that
away somewhere.

I'm not sure if we should be making v1 types legal, but this will at
least make RISCV consistent across all types.

Diff Detail

Event Timeline

craig.topper created this revision.Mar 10 2021, 11:56 AM
craig.topper requested review of this revision.Mar 10 2021, 11:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2021, 11:56 AM
frasercrmck accepted this revision.Mar 11 2021, 1:29 AM

I think consistency is worthwhile, though I too question the sensibility of maintaining a v1 reduction.

Nit, that there's a typo in your commit message: affectd.

LGTM otherwise.

This revision is now accepted and ready to land.Mar 11 2021, 1:29 AM
This revision was landed with ongoing or failed builds.Mar 11 2021, 9:24 AM
This revision was automatically updated to reflect the committed changes.