This is an archive of the discontinued LLVM Phabricator instance.

Differential D98336

[mlir][CMAKE] Fix build with BUILD_SHARED_LIBS=ON
ClosedPublic

Authored by vinograd47 on Mar 10 2021, 5:17 AM.

Details

Reviewers
ftynse
Commits
rGb599f464d4aa: [mlir][CMAKE] Fix build with BUILD_SHARED_LIBS=ON
Summary

Link MLIRStandardToLLVM to MLIRAVX512Transforms, since
the latter uses LLVMTypeConverter defined in the first one.

Diff Detail

Event Timeline

vinograd47 created this revision.Mar 10 2021, 5:17 AM
Herald added subscribers: dcaballe, cota, teijeong and 17 others. · View Herald TranscriptMar 10 2021, 5:17 AM
vinograd47 requested review of this revision.Mar 10 2021, 5:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2021, 5:17 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
vinograd47 added a comment.Mar 10 2021, 5:19 AM

@ftynse I believe the issue was caused by D98328

ftynse accepted this revision.Mar 10 2021, 5:37 AM

Thanks!

This revision is now accepted and ready to land.Mar 10 2021, 5:37 AM
ftynse added a comment.Mar 10 2021, 5:52 AM

Please feel free to push small build fixes directly to save time.

This revision was landed with ongoing or failed builds.Mar 10 2021, 5:52 AM
Closed by commit rGb599f464d4aa: [mlir][CMAKE] Fix build with BUILD_SHARED_LIBS=ON (authored by vinograd47, committed by ftynse). · Explain Why
This revision was automatically updated to reflect the committed changes.
ftynse added a commit: rGb599f464d4aa: [mlir][CMAKE] Fix build with BUILD_SHARED_LIBS=ON.
Harbormaster completed remote builds in B93067: Diff 329623.Mar 10 2021, 3:25 PM

Revision Contents

PathSize
mlir/
lib/
Dialect/
AVX512/
Transforms/
1 line

Diff 329623

mlir/lib/Dialect/AVX512/Transforms/CMakeLists.txt

add_mlir_dialect_library(MLIRAVX512Transforms add_mlir_dialect_library(MLIRAVX512Transforms
LegalizeForLLVMExport.cpp LegalizeForLLVMExport.cpp
DEPENDS DEPENDS
MLIRAVX512ConversionsIncGen MLIRAVX512ConversionsIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAVX512 MLIRAVX512
MLIRIR MLIRIR
MLIRLLVMIR MLIRLLVMIR
MLIRStandardToLLVM
) )