This const_cast is not nice. For its removal one can do either of:
Could you simplify the test case? It sounds like all you need is a single global variable (int foo = 47;), without any functions or that stuff. I guess we should also delete test/Shell/Breakpoint/implicit_const_form_support.test, as it's not very useful (the numbers it checks come from the line table, not from the implicit constants). Other than that, this seems fine.
this is not the first const_cast of DWARFUnits, so, while definitely not ideal, I'm not particularly worried about it.
I hope these are not necessary, since you don't run the code here.
I guess we should also delete test/Shell/Breakpoint/implicit_const_form_support.test, as it's not very useful (the numbers it checks come from the line table, not from the implicit constants).
I have not deleted it myself; I find non-racy simple tests to be always good as they may catch some completely unrelated regression in the future.
-# UNSUPPORTED: system-darwin, system-windows -# REQUIRES: x86
We will see after all the bots run again.
Fine, I'll do it afterwards. :) If it was at least testing what it claims it's testing, I might keep it. However, judging by the need to re-fix implicit const support, it's not doing a good job at even that.
Sorry, I only meant the system-*** thingies. The REQUIRES: x86 thingy was correct, as it will cause the test to be skipped if someone completely disables x86 support (via LLVM_TARGETS_TO_BUILD).
That said, no bot actually builds lldb in that way, so I'm sure we have a lot of tests which are missing this clause.