[OpenCL][Docs] Release 12.0 notes

[Anastasia]

Summary

The notes cover functionality in clang added by commits from 16 July to 27th Jan.

[svenvh]

clang/docs/ReleaseNotes.rst

208

211

214

Perhaps one more point to mention:

- Allow pointer-to-pointer kernel arguments beyond OpenCL 1.2.

(related commit is 523775f96742 ("[OpenCL] Allow pointer-to-pointer kernel args beyond CL 1.2", 2020-12-01)).

222

Nitpick: you're mixing past and present tense ("added" vs "fix"). It would be nicer for consistency to use the same tense everywhere.

[Anastasia]

Added corrections from Sven.

[Anastasia]

clang/docs/ReleaseNotes.rst

214

I have covered it in this but it is combined with another diagnostic:

- Improved diagnostics for nested pointers and unevaluated ``vec_step`` expression.

But if you think it is better I can change as you have suggested.

[svenvh]

clang/docs/ReleaseNotes.rst

214

Ah, that's probably why I missed it, as I was assuming "improved diagnostics" means a nicer error message, not that Clang now accepts something that it rejected before. So in my opinion it deserves a point on its own.

[Anastasia]

clang/docs/ReleaseNotes.rst

214

Ok, do you think we should use nested pointers instead of pointer-to-pointer because your change seems to work with any number of pointers. Although I appreciate that the latter one is a spec terminology.

[svenvh]

clang/docs/ReleaseNotes.rst

214

No preference, but we could even mention both terms for completeness perhaps?

[Anastasia]

clang/docs/ReleaseNotes.rst

214

Do you mean something like:

- Allow nested pointers (e.g. pointer-to-pointer) kernel arguments beyond OpenCL 1.2.

[svenvh]

clang/docs/ReleaseNotes.rst

214

Looks good to me.

[Anastasia]

• Added nested pointer item
• Elaborated list of removed extensions with no kernel language changes.

[Anastasia]

Sorry for the last-minute change, I have decided to add this too:

+- Removed extensions without kernel language changes:
+  ``cl_khr_select_fprounding_mode``, ``cl_khr_gl_sharing``, ``cl_khr_icd``,
+  ``cl_khr_gl_event``, ``cl_khr_d3d10_sharing``, ``cl_khr_context_abort``,
+  ``cl_khr_d3d11_sharing``, ``cl_khr_dx9_media_sharing``,
+  ``cl_khr_image2d_from_buffer``, ``cl_khr_initialize_memory``,
+  ``cl_khr_gl_depth_images``, ``cl_khr_spir``, ``cl_khr_egl_event``,
+  ``cl_khr_egl_image``, ``cl_khr_terminate_context``.

[Anastasia]

@tstellar is it ok if I commit this to the release branch or do you prefer to do it yourself?

[svenvh]

In D98076#2619425, @Anastasia wrote:

Sorry for the last-minute change, I have decided to add this too:

+- Removed extensions without kernel language changes:
+  ``cl_khr_select_fprounding_mode``, ``cl_khr_gl_sharing``, ``cl_khr_icd``,
+  ``cl_khr_gl_event``, ``cl_khr_d3d10_sharing``, ``cl_khr_context_abort``,
+  ``cl_khr_d3d11_sharing``, ``cl_khr_dx9_media_sharing``,
+  ``cl_khr_image2d_from_buffer``, ``cl_khr_initialize_memory``,
+  ``cl_khr_gl_depth_images``, ``cl_khr_spir``, ``cl_khr_egl_event``,
+  ``cl_khr_egl_image``, ``cl_khr_terminate_context``.

Makes sense, LGTM!

[Anastasia]

Committed to the release branch in https://github.com/llvm/llvm-project/commit/00441b8f4e5b7daa39ac6cbeb45ebfe54662b08d

clang/docs/ReleaseNotes.rst

 Objective-C Language Changes in Clang
 -------------------------------------
 
-OpenCL C Language Changes in Clang
-----------------------------------
-
-...
+OpenCL Kernel Language Changes in Clang
+---------------------------------------
+
+- Improved online documentation: :doc:`UsersManual` and :doc:`OpenCLSupport` pages.
+- Added ``-cl-std=CL3.0`` and predefined version macro for OpenCL 3.0.
+- Added ``-cl-std=CL1.0`` and mapped to the existing OpenCL 1.0 functionality.
+- Improved OpenCL extension handling per target.
+- Added clang extension for function pointers ``__cl_clang_function_pointers``
+  and variadic functions ``__cl_clang_variadic_functions``, more details can be
+  found in :doc:`LanguageExtensions`.
+- Improved diagnostics for nested pointers and  unevaluated ``vec_step``
+  expression.
+- Added ``global_device`` and ``global_host`` address spaces for USM
+  allocations.
+
+Miscellaneous improvements in C++ for OpenCL support:
+
+- Added diagnostics for pointers to member functions and references to
+  functions.
+- Added support of ``vec_step`` builtin.
+- Fixed ICE on address spaces with forwarding references and templated copy
+  constructors.
+- Removed warning for variadic macro use.
 
 ABI Changes in Clang
 --------------------