Page MenuHomePhabricator

[mlir] Squash LLVM_ArmNeon dialect into ArmNeon
ClosedPublic

Authored by ftynse on Mar 5 2021, 10:32 AM.

Details

Summary

The two dialects are largely redundant. The former was introduced as a mirror
of the latter operating on LLVM dialect types. This is no longer necessary
since the LLVM dialect operates on built-in types. Combine the two dialects.

Diff Detail

Event Timeline

ftynse created this revision.Mar 5 2021, 10:32 AM
ftynse requested review of this revision.Mar 5 2021, 10:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2021, 10:32 AM
mehdi_amini accepted this revision.Mar 5 2021, 1:11 PM

Nice cleanup! Thanks :)

This revision is now accepted and ready to land.Mar 5 2021, 1:11 PM
This revision was landed with ongoing or failed builds.Mar 5 2021, 2:33 PM
This revision was automatically updated to reflect the committed changes.

Cool! And just in time for some work I am doing! Thanks.

mlir/include/mlir/Target/LLVMIR/Dialect/ArmNeon/ArmNeonToLLVMIRTranslation.h
21

nit: here and below, this should now really be just ARM Neon

ftynse marked an inline comment as done.Mar 10 2021, 4:36 AM