This is an archive of the discontinued LLVM Phabricator instance.

Differential D98019

[libcxx] Move Linaro 32 bit armv bots to buildkite
ClosedPublic

Authored by DavidSpickett on Mar 5 2021, 1:45 AM.

Details

Reviewers
curdeius
Mordante
Group Reviewers
Restricted Project
Commits
rG44e36fc2b1df: [libcxx] Move Linaro 32 bit armv bots to buildkite
Summary

Instead of setting mcpu like the previous bots,
set the target triple.

Each config builds either Arm only or Thumb only
code. This gives us some coverage of thumb specific
issues.

The new agents on Linaro's side are running on v8 hardware
so will report arch "armv8l" just like the v8 bots.
(and buildkite can choose any of them for v7/v8 jobs)

Diff Detail

Event Timeline

DavidSpickett created this revision.Mar 5 2021, 1:45 AM
Herald added subscribers: kristof.beyls, arichardson, mgorny. · View Herald TranscriptMar 5 2021, 1:45 AM
DavidSpickett requested review of this revision.Mar 5 2021, 1:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2021, 1:45 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
DavidSpickett updated this revision to Diff 328442.Mar 5 2021, 1:49 AM

Forgot to update the YAML config too.

DavidSpickett updated this revision to Diff 328481.Mar 5 2021, 5:27 AM

Also move v7 bots in this change.

Uploading with the other agents removed to quickly
check response time is ok.

DavidSpickett edited the summary of this revision. (Show Details)Mar 5 2021, 5:27 AM
DavidSpickett added a comment.Mar 5 2021, 5:32 AM

Ideally we'd build and test on v7 but this is fine for now and we can remove buildbot. I can always move agents around later.

Harbormaster completed remote builds in B92259: Diff 328441.Mar 5 2021, 6:01 AM
Harbormaster completed remote builds in B92260: Diff 328442.Mar 5 2021, 6:47 AM
Harbormaster completed remote builds in B92287: Diff 328481.Mar 5 2021, 7:18 AM
DavidSpickett updated this revision to Diff 328537.Mar 5 2021, 8:24 AM

Use gnueabihf so we get the correct includes.

DavidSpickett retitled this revision from [libcxx] Move Linaro 32 bit armv8 bots to buildkite to [libcxx] Move Linaro 32 bit armv bots to buildkite.Mar 5 2021, 8:25 AM
Harbormaster completed remote builds in B92329: Diff 328537.Mar 5 2021, 1:12 PM
curdeius accepted this revision as: curdeius.Mar 8 2021, 12:37 AM
curdeius added a subscriber: curdeius.

LGTM. That's very cool to have this in the precommit CI.
Maybe now that it seems to be working OK, you may uncomment other configs, rebase on main and rerun CI (just in case)?

DavidSpickett updated this revision to Diff 328946.Mar 8 2021, 1:25 AM

Final YAML for review.

DavidSpickett updated this revision to Diff 328947.Mar 8 2021, 1:26 AM

Remove stray newline from run-buildbot.

DavidSpickett mentioned this in D92863: [libc++] Remove libc++ ARM builders.Mar 8 2021, 1:31 AM
Harbormaster completed remote builds in B92612: Diff 328946.Mar 8 2021, 2:51 AM
Harbormaster completed remote builds in B92613: Diff 328947.Mar 8 2021, 3:35 AM
curdeius added a comment.Mar 8 2021, 4:35 AM

Still LGTM of course. Please wait for libc++ group approval.

Mordante accepted this revision.Mar 11 2021, 10:35 AM
Mordante added a subscriber: Mordante.

Thanks a lot for adding these pre-commit builders!
LGTM!

This revision is now accepted and ready to land.Mar 11 2021, 10:35 AM
Closed by commit rG44e36fc2b1df: [libcxx] Move Linaro 32 bit armv bots to buildkite (authored by DavidSpickett). · Explain WhyMar 12 2021, 1:47 AM
This revision was automatically updated to reflect the committed changes.
DavidSpickett added a commit: rG44e36fc2b1df: [libcxx] Move Linaro 32 bit armv bots to buildkite.
ldionne added a subscriber: ldionne.Mar 16 2021, 10:56 AM
ldionne added inline comments.
libcxx/utils/ci/run-buildbot
406

Why do we need to set these flags here? Ideally, everything would be handled by the CMake cache. Same below.

DavidSpickett marked an inline comment as done.Mar 17 2021, 4:23 AM
DavidSpickett added inline comments.
libcxx/utils/ci/run-buildbot
406

We don't, for some reason I was trying to balance number of cache files and options here.

Move the flags into cache files: https://reviews.llvm.org/D98771

DavidSpickett mentioned this in D98771: [libcxx][Arm] Move buildbot flags into cmake files.Mar 17 2021, 4:24 AM

Revision Contents

PathSize
libcxx/
cmake/
caches/
2 lines
2 lines
utils/
ci/
48 lines
34 lines

Diff 330179

libcxx/cmake/caches/Armv7.cmake

  • This file was added.
set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "")
set(LIBCXX_TARGET_TRIPLE "armv7-linux-gnueabihf" CACHE STRING "")

libcxx/cmake/caches/Armv8.cmake

  • This file was added.
set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "")
set(LIBCXX_TARGET_TRIPLE "armv8-linux-gnueabihf" CACHE STRING "")

libcxx/utils/ci/buildkite-pipeline.yml

Show First 20 Lines • Show All 349 Lines • ▼ Show 20 Lines artifact_paths:
- "**/test-results.xml" - "**/test-results.xml"
agents: agents:
queue: "libcxx-builders-linaro-arm" queue: "libcxx-builders-linaro-arm"
arch: "aarch64" arch: "aarch64"
retry: retry:
automatic: automatic:
- exit_status: -1 # Agent was lost - exit_status: -1 # Agent was lost
limit: 2 limit: 2
- label: "Armv8"
command: "libcxx/utils/ci/run-buildbot armv8"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders-linaro-arm"
arch: "armv8l"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
- label: "Armv8 -fno-exceptions"
command: "libcxx/utils/ci/run-buildbot armv8-noexceptions"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders-linaro-arm"
arch: "armv8l"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
- label: "Armv7"
command: "libcxx/utils/ci/run-buildbot armv7"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders-linaro-arm"
arch: "armv8l" # Compiling for v7, running on v8 hardware
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
- label: "Armv7 -fno-exceptions"
command: "libcxx/utils/ci/run-buildbot armv7-noexceptions"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders-linaro-arm"
arch: "armv8l" # Compiling for v7, running on v8 hardware
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2

libcxx/utils/ci/run-buildbot

Show First 20 Lines • Show All 393 Lines • ▼ Show 20 Lines
;; ;;
aarch64-noexceptions) aarch64-noexceptions)
clean clean
generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/AArch64.cmake" \ generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/AArch64.cmake" \
-DLIBCXX_ENABLE_EXCEPTIONS=OFF \ -DLIBCXX_ENABLE_EXCEPTIONS=OFF \
-DLIBCXXABI_ENABLE_EXCEPTIONS=OFF -DLIBCXXABI_ENABLE_EXCEPTIONS=OFF
check-cxx-cxxabi check-cxx-cxxabi
;; ;;
# Aka Armv8 32 bit
armv8)
clean
generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv8.cmake" \
-DCMAKE_CXX_FLAGS="-marm" \
ldionneUnsubmitted
Not Done
ReplyInline Actions

Why do we need to set these flags here? Ideally, everything would be handled by the CMake cache. Same below.

ldionne: Why do we need to set these flags here? Ideally, everything would be handled by the CMake cache.
DavidSpickettAuthorUnsubmitted
Done
ReplyInline Actions

We don't, for some reason I was trying to balance number of cache files and options here.

Move the flags into cache files: https://reviews.llvm.org/D98771

DavidSpickett: We don't, for some reason I was trying to balance number of cache files and options here. Move…
-DCMAKE_C_FLAGS="-marm"
check-cxx-cxxabi
;;
armv8-noexceptions)
clean
generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv8.cmake" \
-DCMAKE_CXX_FLAGS="-mthumb" \
-DCMAKE_C_FLAGS="-mthumb" \
-DLIBCXX_ENABLE_EXCEPTIONS=OFF \
-DLIBCXXABI_ENABLE_EXCEPTIONS=OFF
check-cxx-cxxabi
;;
# Armv7 32 bit. One building Arm only one Thumb only code.
armv7)
clean
generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv7.cmake" \
-DCMAKE_CXX_FLAGS="-marm" \
-DCMAKE_C_FLAGS="-marm"
check-cxx-cxxabi
;;
armv7-noexceptions)
clean
generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Armv7.cmake" \
-DCMAKE_CXX_FLAGS="-mthumb" \
-DCMAKE_C_FLAGS="-mthumb" \
-DLIBCXX_ENABLE_EXCEPTIONS=OFF \
-DLIBCXXABI_ENABLE_EXCEPTIONS=OFF
check-cxx-cxxabi
;;
*) *)
echo "${BUILDER} is not a known configuration" echo "${BUILDER} is not a known configuration"
exit 1 exit 1
;; ;;
esac esac