Page MenuHomePhabricator

[flang][fir] Add diagnostic tests for FIR ops verifier
ClosedPublic

Authored by clementval on Mar 4 2021, 5:48 PM.

Details

Summary

Add diagnostic tests with fir-opt for the diagnostics emitted by the ops verifier

Diff Detail

Event Timeline

clementval requested review of this revision.Mar 4 2021, 5:48 PM
clementval created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2021, 5:48 PM

LGTM, thanks!

flang/lib/Optimizer/Dialect/FIROps.cpp
556

Nit: you can merge now: if (op.getShape() && !isArray)

(same below)

clementval updated this revision to Diff 328355.Mar 4 2021, 6:43 PM

Address review comment

clementval marked an inline comment as done.Mar 4 2021, 6:44 PM
clementval added inline comments.
flang/lib/Optimizer/Dialect/FIROps.cpp
556

Good catch! Thanks.

jeanPerier accepted this revision.Mar 4 2021, 10:21 PM

Thanks !

This revision is now accepted and ready to land.Mar 4 2021, 10:21 PM
This revision was landed with ongoing or failed builds.Mar 5 2021, 7:21 AM
This revision was automatically updated to reflect the committed changes.
clementval marked an inline comment as done.