[mlir] Remove incorrect folding for SubTensorInsertOp

[mravishankar]

Summary

The SubTensorInsertOp has a requirement that dest type and result
type match. Just folding the tensor.cast operation violates this and
creates verification errors during canonicalization. Also fix other
canonicalization methods that werent inserting casts properly.

[mravishankar]

Add test.

[mravishankar]

Correcting previous incorrect update

[hanchung]

mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp

2390–2392 ↗

(On Diff #327591)

[optional] I feel llvm::zip(op->getResults(), newOp->getResults()) looks better to me.

mlir/test/Dialect/Linalg/canonicalize.mlir

782 ↗

(On Diff #327591)

Should this be dim %arg0, %c1?

792 ↗

(On Diff #327591)

Let's add a new line at the end of file?

[mravishankar]

Address comments

[nicolasvasilache]

mlir/test/Dialect/Linalg/canonicalize.mlir

782 ↗

(On Diff #327591)

+1

mlir/test/lib/Transforms/TestLinalgFusionTransforms.cpp

static LogicalResult fuseLinalgOpsGreedily(FuncOp f) {
   for (auto *e : eraseSet)
     e->erase();
 
   return changed ? success() : failure();
 }
 
 namespace {
 struct TestLinalgGreedyFusion
-    : public PassWrapper<TestLinalgGreedyFusion, FunctionPass> {
-  void runOnFunction() override {
+    : public PassWrapper<TestLinalgGreedyFusion, OperationPass<ModuleOp>> {
+  void runOnOperation() override {
     MLIRContext *context = &getContext();
     OwningRewritePatternList patterns =
         linalg::getLinalgTilingCanonicalizationPatterns(context);
     patterns.insert<AffineMinSCFCanonicalizationPattern>(context);
     FrozenRewritePatternList frozenPatterns(std::move(patterns));
-    while (succeeded(fuseLinalgOpsGreedily(getFunction()))) {
-      (void)applyPatternsAndFoldGreedily(getFunction(), frozenPatterns);
+    bool repeat = true;
+    while (repeat) {
+      repeat = false;
+      for (FuncOp funcOp : getOperation().getOps<FuncOp>()) {
+        if (succeeded(fuseLinalgOpsGreedily(funcOp))) {
+          repeat = true;
+          (void)applyPatternsAndFoldGreedily(funcOp, frozenPatterns);
+        }
+      }
       PassManager pm(context);
       pm.addPass(createLoopInvariantCodeMotionPass());
       pm.addPass(createCanonicalizerPass());
       pm.addPass(createCSEPass());
-      LogicalResult res = pm.run(getFunction()->getParentOfType<ModuleOp>());
+      LogicalResult res = pm.run(getOperation());
       if (failed(res))
         this->signalPassFailure();
     }
   }
 };
 
 /// Pass to test tile and fuse of sequence of operations. Intended only for
 /// testing.