This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Make categorical features 64 bit in DecisionForest Model.
ClosedPublic

Authored by usaxena95 on Mar 2 2021, 7:08 AM.

Details

Summary

CodeCompletionContext::Kind has 36 Kinds. The completion model used to
support categorical features of 32 cardinality.
Due to this clangd tests were failing asan tests due to overflow.

This patch makes the completion model support 64 cardinality of
categorical features by storing ENUM Features as uint64_t instead of
uint32_t.

Verified that this fixes the asan failures.

Latency: 6.7ms (old) VS 6.8ms (new) per 1000 predictions.

Diff Detail

Event Timeline

usaxena95 created this revision.Mar 2 2021, 7:08 AM
usaxena95 requested review of this revision.Mar 2 2021, 7:08 AM
sammccall accepted this revision.Mar 2 2021, 7:19 AM
This revision is now accepted and ready to land.Mar 2 2021, 7:19 AM
This revision was landed with ongoing or failed builds.Mar 2 2021, 7:27 AM
This revision was automatically updated to reflect the committed changes.