This is an archive of the discontinued LLVM Phabricator instance.

[X86] Zero AMX config buffer for non AVX512 cases.
ClosedPublic

Authored by pengfei on Feb 17 2021, 7:40 PM.

Details

Summary

Zero AMX config buffer for non AVX512 cases.

Diff Detail

Event Timeline

pengfei created this revision.Feb 17 2021, 7:40 PM
pengfei requested review of this revision.Feb 17 2021, 7:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2021, 7:40 PM
LuoYuanke added inline comments.Feb 17 2021, 7:53 PM
llvm/lib/Target/X86/X86PreTileConfig.cpp
106

Can we remove the FIXME now?

126

SSE2 is by default enabled?

pengfei updated this revision to Diff 324517.Feb 17 2021, 9:18 PM
pengfei marked an inline comment as done.

Address Yuanke's comments.

llvm/lib/Target/X86/X86PreTileConfig.cpp
126

SSE2 is enabled on X64 by default, though it can be disabled. I added an assertion for it.

LuoYuanke accepted this revision.Feb 17 2021, 9:24 PM

LGTM. Thanks.

This revision is now accepted and ready to land.Feb 17 2021, 9:24 PM
This revision was landed with ongoing or failed builds.Feb 17 2021, 9:39 PM
This revision was automatically updated to reflect the committed changes.