Page MenuHomePhabricator

[Coroutine] Relax CoroElide musttail check
ClosedPublic

Authored by lxfind on Feb 17 2021, 7:13 PM.

Details

Summary

As discussed in D94834, we don't really need to do complicated analysis. It's safe to just drop the tail call attribute.

Diff Detail

Event Timeline

lxfind created this revision.Feb 17 2021, 7:13 PM
lxfind requested review of this revision.Feb 17 2021, 7:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2021, 7:13 PM

This patch looks good to me.

This patch looks good to me.

Thanks. Can you accept?

lxfind updated this revision to Diff 324691.Feb 18 2021, 10:07 AM

Not remove the attribute for musttail

ChuanqiXu accepted this revision.Feb 18 2021, 5:43 PM

This patch looks good to me.

Thanks. Can you accept?

Sorry. I forgot this.

This revision is now accepted and ready to land.Feb 18 2021, 5:43 PM
This revision was landed with ongoing or failed builds.Feb 18 2021, 7:36 PM
This revision was automatically updated to reflect the committed changes.