- User Since
- Mar 11 2019, 11:18 PM (80 w, 2 d)
Please remove unnecessary headers include and declarations
Tue, Sep 22
Mon, Sep 21
Update the doc. @efriedma is this ok?
sorry for the late reply.
Fri, Sep 18
Thu, Sep 17
LGTM, Thanks for the fix.
We try to find an general solution to handle some conservative & mismatch analysis in transformations caused by the change of cfg with coro.suspend intrinsic. However afaik, it seems quiet difficult to deal this without change framework fo coroutine.
This patch just fixes the known issue, it may happens in other passes, FYI.
Tue, Sep 15
what does this intrinsic use for?
@lxfind , could you backport this to branch 11?
Mon, Sep 14
Thu, Sep 10
Thanks for the change. LGTM, and testcase？
Aug 24 2020
Aug 23 2020
Aug 19 2020
Aug 18 2020
Aug 17 2020
Aug 5 2020
LGTM，Thank you, Please merge the testcases into one file.
Aug 3 2020
Aug 2 2020
Jul 23 2020
LGTM, Thank you!
Jul 9 2020
Jul 8 2020
Jul 5 2020
Jul 3 2020
Jul 1 2020
@lxfind This patch causes some mismatch when variable is used in both resume and destroy function. Besides, we should move this patch and the check in buildCoroutineFrame.
Jun 28 2020
LGTM， Thank you！
This generally looks good to me. I'll accept this if others do not have different ideas about this. Thanks!
Jun 24 2020
@lxfind, Thank you! And could you please add some testcases?
Jun 23 2020
Jun 22 2020
Rather than doing it here, can we build await_resume call expression with MaterializedTemporaryExpr when expand the coawait expression. That's how gcc does.
Jun 16 2020
Jun 15 2020
@aaron.ballman thanks for the review. I have updated the patch.
address the comments.
Jun 14 2020
Jun 11 2020
Jun 10 2020
since we still need discuss about the invoke of getValueInBlock, I'll split this patch into two parts.
Jun 7 2020
Jun 4 2020
address the comment.
Jun 3 2020
address the comment.
hi @erichkeane, most of the function in vector-1.cpp are copied from ext-vector.c with vector type changed to gcc vector type, they should emit same ir. I add test7 and test8 which test logic operation of gcc vector type.
This patch implement the logic not operation of vector type. it keeps same behavior as gcc does (only allows in C++). I'll update the wrong testcases
Jun 1 2020
May 24 2020
May 21 2020
May 17 2020
May 14 2020
May 12 2020
hi @lebedev.ri , sorry for the late response.
I have checked the reduction tree build in SLPVectorizer, for now it only support same operation. It seems we can revert the transformation when match reduction operation in matchAssociativeReduction. However, I don't think it is a good idea.
Also the extra phase-ordering test shows that this patch has minimal impact. Except the first case which is vectorized by SLP, the other cases keep the same IR as before.
update the testcase.
Apr 29 2020
Thanks, now i know what you mean.
Why shouldn't SLPVectorizer be taught about that pattern instead?
I think we can handle this in SLP, however it may much hard than doing here? I'm not sure.
It would be best to enhance SLP rather than adding potentially-numerous semi-arbitrarily bailout elsewhere, i think.
make sense, will check this later.
For now vector-combine is executed before slp in both legacy pm and new pm with O2, so either we handle it here or slp can handle this kind of pattern.
Apr 6 2020
Apr 2 2020
Mar 29 2020
I'm not sure whether I can approve this. If not, @modocache please ignore this.
Mar 28 2020
Mar 27 2020