Page MenuHomePhabricator

junparser (JunMa)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 11 2019, 11:18 PM (119 w, 3 d)

Recent Activity

Yesterday

junparser updated the diff for D104852: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant..

update clang test.

Thu, Jun 24, 8:57 PM · Restricted Project, Restricted Project
junparser updated the diff for D104852: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant..

clang-format.

Thu, Jun 24, 5:47 AM · Restricted Project, Restricted Project
junparser requested review of D104852: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant..
Thu, Jun 24, 5:39 AM · Restricted Project, Restricted Project

May 20 2021

junparser added inline comments to D102498: [AArch64][SVE] Improve codegen for fixed length vector concat.
May 20 2021, 7:01 PM · Restricted Project

May 19 2021

junparser added inline comments to D102498: [AArch64][SVE] Improve codegen for fixed length vector concat.
May 19 2021, 5:50 PM · Restricted Project

May 17 2021

junparser added inline comments to D102498: [AArch64][SVE] Improve codegen for fixed length vector concat.
May 17 2021, 7:49 PM · Restricted Project
junparser added inline comments to D102498: [AArch64][SVE] Improve codegen for fixed length vector concat.
May 17 2021, 12:20 AM · Restricted Project

May 9 2021

junparser committed rGb3aeb1389245: [AArch64][SVE] Remove index_vector node. (authored by junparser).
[AArch64][SVE] Remove index_vector node.
May 9 2021, 8:30 PM
junparser closed D101593: [AArch64][SVE] Remove index_vector node..
May 9 2021, 8:30 PM · Restricted Project

Apr 30 2021

junparser added inline comments to D101593: [AArch64][SVE] Remove index_vector node..
Apr 30 2021, 5:17 AM · Restricted Project
junparser updated the diff for D101593: [AArch64][SVE] Remove index_vector node..

rebased.

Apr 30 2021, 4:14 AM · Restricted Project
junparser committed rGb310dd15017f: [AArch64][SVE] Lower index_vector to step_vector (authored by junparser).
[AArch64][SVE] Lower index_vector to step_vector
Apr 30 2021, 4:14 AM
junparser closed D100816: [AArch64][SVE] Lower index_vector to step_vector.
Apr 30 2021, 4:14 AM · Restricted Project
junparser added a comment to D100816: [AArch64][SVE] Lower index_vector to step_vector.

@paulwalker-arm, Thanks for the review, I added D101593 which removes index_vector, FYI.

Apr 30 2021, 3:56 AM · Restricted Project

Apr 29 2021

junparser requested review of D101593: [AArch64][SVE] Remove index_vector node..
Apr 29 2021, 7:32 PM · Restricted Project
junparser updated the diff for D100816: [AArch64][SVE] Lower index_vector to step_vector.

Address comment.

Apr 29 2021, 6:38 PM · Restricted Project
junparser added inline comments to D100816: [AArch64][SVE] Lower index_vector to step_vector.
Apr 29 2021, 6:38 PM · Restricted Project
junparser added inline comments to D100816: [AArch64][SVE] Lower index_vector to step_vector.
Apr 29 2021, 6:11 PM · Restricted Project

Apr 28 2021

junparser updated the diff for D100816: [AArch64][SVE] Lower index_vector to step_vector.

Address comments.

Apr 28 2021, 2:27 AM · Restricted Project

Apr 27 2021

junparser updated the diff for D100816: [AArch64][SVE] Lower index_vector to step_vector.

Remove assertion.

Apr 27 2021, 5:33 PM · Restricted Project
junparser added inline comments to D100816: [AArch64][SVE] Lower index_vector to step_vector.
Apr 27 2021, 5:20 PM · Restricted Project

Apr 26 2021

junparser added a comment to D100816: [AArch64][SVE] Lower index_vector to step_vector.

Kindly ping.

Apr 26 2021, 7:18 PM · Restricted Project

Apr 22 2021

junparser updated the diff for D100816: [AArch64][SVE] Lower index_vector to step_vector.

rebased.

Apr 22 2021, 6:20 AM · Restricted Project
junparser added a comment to D100856: [RISCV] Support STEP_VECTOR with a step greater than one.

D100812 has checked in. FYI

Apr 22 2021, 6:03 AM · Restricted Project
junparser committed rG978eb3f168be: [DAGCombiner] Allow operand of step_vector to be negative. (authored by junparser).
[DAGCombiner] Allow operand of step_vector to be negative.
Apr 22 2021, 5:58 AM
junparser closed D100812: [DAGCombiner] Allow operand of step_vector to be negative..
Apr 22 2021, 5:58 AM · Restricted Project
junparser updated the diff for D100812: [DAGCombiner] Allow operand of step_vector to be negative..

Address comments.

Apr 22 2021, 4:47 AM · Restricted Project
junparser added a comment to D100816: [AArch64][SVE] Lower index_vector to step_vector.

@paulwalker-arm @sdesmalen kindly ping~

Apr 22 2021, 3:04 AM · Restricted Project

Apr 21 2021

junparser updated the diff for D100812: [DAGCombiner] Allow operand of step_vector to be negative..

rebased.
@craig.topper, Now rv32 get some code as rv64, thanks!

Apr 21 2021, 11:19 PM · Restricted Project
junparser added inline comments to D100812: [DAGCombiner] Allow operand of step_vector to be negative..
Apr 21 2021, 8:02 PM · Restricted Project
junparser added inline comments to D100812: [DAGCombiner] Allow operand of step_vector to be negative..
Apr 21 2021, 7:27 AM · Restricted Project
junparser updated the diff for D100812: [DAGCombiner] Allow operand of step_vector to be negative..

Address comments.

Apr 21 2021, 7:25 AM · Restricted Project
junparser added inline comments to D100812: [DAGCombiner] Allow operand of step_vector to be negative..
Apr 21 2021, 5:57 AM · Restricted Project
junparser added inline comments to D100812: [DAGCombiner] Allow operand of step_vector to be negative..
Apr 21 2021, 4:31 AM · Restricted Project
junparser added inline comments to D100812: [DAGCombiner] Allow operand of step_vector to be negative..
Apr 21 2021, 3:47 AM · Restricted Project
junparser updated the diff for D100812: [DAGCombiner] Allow operand of step_vector to be negative..

Fix regression in riscv32.

Apr 21 2021, 2:17 AM · Restricted Project

Apr 20 2021

junparser added inline comments to D100812: [DAGCombiner] Allow operand of step_vector to be negative..
Apr 20 2021, 9:23 PM · Restricted Project
junparser added a comment to D100812: [DAGCombiner] Allow operand of step_vector to be negative..

Hmm I just saw that D100088 went in without anyone involved with RISC-V being on the reviewer list or notified. I think that's technically a regression since the RISC-V backend crashes on all those test cases that were added.

Apr 20 2021, 8:38 PM · Restricted Project
junparser added a comment to D100812: [DAGCombiner] Allow operand of step_vector to be negative..

I also have nothing against the change in principle, but in addition to @paulwalker-arm's comments, RISC-V won't support this: it expects IMM to be 1, as it always was before this. We shouldn't introduce something that regresses this target, so the lowering of STEP_VECTOR will need to be extended to legalize/lower the operation.

Apr 20 2021, 8:32 PM · Restricted Project
junparser updated the diff for D100812: [DAGCombiner] Allow operand of step_vector to be negative..

Address comments.

Apr 20 2021, 5:37 AM · Restricted Project
junparser added a reviewer for D100812: [DAGCombiner] Allow operand of step_vector to be negative.: frasercrmck.
Apr 20 2021, 4:59 AM · Restricted Project
junparser added a comment to D100812: [DAGCombiner] Allow operand of step_vector to be negative..

I've nothing against the change but it is more involved than updating the comment and assert. There are places where STEP_VECTOR's operand is treated as unsigned, based on the original requirement, that will need to be updated. For example DAGTypeLegalizer::PromoteIntRes_STEP_VECTOR. Ideally we'd want to add/update tests to show the signedness is properly protected during type legalisation.

Apr 20 2021, 2:20 AM · Restricted Project
junparser added inline comments to D100745: [AArch64] Add AArch64TTIImpl::getMaskedMemoryOpCost function.
Apr 20 2021, 1:48 AM · Restricted Project
junparser committed rG1ef5699d1a86: [DAGCombiner] Support fold zero scalar vector. (authored by junparser).
[DAGCombiner] Support fold zero scalar vector.
Apr 20 2021, 1:29 AM
junparser closed D100813: [DAGCombiner] Support fold zero scalar vector..
Apr 20 2021, 1:29 AM · Restricted Project
junparser updated the diff for D100812: [DAGCombiner] Allow operand of step_vector to be negative..

rebase.

Apr 20 2021, 1:25 AM · Restricted Project

Apr 19 2021

junparser requested review of D100816: [AArch64][SVE] Lower index_vector to step_vector.
Apr 19 2021, 10:39 PM · Restricted Project
junparser updated the summary of D100813: [DAGCombiner] Support fold zero scalar vector..
Apr 19 2021, 9:10 PM · Restricted Project
junparser updated the summary of D100812: [DAGCombiner] Allow operand of step_vector to be negative..
Apr 19 2021, 9:09 PM · Restricted Project
junparser requested review of D100813: [DAGCombiner] Support fold zero scalar vector..
Apr 19 2021, 9:09 PM · Restricted Project
junparser updated the summary of D100812: [DAGCombiner] Allow operand of step_vector to be negative..
Apr 19 2021, 9:05 PM · Restricted Project
junparser requested review of D100812: [DAGCombiner] Allow operand of step_vector to be negative..
Apr 19 2021, 9:05 PM · Restricted Project
junparser committed rG5c6ac3b4a25e: [AArch64][SVE] Combine add and index_vector (authored by junparser).
[AArch64][SVE] Combine add and index_vector
Apr 19 2021, 8:39 PM
junparser closed D100107: [AArch64][SVE] Combine add and index_vector.
Apr 19 2021, 8:39 PM · Restricted Project

Apr 18 2021

junparser added a comment to D100107: [AArch64][SVE] Combine add and index_vector.

@sdesmalen kindly ping~

Apr 18 2021, 6:44 PM · Restricted Project

Apr 15 2021

junparser updated the diff for D100107: [AArch64][SVE] Combine add and index_vector.

Update testcase.

Apr 15 2021, 4:30 AM · Restricted Project
junparser updated the diff for D100107: [AArch64][SVE] Combine add and index_vector.

Address comments.

Apr 15 2021, 4:07 AM · Restricted Project
junparser committed rG7e1422c1e430: [DAGCombiner] Fold step_vector with add/mul/shl (authored by junparser).
[DAGCombiner] Fold step_vector with add/mul/shl
Apr 15 2021, 3:07 AM
junparser closed D100088: [DAGCombiner] Fold step_vector with add/mul/shl.
Apr 15 2021, 3:07 AM · Restricted Project

Apr 14 2021

junparser updated the diff for D100107: [AArch64][SVE] Combine add and index_vector.

Address comments. using tablegen pattern match.

Apr 14 2021, 10:17 PM · Restricted Project
junparser added inline comments to D100107: [AArch64][SVE] Combine add and index_vector.
Apr 14 2021, 5:39 AM · Restricted Project
junparser updated the diff for D100107: [AArch64][SVE] Combine add and index_vector.

Address comment.

Apr 14 2021, 2:30 AM · Restricted Project

Apr 13 2021

junparser added a comment to D100088: [DAGCombiner] Fold step_vector with add/mul/shl.

@david-arm kindly ping~

Apr 13 2021, 11:07 PM · Restricted Project
junparser added a comment to D100107: [AArch64][SVE] Combine add and index_vector.

What I want know something more is what is the boundary between tablegen pattern match and dag combine? I never figure this out. Just use this case as example, we can implement the feature in both place, but I don't know how to handle commutivity in tablegen (maybe SDNPCommutative? I don't know.) , and their effects on the next step: combine load/store with index_vector.

There isn't a firm rule to follow re tablegen pattern vs manual dag combine, but I think the steer is that when the combine is needed after legalization and it's possible to specify as a pattern, a pattern is preferred. In this case, probably a pattern would be a clean way to implement it. I haven't used SDNPCommutative before, but that looks like it should do the trick.

Apr 13 2021, 8:23 PM · Restricted Project

Apr 11 2021

junparser updated the diff for D100088: [DAGCombiner] Fold step_vector with add/mul/shl.

Address comments.

Apr 11 2021, 8:10 PM · Restricted Project
junparser added a comment to D100107: [AArch64][SVE] Combine add and index_vector.

What I want know something more is what is the boundary between tablegen pattern match and dag combine? I never figure this out. Just use this case as example, we can implement the feature in both place, but I don't know how to handle commutivity in tablegen (maybe SDNPCommutative? I don't know.) , and their effects on the next step: combine load/store with index_vector.

Apr 11 2021, 8:08 PM · Restricted Project
junparser added inline comments to D100088: [DAGCombiner] Fold step_vector with add/mul/shl.
Apr 11 2021, 7:34 PM · Restricted Project

Apr 8 2021

junparser retitled D100107: [AArch64][SVE] Combine add and index_vector from [AArch64][SVE] Optimize index_vector with add to [AArch64][SVE] Combine add and index_vector.
Apr 8 2021, 7:22 AM · Restricted Project
junparser updated the diff for D100107: [AArch64][SVE] Combine add and index_vector.
Apr 8 2021, 7:21 AM · Restricted Project
junparser added reviewers for D100107: [AArch64][SVE] Combine add and index_vector: david-arm, sdesmalen, paulwalker-arm, dmgreen, joechrisellis.
Apr 8 2021, 7:17 AM · Restricted Project
junparser updated the diff for D100107: [AArch64][SVE] Combine add and index_vector.

fix typo.

Apr 8 2021, 7:15 AM · Restricted Project
junparser requested review of D100107: [AArch64][SVE] Combine add and index_vector.
Apr 8 2021, 7:13 AM · Restricted Project

Apr 7 2021

junparser requested review of D100088: [DAGCombiner] Fold step_vector with add/mul/shl.
Apr 7 2021, 10:33 PM · Restricted Project

Apr 6 2021

junparser accepted D99856: [Coroutines, test] Fix use of var defined in CHECK-NOT.

LGTM

Apr 6 2021, 7:52 PM · Restricted Project

Apr 2 2021

junparser committed rG2dfa2c0ea02d: [NFC][SVE] update sve-intrinsics-int-arith.ll under update_llc_test_checks.py (authored by junparser).
[NFC][SVE] update sve-intrinsics-int-arith.ll under update_llc_test_checks.py
Apr 2 2021, 5:18 AM
junparser committed rG274ac9d40e79: [AArch64][SVE] Lowering sve.dot to DOT node (authored by junparser).
[AArch64][SVE] Lowering sve.dot to DOT node
Apr 2 2021, 5:18 AM
junparser committed rGab3c5fb28259: [NFC][SVE] Use SVE_4_Op_Imm_Pat for sve_intx_dot_by_indexed_elem (authored by junparser).
[NFC][SVE] Use SVE_4_Op_Imm_Pat for sve_intx_dot_by_indexed_elem
Apr 2 2021, 5:17 AM
junparser closed D99699: [AArch64][SVE] Lowering sve.dot to DOT node.
Apr 2 2021, 5:17 AM · Restricted Project

Apr 1 2021

junparser updated the diff for D99699: [AArch64][SVE] Lowering sve.dot to DOT node.

address comments.

Apr 1 2021, 5:30 AM · Restricted Project
junparser updated the diff for D99699: [AArch64][SVE] Lowering sve.dot to DOT node.

address comments.

Apr 1 2021, 4:51 AM · Restricted Project
junparser added inline comments to D99699: [AArch64][SVE] Lowering sve.dot to DOT node.
Apr 1 2021, 4:24 AM · Restricted Project
junparser updated the diff for D99699: [AArch64][SVE] Lowering sve.dot to DOT node.

address the comments.

Apr 1 2021, 3:28 AM · Restricted Project
junparser added a reviewer for D99699: [AArch64][SVE] Lowering sve.dot to DOT node: dmgreen.
Apr 1 2021, 3:18 AM · Restricted Project
junparser added inline comments to D99699: [AArch64][SVE] Lowering sve.dot to DOT node.
Apr 1 2021, 3:18 AM · Restricted Project

Mar 31 2021

junparser updated the diff for D99699: [AArch64][SVE] Lowering sve.dot to DOT node.

address pre-check comments.

Mar 31 2021, 11:28 PM · Restricted Project
junparser requested review of D99699: [AArch64][SVE] Lowering sve.dot to DOT node.
Mar 31 2021, 9:13 PM · Restricted Project

Mar 29 2021

junparser committed rG1af373c67369: [AArch64][SVE] Codegen dup_lane for dup(vector_extract) (authored by junparser).
[AArch64][SVE] Codegen dup_lane for dup(vector_extract)
Mar 29 2021, 7:36 PM
junparser committed rG65462a08bfb9: [NFC][SVE] Remove redundant pattern (authored by junparser).
[NFC][SVE] Remove redundant pattern
Mar 29 2021, 7:36 PM
junparser committed rGb0db2dbc291f: [AArch64][SVEIntrinsicOpts] Optimize tbl+dup into dup+extractelement (authored by junparser).
[AArch64][SVEIntrinsicOpts] Optimize tbl+dup into dup+extractelement
Mar 29 2021, 7:36 PM
junparser closed D99324: [AArch64][SVE] Codegen dup_lane for dup(vector_extract).
Mar 29 2021, 7:35 PM · Restricted Project
junparser closed D99412: [AArch64][SVEIntrinsicOpts] Optimize tbl+dup into dup+extractelement.
Mar 29 2021, 7:35 PM · Restricted Project
junparser updated the summary of D99324: [AArch64][SVE] Codegen dup_lane for dup(vector_extract).
Mar 29 2021, 6:51 PM · Restricted Project
junparser added inline comments to D99324: [AArch64][SVE] Codegen dup_lane for dup(vector_extract).
Mar 29 2021, 5:33 AM · Restricted Project
junparser updated the diff for D99324: [AArch64][SVE] Codegen dup_lane for dup(vector_extract).

Address comments.

Mar 29 2021, 5:21 AM · Restricted Project
junparser added inline comments to D99412: [AArch64][SVEIntrinsicOpts] Optimize tbl+dup into dup+extractelement.
Mar 29 2021, 4:57 AM · Restricted Project
junparser updated the diff for D99412: [AArch64][SVEIntrinsicOpts] Optimize tbl+dup into dup+extractelement.
Mar 29 2021, 4:56 AM · Restricted Project
junparser added inline comments to D99324: [AArch64][SVE] Codegen dup_lane for dup(vector_extract).
Mar 29 2021, 4:55 AM · Restricted Project
junparser added a comment to D99412: [AArch64][SVEIntrinsicOpts] Optimize tbl+dup into dup+extractelement.

Hi, thank you for the patch! The optimisation seems sound to me -- just a few comments on the test side. 😄

Mar 29 2021, 2:12 AM · Restricted Project
junparser updated the diff for D99412: [AArch64][SVEIntrinsicOpts] Optimize tbl+dup into dup+extractelement.

Address comments

Mar 29 2021, 2:12 AM · Restricted Project

Mar 28 2021

junparser retitled D99324: [AArch64][SVE] Codegen dup_lane for dup(vector_extract) from [AArch64][SVE] Simplify codegen of svdup_lane intrinsic to [AArch64][SVE] Codegen dup_lane for dup(vector_extract).
Mar 28 2021, 11:21 PM · Restricted Project