This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Change catch_all's opcode
ClosedPublic

Authored by aheejin on Feb 17 2021, 5:29 AM.

Details

Summary

We decided to change catch_all's opcode from 0x05, which is the same
as else, to 0x19, to avoid some complicated handling in the tools.

See: https://github.com/WebAssembly/exception-handling/issues/147

Diff Detail

Event Timeline

aheejin created this revision.Feb 17 2021, 5:29 AM
aheejin requested review of this revision.Feb 17 2021, 5:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2021, 5:29 AM
aheejin edited the summary of this revision. (Show Details)Feb 17 2021, 5:47 AM
sbc100 accepted this revision.Feb 17 2021, 7:24 AM

Is there no test that includes this encoding?

This revision is now accepted and ready to land.Feb 17 2021, 7:24 AM

We don't have any specific file to test encoding for EH in test/MC/WebAssembly. To be more precisely, we only have that for SIMD and not for all other instructions. Do you want me to add one?

No thats fine. I was just making sure we wouldn't break an existing test..

This revision was automatically updated to reflect the committed changes.