This is an archive of the discontinued LLVM Phabricator instance.

[LLVM][GVN] fix a typo in comment
ClosedPublic

Authored by ksyx on Feb 17 2021, 12:50 AM.

Details

Diff Detail

Event Timeline

ksyx created this revision.Feb 17 2021, 12:50 AM
ksyx requested review of this revision.Feb 17 2021, 12:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2021, 12:50 AM
ksyx added a comment.Feb 21 2021, 6:41 PM

Politely ping. This is a simple fix of typo in comment.

fhahn accepted this revision.Feb 22 2021, 1:39 PM
fhahn added a subscriber: fhahn.

LGTM, thanks! (usually you should try to add suitable reviewers to your patch, otherwise the chances that someone spots it are greatly decreased)

This revision is now accepted and ready to land.Feb 22 2021, 1:39 PM
ksyx closed this revision.Feb 22 2021, 6:53 PM
xgupta added a subscriber: xgupta.Jul 1 2021, 9:32 PM

Instead of committing, you closed the revision @ksyx, typo is still present :)

ksyx added a comment.Jul 1 2021, 10:35 PM

The commit was actually made but with some mistake in commit msg, sorry for that. Commit here: https://reviews.llvm.org/rG4125cabce1374209843393d1e9474efea58cbeaf

xgupta added a comment.EditedJul 1 2021, 10:56 PM

No need to say sorry, actually if you search the same keyword in GVN.cpp in main branch, you can still find it. see: https://github.com/llvm/llvm-project/blob/main/llvm/lib/Transforms/Scalar/GVN.cpp#L1926

I guess some magic did happen here by Phabricator.

BTW, you could check it in directly if this patch only contains comment changes or new tests. And it may be better to add NFC keyword to the title.