User Details
- User Since
- Feb 12 2021, 4:38 PM (146 w, 21 h)
Sep 26 2022
Thanks for the information. This part of code was removed in https://github.com/llvm/llvm-project/commit/1f88d804083a8a1b68df1e6677920e38ab2a6b40#diff-d5b2ea0042a8c02ed8ab1a2ec072423c9fdb5d72f2be64777bc99faa9b8ca032 and it looks clean now.
Jul 18 2022
Update zmmul version & rebase
Jul 17 2022
Rebase and update use of M extension existence check to include Zmmul whenever needed.
Jul 4 2022
ping :)
Jun 26 2022
Make Zmmul extension independent instead of implied by M extension for backward ELF attribute compatibility.
Jun 25 2022
The Zmmul extension has just ratified. Update patch to rebase to current main.
Jun 11 2022
Jun 6 2022
Ok then I would only do that.
Thanks for the review and it sounds a good rationale. I am also wondering whether only changing errs to dbgs on the original code without changing other parts or using helper function a good change for consistency with other code?
Jun 4 2022
Apply suggestions from clangfmt
May 6 2022
Thanks!
Apr 13 2022
Mar 5 2022
Fix patch apply failed
Rebase and adapt to new ISAInfo module.
Mar 4 2022
Feb 13 2022
Feb 7 2022
Feb 6 2022
Use for loop to go through tokens in a line.
- Remove else after return
- Add or remove empty lines surrounding unions.
- Move new test location.
- Remove else immediately above return.
Feb 5 2022
Feb 3 2022
Feb 2 2022
Related discussion: https://reviews.llvm.org/D92257#3252060
Jan 24 2022
Jan 22 2022
Jan 21 2022
Apply review suggestions of renaming.
Add token type FunctionLikeOrFreestandingMacro and use it to replace duplicated check with UnwrappedLineParser
Jan 20 2022
Add unit test for formatting conflict
Jan 19 2022
Apply suggestion from clangfmt
- Apply suggestions from clangfmt
- Split assertion conditions
Recognize long (len>=5) uppercased name taking a single line as return type
and fix the problem of adding newline below it:
void afunc(int x) { return; } TYPENAME func(int x, int y) { // ... }
Jan 18 2022
- Resolves formatting conflict with options EmptyLineAfterAccessModifier and EmptyLineBeforeAccessModifier (prompts with --dry-run (-n) or --output-replacement-xml but no observable change)
- Remove redundant and repeated initialization
- Do no change to newlines before EOF
- Use function keyword for JavaScript instead of comparing strings
- Apply review suggestions
Jan 17 2022
Apply clangfmt's suggestion.
Jan 11 2022
Jan 10 2022
- add comments for direction = 0
- use true/false instead of 0/1
- rebase
Hi, just to confirm, are there anything needed to be improved for this patch or it is ready to be committed? Thanks
Jan 7 2022
I see your point, but I think the problem is more likely to be coming from the token annotator that detected it as a macro and just start a new line?
Seems like this is intent for dealing with macro but somehow went into return type
---- AnnotatedTokens(L=0): M=0 C=0 T=Unknown S=1 F=0 B=0 BK=0 P=0 Name=identifier L=4 PPK=2 FakeLParens= FakeRParens=0 II=0x1592cb8 Text='LRES' M=1 C=1 T=FunctionDeclarationName S=1 F=0 B=0 BK=0 P=80 Name=identifier L=84 PPK=2 FakeLParens= FakeRParens=0 II=0x1592cf0 Text='barbabararr' M=0 C=0 T=Unknown S=0 F=0 B=0 BK=0 P=23 Name=l_paren L=85 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text='(' M=0 C=0 T=Unknown S=0 F=0 B=0 BK=0 P=140 Name=r_paren L=86 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text=')' ----
rebase
- Use prefix inc/dec
- Not run test in lambda
Jan 6 2022
apply suggestion from clangfmt.
apply suggestion from clangfmt.
Apply suggested behaviour and fix misrecognition of token namespace
Jan 5 2022
Apply most suggestions
apply clangfmt suggestions.
Fix failing when the first line of body is comment.
failed on dealing with classes.
Jan 3 2022
Thanks for the fix!
Thanks for the fix :)
Jan 2 2022
Add release note entry.
Jan 1 2022
Dec 31 2021
Change the SDS_Leave style check to be assert not having this style.
Use reformat method instead of calling the single method only.
Change lambda variable names' leading letter to uppercase.
Change lambda variable names' leading letter to uppercase.
Dec 30 2021
- Apply review suggestions.
- Assert the style is not SDS_Leave in private method, while return no change in public method if so.
- Rename loop variable Line to CurrentLine
minor fixes.
Dec 29 2021
Apply suggestion from clangfmt
Apply clangfmt's suggestions
- Improve compatibility to other languages
- Improve unit test by test format stability, inverse result, and generate some input from expected output
- Reformat sample code
- Use more concise word for SDS_Leave
Dec 28 2021
Fix typo.
- Apply suggestions from clangfmt
- Add missing period of comments
- Fix namespace ending comment
- Add comment for notes on return value of WhitespaceManager's method