Page MenuHomePhabricator

ksyx
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 12 2021, 4:38 PM (72 w, 5 d)

Recent Activity

Mon, Jul 4

ksyx added a comment to D103313: [RISCV][Clang] Add support for Zmmul extension.

ping :)

Mon, Jul 4, 10:06 AM · Restricted Project, Restricted Project, Restricted Project

Sun, Jun 26

ksyx updated the diff for D103313: [RISCV][Clang] Add support for Zmmul extension.

Make Zmmul extension independent instead of implied by M extension for backward ELF attribute compatibility.

Sun, Jun 26, 10:07 AM · Restricted Project, Restricted Project, Restricted Project

Sat, Jun 25

ksyx updated the diff for D103313: [RISCV][Clang] Add support for Zmmul extension.

The Zmmul extension has just ratified. Update patch to rebase to current main.

Sat, Jun 25, 6:49 PM · Restricted Project, Restricted Project, Restricted Project

Sat, Jun 11

ksyx committed rG45b278f195b2: [Clang][Doc][SafeStack] Fix deadlink (NFC) (authored by ksyx).
[Clang][Doc][SafeStack] Fix deadlink (NFC)
Sat, Jun 11, 8:02 AM · Restricted Project, Restricted Project

Jun 6 2022

ksyx committed rG3204272f0f1a: [ARM] Use llvm::dbgs() to print debug info (NFC) (authored by ksyx).
[ARM] Use llvm::dbgs() to print debug info (NFC)
Jun 6 2022, 1:47 PM · Restricted Project, Restricted Project
ksyx abandoned D127055: [ARM] Merge duplicated Thumb2SizeReduce code (NFC).

Ok then I would only do that.

Jun 6 2022, 12:11 PM · Restricted Project, Restricted Project
ksyx added a comment to D127055: [ARM] Merge duplicated Thumb2SizeReduce code (NFC).

Thanks for the review and it sounds a good rationale. I am also wondering whether only changing errs to dbgs on the original code without changing other parts or using helper function a good change for consistency with other code?

Jun 6 2022, 11:46 AM · Restricted Project, Restricted Project

Jun 4 2022

ksyx updated the diff for D127055: [ARM] Merge duplicated Thumb2SizeReduce code (NFC).

Apply suggestions from clangfmt

Jun 4 2022, 2:35 PM · Restricted Project, Restricted Project
ksyx requested review of D127055: [ARM] Merge duplicated Thumb2SizeReduce code (NFC).
Jun 4 2022, 1:14 PM · Restricted Project, Restricted Project

May 6 2022

ksyx accepted D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline..

Thanks!

May 6 2022, 2:30 PM · Restricted Project, Restricted Project

Apr 13 2022

ksyx added inline comments to D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline..
Apr 13 2022, 7:54 AM · Restricted Project, Restricted Project
ksyx added inline comments to D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline..
Apr 13 2022, 6:42 AM · Restricted Project, Restricted Project

Mar 5 2022

ksyx updated the diff for D103313: [RISCV][Clang] Add support for Zmmul extension.

Fix patch apply failed

Mar 5 2022, 6:40 AM · Restricted Project, Restricted Project, Restricted Project
ksyx updated the diff for D103313: [RISCV][Clang] Add support for Zmmul extension.

Rebase and adapt to new ISAInfo module.

Mar 5 2022, 6:33 AM · Restricted Project, Restricted Project, Restricted Project

Mar 4 2022

ksyx added a comment to D118869: [clang-format] Non-latin comment prefix whitespace.

It appears that this caused a regression by adding an additional space of indentation to line comments in some cases:

% cat test.cc  # (before)
// Comment
int i;
% clang-format -style=google test.cc
//  Comment
int i;

@ksyx could you please take a look?

Mar 4 2022, 4:47 AM · Restricted Project, Restricted Project, Restricted Project
ksyx added a comment to D103313: [RISCV][Clang] Add support for Zmmul extension.

Hi, do you still continue working on this patch?

Mar 4 2022, 3:56 AM · Restricted Project, Restricted Project, Restricted Project

Feb 13 2022

ksyx added inline comments to D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.
Feb 13 2022, 7:38 PM · Restricted Project
ksyx added inline comments to D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.
Feb 13 2022, 7:27 PM · Restricted Project

Feb 7 2022

ksyx committed rGa70549ae43df: [clang-format] Fix DefSeparator empty line issues (authored by ksyx).
[clang-format] Fix DefSeparator empty line issues
Feb 7 2022, 6:23 AM
ksyx closed D119067: [clang-format] Fix DefinitionBlockSeparator extra empty lines.
Feb 7 2022, 6:23 AM · Restricted Project, Restricted Project
ksyx added inline comments to D119067: [clang-format] Fix DefinitionBlockSeparator extra empty lines.
Feb 7 2022, 6:10 AM · Restricted Project, Restricted Project

Feb 6 2022

ksyx updated the diff for D119067: [clang-format] Fix DefinitionBlockSeparator extra empty lines.

Use for loop to go through tokens in a line.

Feb 6 2022, 5:59 PM · Restricted Project, Restricted Project
ksyx updated the diff for D119067: [clang-format] Fix DefinitionBlockSeparator extra empty lines.
  • Remove else after return
Feb 6 2022, 12:19 PM · Restricted Project, Restricted Project
ksyx updated the diff for D119067: [clang-format] Fix DefinitionBlockSeparator extra empty lines.
  • Add or remove empty lines surrounding unions.
  • Move new test location.
  • Remove else immediately above return.
Feb 6 2022, 6:49 AM · Restricted Project, Restricted Project

Feb 5 2022

ksyx requested review of D119067: [clang-format] Fix DefinitionBlockSeparator extra empty lines.
Feb 5 2022, 6:29 PM · Restricted Project, Restricted Project

Feb 3 2022

ksyx committed rG88e4e6be16ea: [clang-format] Use wider comment prefix space rule (authored by ksyx).
[clang-format] Use wider comment prefix space rule
Feb 3 2022, 1:49 PM
ksyx closed D118869: [clang-format] Non-latin comment prefix whitespace.
Feb 3 2022, 1:49 PM · Restricted Project, Restricted Project, Restricted Project

Feb 2 2022

ksyx updated subscribers of D118869: [clang-format] Non-latin comment prefix whitespace.

Related discussion: https://reviews.llvm.org/D92257#3252060

Feb 2 2022, 7:37 PM · Restricted Project, Restricted Project, Restricted Project
ksyx requested review of D118869: [clang-format] Non-latin comment prefix whitespace.
Feb 2 2022, 7:35 PM · Restricted Project, Restricted Project, Restricted Project

Jan 24 2022

ksyx committed rG5e5efd8a91f2: [clang-format] Fix SeparateDefinitionBlocks issues (authored by ksyx).
[clang-format] Fix SeparateDefinitionBlocks issues
Jan 24 2022, 6:24 AM
ksyx closed D117520: [clang-format] Fix SeparateDefinitionBlocks issues.
Jan 24 2022, 6:24 AM · Restricted Project

Jan 22 2022

ksyx added a comment to D117520: [clang-format] Fix SeparateDefinitionBlocks issues.

maybe slightly related https://github.com/llvm/llvm-project/issues/53183 in that this is also impacted by the 5 character TT_FunctionLikeOrFreestandingMacro

Jan 22 2022, 11:16 AM · Restricted Project

Jan 21 2022

ksyx added inline comments to D117520: [clang-format] Fix SeparateDefinitionBlocks issues.
Jan 21 2022, 12:49 PM · Restricted Project
ksyx updated the diff for D117520: [clang-format] Fix SeparateDefinitionBlocks issues.

Apply review suggestions of renaming.

Jan 21 2022, 12:49 PM · Restricted Project
ksyx added inline comments to D117520: [clang-format] Fix SeparateDefinitionBlocks issues.
Jan 21 2022, 12:38 PM · Restricted Project
ksyx updated the diff for D117520: [clang-format] Fix SeparateDefinitionBlocks issues.

Add token type FunctionLikeOrFreestandingMacro and use it to replace duplicated check with UnwrappedLineParser

Jan 21 2022, 8:54 AM · Restricted Project
ksyx added a comment to D117520: [clang-format] Fix SeparateDefinitionBlocks issues.

I think its been fixed, in the last but one diff.

Generally speaking we simply cannot have --output-replacements-xml , -n or --dry-run show replacements that amount to nothing because this is the mechanism by which 100s of repos fail commits thinking their is a clang-format issue.

Last revision I tried these issues seem to have disappeared

I understood that it was fixed but I'd really like to have a test case that reproduces it.
We might have the same problem somewhere else, no?
Can we have a part of verifyFormat that runs with DryRun=true and checks the replacements?

Jan 21 2022, 4:45 AM · Restricted Project

Jan 20 2022

ksyx updated the diff for D117520: [clang-format] Fix SeparateDefinitionBlocks issues.

Add unit test for formatting conflict

Jan 20 2022, 9:01 AM · Restricted Project

Jan 19 2022

ksyx updated the diff for D117520: [clang-format] Fix SeparateDefinitionBlocks issues.

Apply suggestion from clangfmt

Jan 19 2022, 5:39 PM · Restricted Project
ksyx updated the diff for D117520: [clang-format] Fix SeparateDefinitionBlocks issues.
  • Apply suggestions from clangfmt
  • Split assertion conditions
Jan 19 2022, 4:46 PM · Restricted Project
ksyx added inline comments to D117520: [clang-format] Fix SeparateDefinitionBlocks issues.
Jan 19 2022, 12:12 PM · Restricted Project
ksyx updated the diff for D117520: [clang-format] Fix SeparateDefinitionBlocks issues.

Recognize long (len>=5) uppercased name taking a single line as return type
and fix the problem of adding newline below it:

void
afunc(int x) {
  return;
}
TYPENAME
func(int x, int y) {
  // ...
}
Jan 19 2022, 9:52 AM · Restricted Project

Jan 18 2022

ksyx updated the diff for D117520: [clang-format] Fix SeparateDefinitionBlocks issues.
  • Resolves formatting conflict with options EmptyLineAfterAccessModifier and EmptyLineBeforeAccessModifier (prompts with --dry-run (-n) or --output-replacement-xml but no observable change)
  • Remove redundant and repeated initialization
  • Do no change to newlines before EOF
Jan 18 2022, 5:39 PM · Restricted Project
ksyx added inline comments to D117520: [clang-format] Fix SeparateDefinitionBlocks issues.
Jan 18 2022, 12:37 PM · Restricted Project
ksyx added a comment to D117520: [clang-format] Fix SeparateDefinitionBlocks issues.

For

class Test
{
public:
    static void foo()
    {
    }
};

$ clang-format -n test.cxx
test.cxx:3:8: warning: code should be clang-formatted [-Wclang-format-violations
]
public:
       ^
$ clang-format --output-replacements-xml test.cxx
<?xml version='1.0'?>
<replacements xml:space='preserve' incomplete_format='false'>
<replacement offset='20' length='5'>&#10;    </replacement>
</replacements>

but when I run it nothing changes

$ clang-format test.cxx
class Test
{
public:
    static void foo()
    {
    }
};

And no character change

Jan 18 2022, 8:59 AM · Restricted Project
ksyx added a comment to D117520: [clang-format] Fix SeparateDefinitionBlocks issues.

I'm getting some sort of seemingly empty replacements going on, after public: I can't quite put my finger on what's happening.

Jan 18 2022, 8:42 AM · Restricted Project
ksyx updated the diff for D117520: [clang-format] Fix SeparateDefinitionBlocks issues.
  • Use function keyword for JavaScript instead of comparing strings
  • Apply review suggestions
Jan 18 2022, 6:11 AM · Restricted Project

Jan 17 2022

ksyx updated the diff for D117520: [clang-format] Fix SeparateDefinitionBlocks issues.

Apply clangfmt's suggestion.

Jan 17 2022, 4:22 PM · Restricted Project
ksyx requested review of D117520: [clang-format] Fix SeparateDefinitionBlocks issues.
Jan 17 2022, 4:05 PM · Restricted Project
ksyx added a comment to D92257: [clang-format] Add option to control the space at the front of a line comment.

Hi guys,i found SpacesInLineCommentPrefix does not support other encoding such as utf8 ,
I am curious why there is a isAlphanumeric limit in BreakableLineCommentSection::BreakableLineCommentSection() ?
I want to make some contribution to make it support utf8, what should i do ?

The isAlphanumeric is there to not break doxygen like comments for example.

I'm very interested in how you want to tackle that problem. :)

Jan 17 2022, 3:17 PM · Restricted Project, Restricted Project

Jan 11 2022

ksyx committed rGee25a327aac0: [clang-format] Fix SeparateDefinitionBlocks issues (authored by ksyx).
[clang-format] Fix SeparateDefinitionBlocks issues
Jan 11 2022, 9:26 AM
ksyx closed D116663: [clang-format] Fix SeparateDefinitionBlocks issues.
Jan 11 2022, 9:25 AM · Restricted Project

Jan 10 2022

ksyx updated the diff for D116663: [clang-format] Fix SeparateDefinitionBlocks issues.
  • add comments for direction = 0
  • use true/false instead of 0/1
  • rebase
Jan 10 2022, 12:30 PM · Restricted Project
ksyx added a comment to D116663: [clang-format] Fix SeparateDefinitionBlocks issues.

Hi, just to confirm, are there anything needed to be improved for this patch or it is ready to be committed? Thanks

Jan 10 2022, 8:10 AM · Restricted Project

Jan 7 2022

ksyx added a comment to D116663: [clang-format] Fix SeparateDefinitionBlocks issues.

I see your point, but I think the problem is more likely to be coming from the token annotator that detected it as a macro and just start a new line?

Jan 7 2022, 11:22 AM · Restricted Project
ksyx added a comment to D116663: [clang-format] Fix SeparateDefinitionBlocks issues.

I think that perhaps

if (Style.SeparateDefinitionBlocks != FormatStyle::SDS_Leave)
  Passes.emplace_back([&](const Environment &Env) {
    return DefinitionBlockSeparator(Env, Expanded).process();
  });

Should be moved to After the Formatter pass, thoughts?

Jan 7 2022, 9:40 AM · Restricted Project
ksyx added a comment to D116663: [clang-format] Fix SeparateDefinitionBlocks issues.

Seems like this is intent for dealing with macro but somehow went into return type

Jan 7 2022, 8:50 AM · Restricted Project
ksyx added a comment to D116663: [clang-format] Fix SeparateDefinitionBlocks issues.

Seem related to the number of characters used in the type?

void foo()
{}

LRES
Foo::func() {}

LRESU

Foo::func() {}
----
AnnotatedTokens(L=0):
 M=0 C=0 T=Unknown S=1 F=0 B=0 BK=0 P=0 Name=identifier L=4 PPK=2 FakeLParens= FakeRParens=0 II=0x1592cb8 Text='LRES'
 M=1 C=1 T=FunctionDeclarationName S=1 F=0 B=0 BK=0 P=80 Name=identifier L=84 PPK=2 FakeLParens= FakeRParens=0 II=0x1592cf0 Text='barbabararr'
 M=0 C=0 T=Unknown S=0 F=0 B=0 BK=0 P=23 Name=l_paren L=85 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text='('
 M=0 C=0 T=Unknown S=0 F=0 B=0 BK=0 P=140 Name=r_paren L=86 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text=')'
----
Jan 7 2022, 8:43 AM · Restricted Project
ksyx updated the diff for D116663: [clang-format] Fix SeparateDefinitionBlocks issues.

rebase

Jan 7 2022, 8:27 AM · Restricted Project
ksyx added a comment to D116663: [clang-format] Fix SeparateDefinitionBlocks issues.
HRESULT
Foo::func()
{
}

becomes

HRESULT

Foo::func() {}
Jan 7 2022, 8:25 AM · Restricted Project
ksyx updated the diff for D116663: [clang-format] Fix SeparateDefinitionBlocks issues.
  • Use prefix inc/dec
  • Not run test in lambda
Jan 7 2022, 8:24 AM · Restricted Project
ksyx added a comment to D116663: [clang-format] Fix SeparateDefinitionBlocks issues.

This shows some other failure scenarios

https://github.com/llvm/llvm-project/issues/45895

Jan 7 2022, 4:07 AM · Restricted Project

Jan 6 2022

ksyx updated the diff for D116663: [clang-format] Fix SeparateDefinitionBlocks issues.

apply suggestion from clangfmt.

Jan 6 2022, 2:15 PM · Restricted Project
ksyx updated the diff for D116663: [clang-format] Fix SeparateDefinitionBlocks issues.

apply suggestion from clangfmt.

Jan 6 2022, 2:12 PM · Restricted Project
ksyx updated the summary of D116663: [clang-format] Fix SeparateDefinitionBlocks issues.
Jan 6 2022, 1:36 PM · Restricted Project
ksyx updated the diff for D116663: [clang-format] Fix SeparateDefinitionBlocks issues.

Apply suggested behaviour and fix misrecognition of token namespace

Jan 6 2022, 1:35 PM · Restricted Project

Jan 5 2022

ksyx added a comment to D116663: [clang-format] Fix SeparateDefinitionBlocks issues.
namespace {
<--- extraneous newline will be removed (just checking if thats what we want?)  shouldn't it honour MaxEmptyLines?  
   /*  foo */
   void foo()
   {
   }
<--- extraneous newline will be removed (just checking if thats what we want?)  shouldn't it honour MaxEmptyLines?
}
Jan 5 2022, 2:31 PM · Restricted Project
ksyx updated the diff for D116663: [clang-format] Fix SeparateDefinitionBlocks issues.

Apply most suggestions

Jan 5 2022, 2:29 PM · Restricted Project
ksyx updated the diff for D116663: [clang-format] Fix SeparateDefinitionBlocks issues.

apply clangfmt suggestions.

Jan 5 2022, 8:47 AM · Restricted Project
ksyx updated the diff for D116663: [clang-format] Fix SeparateDefinitionBlocks issues.

Fix failing when the first line of body is comment.

Jan 5 2022, 8:37 AM · Restricted Project
ksyx planned changes to D116663: [clang-format] Fix SeparateDefinitionBlocks issues.

failed on dealing with classes.

Jan 5 2022, 7:39 AM · Restricted Project
ksyx added a comment to D116314: [clang-format] Add style to separate definition blocks.

@ksyx

Did you see this issue https://github.com/llvm/llvm-project/issues/52976

In its current form, this patch causes huge amounts of flux in projects
that document code like (anyone using doxygen likely, + most normal people
;-) )

...
}

// My function
<<<<-------- extra newline added
void
foo()
{
}

as it will place and undesirable additional newline between the function
and the return type.

We really need this to be resolved before we branch out v14 (which may be
imminent)

MyDeveloperDay

Jan 5 2022, 7:31 AM · Restricted Project, Restricted Project
ksyx requested review of D116663: [clang-format] Fix SeparateDefinitionBlocks issues.
Jan 5 2022, 7:29 AM · Restricted Project

Jan 3 2022

ksyx accepted D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ....

Thanks for the fix!

Jan 3 2022, 3:11 PM · Restricted Project, Restricted Project
ksyx added a comment to D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ....

Thanks for the fix :)

Jan 3 2022, 2:23 PM · Restricted Project, Restricted Project
ksyx committed rG6f6f88ffdae1: [clang-format] Style to separate definition blocks (authored by ksyx).
[clang-format] Style to separate definition blocks
Jan 3 2022, 12:50 PM
ksyx closed D116314: [clang-format] Add style to separate definition blocks.
Jan 3 2022, 12:50 PM · Restricted Project, Restricted Project

Jan 2 2022

ksyx updated the diff for D116314: [clang-format] Add style to separate definition blocks.

Add release note entry.

Jan 2 2022, 6:24 AM · Restricted Project, Restricted Project

Jan 1 2022

ksyx added inline comments to D116314: [clang-format] Add style to separate definition blocks.
Jan 1 2022, 5:49 AM · Restricted Project, Restricted Project

Dec 31 2021

ksyx updated the diff for D116314: [clang-format] Add style to separate definition blocks.

Change the SDS_Leave style check to be assert not having this style.

Dec 31 2021, 4:01 PM · Restricted Project, Restricted Project
ksyx added inline comments to D116314: [clang-format] Add style to separate definition blocks.
Dec 31 2021, 2:22 PM · Restricted Project, Restricted Project
ksyx updated the diff for D116314: [clang-format] Add style to separate definition blocks.

Use reformat method instead of calling the single method only.

Dec 31 2021, 2:21 PM · Restricted Project, Restricted Project
ksyx added inline comments to D116314: [clang-format] Add style to separate definition blocks.
Dec 31 2021, 5:44 AM · Restricted Project, Restricted Project
ksyx updated the diff for D116314: [clang-format] Add style to separate definition blocks.

Change lambda variable names' leading letter to uppercase.

Dec 31 2021, 5:43 AM · Restricted Project, Restricted Project
ksyx updated the diff for D116314: [clang-format] Add style to separate definition blocks.

Change lambda variable names' leading letter to uppercase.

Dec 31 2021, 5:41 AM · Restricted Project, Restricted Project

Dec 30 2021

ksyx added inline comments to D116351: Update Bug report URL to Github Issues.
Dec 30 2021, 6:20 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
ksyx added inline comments to D116314: [clang-format] Add style to separate definition blocks.
Dec 30 2021, 4:04 PM · Restricted Project, Restricted Project
ksyx updated the diff for D116314: [clang-format] Add style to separate definition blocks.
  • Apply review suggestions.
  • Assert the style is not SDS_Leave in private method, while return no change in public method if so.
  • Rename loop variable Line to CurrentLine
Dec 30 2021, 4:04 PM · Restricted Project, Restricted Project
ksyx updated the diff for D116314: [clang-format] Add style to separate definition blocks.

minor fixes.

Dec 30 2021, 12:53 PM · Restricted Project, Restricted Project

Dec 29 2021

ksyx updated the diff for D116314: [clang-format] Add style to separate definition blocks.

Apply suggestion from clangfmt

Dec 29 2021, 4:21 PM · Restricted Project, Restricted Project
ksyx updated the diff for D116314: [clang-format] Add style to separate definition blocks.

Apply clangfmt's suggestions

Dec 29 2021, 3:52 PM · Restricted Project, Restricted Project
ksyx updated the diff for D116314: [clang-format] Add style to separate definition blocks.
  • Improve compatibility to other languages
  • Improve unit test by test format stability, inverse result, and generate some input from expected output
  • Reformat sample code
  • Use more concise word for SDS_Leave
Dec 29 2021, 3:23 PM · Restricted Project, Restricted Project

Dec 28 2021

ksyx updated the diff for D116314: [clang-format] Add style to separate definition blocks.

Fix typo.

Dec 28 2021, 1:44 PM · Restricted Project, Restricted Project
ksyx updated the diff for D116314: [clang-format] Add style to separate definition blocks.
  • Apply suggestions from clangfmt
  • Add missing period of comments
  • Fix namespace ending comment
  • Add comment for notes on return value of WhitespaceManager's method
Dec 28 2021, 1:38 PM · Restricted Project, Restricted Project
ksyx added inline comments to D116314: [clang-format] Add style to separate definition blocks.
Dec 28 2021, 12:48 PM · Restricted Project, Restricted Project
ksyx updated the diff for D116314: [clang-format] Add style to separate definition blocks.
  • Change version from 15 to 14
  • Add option SDS_Never, rename SDS_Between => SDS_Always
  • Add unit tests
  • Separate class into new file
Dec 28 2021, 12:39 PM · Restricted Project, Restricted Project

Dec 27 2021

ksyx updated the diff for D116314: [clang-format] Add style to separate definition blocks.
  • Change bool type of the option to enum type
  • Generate empty line for enum block
Dec 27 2021, 6:32 PM · Restricted Project, Restricted Project
ksyx updated the summary of D116314: [clang-format] Add style to separate definition blocks.
Dec 27 2021, 2:06 PM · Restricted Project, Restricted Project
ksyx updated the diff for D116314: [clang-format] Add style to separate definition blocks.

Fix missing semicolon in sample/test code

Dec 27 2021, 2:05 PM · Restricted Project, Restricted Project
ksyx added inline comments to D116314: [clang-format] Add style to separate definition blocks.
Dec 27 2021, 11:29 AM · Restricted Project, Restricted Project