Details
Details
- Reviewers
llvm-commits fhahn
Diff Detail
Diff Detail
Event Timeline
Comment Actions
LGTM, thanks! (usually you should try to add suitable reviewers to your patch, otherwise the chances that someone spots it are greatly decreased)
Comment Actions
The commit was actually made but with some mistake in commit msg, sorry for that. Commit here: https://reviews.llvm.org/rG4125cabce1374209843393d1e9474efea58cbeaf
Comment Actions
No need to say sorry, actually if you search the same keyword in GVN.cpp in main branch, you can still find it. see: https://github.com/llvm/llvm-project/blob/main/llvm/lib/Transforms/Scalar/GVN.cpp#L1926
I guess some magic did happen here by Phabricator.
Comment Actions
BTW, you could check it in directly if this patch only contains comment changes or new tests. And it may be better to add NFC keyword to the title.