[mlgo] Fetch models from path / URL

[mtrofin]

Summary

Allow custom location for pre-trained models used when AOT-compiling
policies.

[phosek]

I'm not sure about the use case for the remote download feature (you can always just curl <URL> | tar xvz). If it's not needed, then I'd skip it for now, we can always introduce it later.

llvm/cmake/modules/TensorFlowCompile.cmake

17

Super minor nit: all the other functions are spelled as lower case.

[mtrofin]

feedback

llvm/cmake/modules/TensorFlowCompile.cmake

17

removed that.

[mtrofin]

In D96796#2567472, @phosek wrote:

I'm not sure about the use case for the remote download feature (you can always just curl <URL> | tar xvz). If it's not needed, then I'd skip it for now, we can always introduce it later.

ack - removed the URL stuff.

[mtrofin]

also removed the URL text from help message

llvm/cmake/modules/TensorFlowCompile.cmake

+# Ensure the ${model} is available at ${final_path}.
+#
+function(tfgetmodel model final_path)
+  if (IS_ABSOLUTE ${model})
+    set(${final_path} ${model} PARENT_SCOPE)
+  else()
+    set(${final_path}
+      ${CMAKE_CURRENT_SOURCE_DIR}/${model} PARENT_SCOPE)
+  endif()
+endfunction()
+
 # Run the tensorflow compiler (saved_model_cli) on the saved model in the 
 # ${model} directory, looking for the ${tag_set} tag set, and the SignatureDef
 # ${signature_def_key}.
 # Produce a pair of files called ${fname}.h and  ${fname}.o in the 
 # ${CMAKE_CURRENT_BINARY_DIR}. The generated header will define a C++ class
 # called ${cpp_class} - which may be a namespace-qualified class name.
 function(tfcompile model tag_set signature_def_key fname cpp_class)
-  if (IS_ABSOLUTE ${model})
-    set(LLVM_ML_MODELS_ABSOLUTE ${model})
-  else()
-    set(LLVM_ML_MODELS_ABSOLUTE
-      ${CMAKE_CURRENT_SOURCE_DIR}/${model})
-  endif()
-
+  tfgetmodel(${model} LLVM_ML_MODELS_ABSOLUTE)
+  message("Using model at " ${LLVM_ML_MODELS_ABSOLUTE})
   set(prefix ${CMAKE_CURRENT_BINARY_DIR}/${fname})
   set(obj_file ${prefix}.o)
   set(hdr_file ${prefix}.h)
   add_custom_command(OUTPUT ${obj_file} ${hdr_file}
     COMMAND "XLA_FLAGS=\"--xla_cpu_multi_thread_eigen=false\"" ${TENSORFLOW_AOT_COMPILER} aot_compile_cpu
           --dir ${LLVM_ML_MODELS_ABSOLUTE}
           --tag_set ${tag_set}
           --signature_def_key ${signature_def_key}

llvm/lib/Analysis/CMakeLists.txt

 if (DEFINED LLVM_HAVE_TF_AOT OR DEFINED LLVM_HAVE_TF_API)
   if (DEFINED LLVM_HAVE_TF_AOT)
+    set(LLVM_INLINER_MODEL_PATH "models/inliner" 
+      CACHE STRING 
+      "ML-driven inliner policy location - URL to archive; or path to saved model (relative to this directory, or absolute)")
     include(TensorFlowCompile)
-    tfcompile(models/inliner serve action InlinerSizeModel llvm::InlinerSizeModel)
+    tfcompile(${LLVM_INLINER_MODEL_PATH} serve action InlinerSizeModel llvm::InlinerSizeModel)
     list(APPEND GeneratedMLSources
       $<TARGET_OBJECTS:tf_xla_runtime_objects>
       ${GENERATED_OBJS}
     )
   endif()
 
   if (DEFINED LLVM_HAVE_TF_API)
     LIST(APPEND MLLinkDeps ${tensorflow_c_api})