This is an archive of the discontinued LLVM Phabricator instance.

[mlgo] Fetch models from path / URL
ClosedPublic

Authored by mtrofin on Feb 16 2021, 9:10 AM.

Details

Summary

Allow custom location for pre-trained models used when AOT-compiling
policies.

Diff Detail

Event Timeline

mtrofin created this revision.Feb 16 2021, 9:10 AM
mtrofin requested review of this revision.Feb 16 2021, 9:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 16 2021, 9:10 AM
phosek accepted this revision.Feb 16 2021, 10:23 PM

I'm not sure about the use case for the remote download feature (you can always just curl <URL> | tar xvz). If it's not needed, then I'd skip it for now, we can always introduce it later.

llvm/cmake/modules/TensorFlowCompile.cmake
17

Super minor nit: all the other functions are spelled as lower case.

This revision is now accepted and ready to land.Feb 16 2021, 10:23 PM
mtrofin edited the summary of this revision. (Show Details)Feb 16 2021, 10:30 PM
mtrofin updated this revision to Diff 324185.Feb 16 2021, 10:34 PM
mtrofin marked an inline comment as done.
mtrofin edited the summary of this revision. (Show Details)

feedback

llvm/cmake/modules/TensorFlowCompile.cmake
17

removed that.

I'm not sure about the use case for the remote download feature (you can always just curl <URL> | tar xvz). If it's not needed, then I'd skip it for now, we can always introduce it later.

ack - removed the URL stuff.

mtrofin updated this revision to Diff 324187.Feb 16 2021, 10:35 PM

also removed the URL text from help message

This revision was landed with ongoing or failed builds.Feb 16 2021, 10:47 PM
This revision was automatically updated to reflect the committed changes.