VSCode was not being informed whenever a location had been resolved (after being initated as non-resolved), so even though it was actually resolved, the IDE would show a hollow dot (instead of a red dot) because it didn't know about the change.
needs a test. Just make a test app with a shared library that gets dlopen'ed in the main function. At first the breakpoint in the shared library will be unresolved, then after stepping over the dlopen call, it should get resolved.
This new testcase broke buildbots as it is failing after a revert of D96637:
They are now failing on:
lldb-api :: tools/lldb-vscode/breakpoint-events/TestVSCode_breakpointLocationResolvedEvent.py
This testcase you newly checked-in after the patch being reverted.
commit b19d3b092d4ea019dfc52501bb96b0008d4e01d2 (HEAD) Author: António Afonso <email@example.com> Date: Sun Feb 21 10:38:25 2021 -0800 Revert "Make sure the interpreter module was loaded before making checks against it" This reverts commit a83a825e9902b54b315870e9ed85723525208f09. commit 1f21d488bd79a06c9cf405cc5db985fcd71c4f70 Author: António Afonso <firstname.lastname@example.org> Date: Fri Feb 19 09:43:38 2021 -0800 [lldb-vscode] Emit the breakpoint changed event on location resolved Differential Revision: https://reviews.llvm.org/D96680 commit a83a825e9902b54b315870e9ed85723525208f09 Author: António Afonso <email@example.com> Date: Thu Feb 18 20:31:55 2021 -0800 Make sure the interpreter module was loaded before making checks against it Differential Revision: https://reviews.llvm.org/D96637