Page MenuHomePhabricator

aadsm (António Afonso)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 27 2019, 10:34 PM (82 w, 5 d)

Recent Activity

Thu, Nov 19

aadsm added a comment to D87173: Ignores functions that have a range starting outside of a code section.

When I landed this I got test errors on the windows machine (the same tests pass on the other machine). I tried to repro this on 2 different machines I was able to get access but to no avail.
These are the failing tests: http://lab.llvm.org:8011/#/builders/83/builds/644 but when I ran lldb-test on the find-basic-function the output was what I would expect so not really sure how I can figure this out. Any ideas?

Thu, Nov 19, 10:39 AM · Restricted Project

Mon, Nov 9

aadsm added a reverting change for rG265a38fbc547: Check if debug line sequences are starting after the first code segment: rGd7be9a46475f: Revert "Check if debug line sequences are starting after the first code segment".
Mon, Nov 9, 11:48 AM
aadsm committed rGd7be9a46475f: Revert "Check if debug line sequences are starting after the first code segment" (authored by aadsm).
Revert "Check if debug line sequences are starting after the first code segment"
Mon, Nov 9, 11:48 AM
aadsm added a reverting change for D87172: Check if debug line sequences are starting after the first code segment: rGd7be9a46475f: Revert "Check if debug line sequences are starting after the first code segment".
Mon, Nov 9, 11:48 AM · Restricted Project
aadsm added a comment to D87172: Check if debug line sequences are starting after the first code segment.

reverting because I'm not able to repro the fails, so need more time to figure it out.

Mon, Nov 9, 11:46 AM · Restricted Project
aadsm added a reverting change for rGdf30bc0168d2: Ignores functions that have a range starting outside of a code section: rGa9dcd15f50dc: Revert "Ignores functions that have a range starting outside of a code section".
Mon, Nov 9, 9:08 AM
aadsm committed rGa9dcd15f50dc: Revert "Ignores functions that have a range starting outside of a code section" (authored by aadsm).
Revert "Ignores functions that have a range starting outside of a code section"
Mon, Nov 9, 9:08 AM
aadsm added a reverting change for D87173: Ignores functions that have a range starting outside of a code section: rGa9dcd15f50dc: Revert "Ignores functions that have a range starting outside of a code section".
Mon, Nov 9, 9:08 AM · Restricted Project
aadsm committed rGdf30bc0168d2: Ignores functions that have a range starting outside of a code section (authored by aadsm).
Ignores functions that have a range starting outside of a code section
Mon, Nov 9, 8:27 AM
aadsm committed rG265a38fbc547: Check if debug line sequences are starting after the first code segment (authored by aadsm).
Check if debug line sequences are starting after the first code segment
Mon, Nov 9, 8:27 AM
aadsm closed D87173: Ignores functions that have a range starting outside of a code section.
Mon, Nov 9, 8:26 AM · Restricted Project
aadsm closed D87172: Check if debug line sequences are starting after the first code segment.
Mon, Nov 9, 8:26 AM · Restricted Project

Sun, Nov 8

aadsm updated the diff for D87173: Ignores functions that have a range starting outside of a code section.

Merged the 2 run/checks into one

Sun, Nov 8, 6:32 PM · Restricted Project
aadsm committed rG32d239a75882: Fix debug_abbrev emitter to only assign table id once (authored by aadsm).
Fix debug_abbrev emitter to only assign table id once
Sun, Nov 8, 6:13 PM
aadsm closed D87179: Fix debug_abbrev emitter to only assign table id once.
Sun, Nov 8, 6:12 PM · Restricted Project

Sun, Nov 1

aadsm updated the diff for D70885: [lldb] Use explicit lldb commands on tests.

Use set and rebase

Sun, Nov 1, 3:54 PM · Restricted Project
aadsm updated the diff for D87868: [RFC] When calling the process mmap try to call all found instead of just the first one.

Also set the symbol as external when it is weak

Sun, Nov 1, 3:46 PM · Restricted Project
aadsm updated the diff for D87179: Fix debug_abbrev emitter to only assign table id once.

Address all comments (I hope)

Sun, Nov 1, 10:25 AM · Restricted Project
aadsm added inline comments to D87172: Check if debug line sequences are starting after the first code segment.
Sun, Nov 1, 8:46 AM · Restricted Project
aadsm updated the diff for D87173: Ignores functions that have a range starting outside of a code section.

Used -s to feed commands and disabled errors when interpreting them

Sun, Nov 1, 8:44 AM · Restricted Project

Wed, Oct 28

aadsm updated the diff for D87173: Ignores functions that have a range starting outside of a code section.

Rewrote the test in lit.

Wed, Oct 28, 6:55 PM · Restricted Project
aadsm updated the diff for D87172: Check if debug line sequences are starting after the first code segment.
  • Fixed formatting issues
  • Updated comment on the reason we need to do this
  • Improved the lit test by also checking how many matches it found
Wed, Oct 28, 2:59 PM · Restricted Project

Oct 22 2020

aadsm updated the diff for D87172: Check if debug line sequences are starting after the first code segment.

Check all child sections and makes sure the section is an actual code section.

Oct 22 2020, 6:20 PM · Restricted Project
aadsm added inline comments to D87172: Check if debug line sequences are starting after the first code segment.
Oct 22 2020, 6:10 PM · Restricted Project

Oct 19 2020

aadsm added inline comments to D87172: Check if debug line sequences are starting after the first code segment.
Oct 19 2020, 3:29 PM · Restricted Project

Oct 18 2020

aadsm added a comment to D87868: [RFC] When calling the process mmap try to call all found instead of just the first one.

Should I still go ahead with this since @labath implemented the memory allocation on lldb-server?

Oct 18 2020, 4:52 PM · Restricted Project
aadsm updated the diff for D87172: Check if debug line sequences are starting after the first code segment.

Addressed all comments:

Oct 18 2020, 4:47 PM · Restricted Project

Oct 6 2020

aadsm added inline comments to D87868: [RFC] When calling the process mmap try to call all found instead of just the first one.
Oct 6 2020, 8:49 AM · Restricted Project
aadsm added inline comments to D87868: [RFC] When calling the process mmap try to call all found instead of just the first one.
Oct 6 2020, 8:47 AM · Restricted Project

Oct 5 2020

aadsm added inline comments to D87868: [RFC] When calling the process mmap try to call all found instead of just the first one.
Oct 5 2020, 3:52 PM · Restricted Project
aadsm updated the diff for D87868: [RFC] When calling the process mmap try to call all found instead of just the first one.

I explored Greg's suggestion of checking if the functions were external symbols. As suspected the overriden mmap is not external, so we can use this check to avoid calling it!

Oct 5 2020, 10:24 AM · Restricted Project

Sep 21 2020

aadsm added a comment to D87868: [RFC] When calling the process mmap try to call all found instead of just the first one.

It seems like calling any 'mmap' definition should work. Is the interposed mmap implementation failing and correctly returning -1, or is it succeeding and incorrectly returning -1? In either case, it seems like it's worth digging into why it's failing / returning the wrong result

Sep 21 2020, 9:08 PM · Restricted Project

Sep 20 2020

aadsm added a comment to D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message.

Why would we be doing something (particularly a thing which will be hard to do in a cross-platform manner, and will very likely border on, or downright cross into, undefined behavior territory), if we get that from vscode for free?

Sep 20 2020, 11:16 PM · Restricted Project
aadsm added inline comments to D87172: Check if debug line sequences are starting after the first code segment.
Sep 20 2020, 2:48 PM · Restricted Project
aadsm added inline comments to D87179: Fix debug_abbrev emitter to only assign table id once.
Sep 20 2020, 2:38 PM · Restricted Project

Sep 17 2020

aadsm updated the summary of D87868: [RFC] When calling the process mmap try to call all found instead of just the first one.
Sep 17 2020, 4:14 PM · Restricted Project
aadsm requested review of D87868: [RFC] When calling the process mmap try to call all found instead of just the first one.
Sep 17 2020, 4:10 PM · Restricted Project

Sep 14 2020

aadsm added inline comments to D87179: Fix debug_abbrev emitter to only assign table id once.
Sep 14 2020, 9:41 AM · Restricted Project

Sep 13 2020

aadsm updated the diff for D87179: Fix debug_abbrev emitter to only assign table id once.

Make sure there's an empty abbrev table as the last table.

Sep 13 2020, 7:56 AM · Restricted Project

Sep 12 2020

aadsm added a comment to D87179: Fix debug_abbrev emitter to only assign table id once.

@Higuoxing I didn't realize the DWARF section was completely new until I read your GSOC project. Thanks a lot for this work otherwise it would have been impossible for me to create the tests I needed for my other diff!

Sep 12 2020, 11:55 PM · Restricted Project

Sep 5 2020

aadsm updated the diff for D87173: Ignores functions that have a range starting outside of a code section.

Check lowest code address instead of checking if the section is code.

Sep 5 2020, 5:04 PM · Restricted Project
aadsm updated the diff for D87172: Check if debug line sequences are starting after the first code segment.

Address comments

Sep 5 2020, 4:53 PM · Restricted Project
aadsm added inline comments to D87172: Check if debug line sequences are starting after the first code segment.
Sep 5 2020, 4:23 PM · Restricted Project
aadsm updated the diff for D87179: Fix debug_abbrev emitter to only assign table id once.

Moved the increment to the outer loop and used the already existing debug_info test instead of creating a new one.

Sep 5 2020, 4:14 PM · Restricted Project
aadsm added inline comments to D87179: Fix debug_abbrev emitter to only assign table id once.
Sep 5 2020, 12:23 PM · Restricted Project

Sep 4 2020

aadsm added inline comments to D87179: Fix debug_abbrev emitter to only assign table id once.
Sep 4 2020, 10:05 PM · Restricted Project
aadsm requested review of D87179: Fix debug_abbrev emitter to only assign table id once.
Sep 4 2020, 10:03 PM · Restricted Project
aadsm added inline comments to D87173: Ignores functions that have a range starting outside of a code section.
Sep 4 2020, 6:35 PM · Restricted Project
aadsm added inline comments to D87172: Check if debug line sequences are starting after the first code segment.
Sep 4 2020, 6:33 PM · Restricted Project
aadsm added inline comments to D87172: Check if debug line sequences are starting after the first code segment.
Sep 4 2020, 5:04 PM · Restricted Project
aadsm requested review of D87173: Ignores functions that have a range starting outside of a code section.
Sep 4 2020, 5:03 PM · Restricted Project
aadsm added inline comments to D87172: Check if debug line sequences are starting after the first code segment.
Sep 4 2020, 5:00 PM · Restricted Project
aadsm requested review of D87172: Check if debug line sequences are starting after the first code segment.
Sep 4 2020, 4:58 PM · Restricted Project

Aug 24 2020

aadsm added a reviewer for D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message: wallace.
Aug 24 2020, 5:35 PM · Restricted Project

Aug 22 2020

aadsm committed rG52381938bcc8: Create ${swig_target}-scripts target instead of lldb-python-scripts (authored by aadsm).
Create ${swig_target}-scripts target instead of lldb-python-scripts
Aug 22 2020, 7:38 PM
aadsm closed D86402: Avoid creating lldb-python-scripts target more than once.
Aug 22 2020, 7:38 PM · Restricted Project
aadsm updated the diff for D86402: Avoid creating lldb-python-scripts target more than once.

Update to create 2 separate install targets

Aug 22 2020, 11:58 AM · Restricted Project
aadsm added a comment to D86402: Avoid creating lldb-python-scripts target more than once.

Sounds good, will update. In my mind it would be easier to just install all configured python scripts by specifying a single distribution component.

Aug 22 2020, 11:26 AM · Restricted Project
aadsm committed rG5d8eedee917d: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it (authored by aadsm).
Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it
Aug 22 2020, 10:44 AM
aadsm closed D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it.
Aug 22 2020, 10:44 AM · Restricted Project
aadsm requested review of D86402: Avoid creating lldb-python-scripts target more than once.
Aug 22 2020, 10:27 AM · Restricted Project
aadsm added inline comments to rG02bf5632a94d: Fix swig scripts install target name.
Aug 22 2020, 10:26 AM

Aug 21 2020

aadsm updated the diff for D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it.

After reading a bit more how clang-tidy works this isn't fixable because it actually needs to compile it. I also didn't find a way to exclude a file from it.
My plan is to just land this and then make a PR to add this file to https://github.com/google/llvm-premerge-checks/blob/master/scripts/clang-tidy.ignore

Aug 21 2020, 10:26 PM · Restricted Project
aadsm updated the diff for D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it.

Moved the header file to be in Plugins/ScriptInterpreter/Python so clang-tidy doesn't get confused solving include paths.

Aug 21 2020, 7:22 PM · Restricted Project
aadsm updated the diff for D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it.

Added include guards, clang-format and python include

Aug 21 2020, 6:35 PM · Restricted Project
aadsm requested review of D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it.
Aug 21 2020, 3:32 PM · Restricted Project
aadsm committed rG02bf5632a94d: Fix swig scripts install target name (authored by aadsm).
Fix swig scripts install target name
Aug 21 2020, 2:53 PM
aadsm closed D86235: Fix swig scripts install target name.
Aug 21 2020, 2:53 PM · Restricted Project
aadsm updated the diff for D86235: Fix swig scripts install target name.

Updated to use more friendly component name lldb-python-scripts name instead of finish_swig_python_scripts

Aug 21 2020, 2:24 PM · Restricted Project
aadsm added inline comments to D77480: Fix illegal early call to PyBuffer_Release in swig typemaps.
Aug 21 2020, 1:46 PM · Restricted Project
aadsm added inline comments to D77480: Fix illegal early call to PyBuffer_Release in swig typemaps.
Aug 21 2020, 10:40 AM · Restricted Project

Aug 19 2020

aadsm added a comment to D86235: Fix swig scripts install target name.

@JDevlieghere thanks for the quick review, but on the name I mean the actual finish_swig_python_scripts, this sounds like a step name and not a component distributed by llvm like liblldb ot lldb-server. That was the reason at the time I named it lldb-python-scripts because it was very clear what was being installed.
Would you be fine with me changing swig_scripts_target back to lldb-python-scripts?

Aug 19 2020, 1:34 PM · Restricted Project
aadsm updated the summary of D86235: Fix swig scripts install target name.
Aug 19 2020, 11:27 AM · Restricted Project
aadsm requested review of D86235: Fix swig scripts install target name.
Aug 19 2020, 11:24 AM · Restricted Project

Jul 9 2020

aadsm updated the diff for D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message.

This update still doesn't add windows support but I just want to get a feel that I'm going on the right direction.
It addresses the following:

Jul 9 2020, 7:01 PM · Restricted Project

Jun 16 2020

aadsm accepted D81978: Redo of Add terminateCommands to lldb-vscode protocol.

Thank you for this! <3

Jun 16 2020, 6:38 PM · Restricted Project

May 29 2020

aadsm added a comment to D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message.

Absolutely, I'll look into that first.

May 29 2020, 10:21 AM · Restricted Project

May 28 2020

aadsm added a comment to D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message.

thanks for the feedback, I'll read it more carefully later. As for the tests it should be easy to set up, didn't want to spend time on that before we agreed on doing it this way.

May 28 2020, 10:23 AM · Restricted Project

May 27 2020

aadsm created D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message.
May 27 2020, 1:36 PM · Restricted Project
aadsm added a comment to D80576: [lldb-vscode] Reopen stderr as /dev/null.

I don't think we should ignore stderr this at this level, we should either do what Pavel suggests or send the stderr back through the protocol. I actually have some code that does this, it outputs both stderr and stdout to the console message. I did this because I want to be able to see in the vscode's debugger console what I see when running lldb in the command line and also because any text sent by lldb (e.g.: python interpreter) to the stdout will ruin the protocol communication. Let me put my code up in a diff.

May 27 2020, 11:56 AM · Restricted Project

May 19 2020

António Afonso <aadsm@fb.com> committed rGa3609b0ec685: Add terminateCommands to lldb-vscode protocol (authored by aadsm).
Add terminateCommands to lldb-vscode protocol
May 19 2020, 4:36 PM
aadsm closed D79726: Add terminateCommands to lldb-vscode protocol.
May 19 2020, 4:36 PM · Restricted Project

May 14 2020

aadsm updated the diff for D79726: Add terminateCommands to lldb-vscode protocol.

Updated README.md, package.json to document the new option. Also refactored the test support a bit to allow easier testing.

May 14 2020, 7:35 PM · Restricted Project
aadsm added a comment to D79757: Use IPv4 for Android connections.

@clayborg the support we added was for the lldb-server.

May 14 2020, 9:10 AM · Restricted Project

May 12 2020

aadsm added inline comments to D79726: Add terminateCommands to lldb-vscode protocol.
May 12 2020, 8:29 PM · Restricted Project
aadsm added inline comments to D79726: Add terminateCommands to lldb-vscode protocol.
May 12 2020, 11:49 AM · Restricted Project
aadsm added a comment to D79726: Add terminateCommands to lldb-vscode protocol.

I gotta say I don't understand the difference between "exit" and "terminate" commands, as both seem to happen pretty at once. Is the difference that "exit" commands are run only when the inferior exits freely on its own, and not when we forcefully kill it? And that "terminate" cmds are run in both cases?

May 12 2020, 10:11 AM · Restricted Project
aadsm added inline comments to D79726: Add terminateCommands to lldb-vscode protocol.
May 12 2020, 10:11 AM · Restricted Project

May 11 2020

aadsm updated the diff for D79726: Add terminateCommands to lldb-vscode protocol.

Rebase and remove unwanted debug code

May 11 2020, 4:12 PM · Restricted Project
aadsm added a comment to D79726: Add terminateCommands to lldb-vscode protocol.

I chose the name terminate because this happens just before the terminated event is sent back to the client.

May 11 2020, 3:40 PM · Restricted Project
aadsm updated the diff for D79726: Add terminateCommands to lldb-vscode protocol.

Remove debugging leftovers

May 11 2020, 10:11 AM · Restricted Project
aadsm created D79726: Add terminateCommands to lldb-vscode protocol.
May 11 2020, 10:11 AM · Restricted Project

Mar 30 2020

aadsm accepted D76872: [intel-pt] Fix existing support in LLDB.
Mar 30 2020, 1:37 PM · Restricted Project

Feb 28 2020

aadsm accepted D75390: Fix GSYM tests to run the yaml files and fix test failures on some machines..
Feb 28 2020, 5:01 PM · Restricted Project

Jan 23 2020

aadsm added a comment to D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging.

Yeah, I'm not sure why the LoadModules function is calling target.SetExecutableModule. It is true that the libraries-svr4 will not include the main executable in its list.
This code was added in the context of providing qXfer:libraries support here: https://reviews.llvm.org/D9471. I don't see any mention of including the executable on that packet though: https://sourceware.org/gdb/current/onlinedocs/gdb/Library-List-Format.html. @clayborg was the main reviewer there (although this was 5 years ago or so) and he does mention multiple times in the comments this exact issue with calling target.SetExecutableModule. Maybe he can still remember and provide some light here :).

Jan 23 2020, 9:37 PM · Restricted Project

Dec 5 2019

aadsm abandoned D70883: [vscode.py] Make read_packet only return None when EOF.

Fair enough, I haven't seen evidence of this (haven't searched for it) but I imagine IDEs need to ignore this as well otherwise they just barf if they're expecting Content-Length and a wild print appears. The notion of stdout of SBDebugger is the SBCommandReturnObject which doesn't print right away (only when the command finishes executing) and from my previous tests .flush() doesn't help with this. I believe this is the reason why people opt to use print instead in their custom commands. But I don't think it's a reasonable assumption (or api contract) to tell people they can't use print or it breaks lldb-vscode.

Dec 5 2019, 1:31 PM · Restricted Project

Dec 3 2019

aadsm added a comment to D70886: [lldb-vscode] capture the debuggers file handles before lldbinit runs.

Maybe you could do something similar to LocalLLDBInit.test ?

That test uses the lldb -S (and others) flags that lldb-vscode doesn't support :(. These flags should really be added to the initialize packet but they're very specific to lldb and the DAP doesn't support it.. We could implement something like what Driver::ProcessArgs does and pass options through envs but, the logic in ProcessArgs itself is sketchy (just like the comment mentions) and I l also find it odd to pass options through env vars...

Dec 3 2019, 12:25 PM · Restricted Project

Dec 2 2019

aadsm updated the diff for D70882: Add environment var LLDBVSCODE_SKIP_INIT_FILES to lldb-vscode.

Put the logic into a function

Dec 2 2019, 6:22 PM · Restricted Project
António Afonso <aadsm@fb.com> committed rGafd5d912812e: [lldb] Fix TestFormattersSBAPI test (authored by aadsm).
[lldb] Fix TestFormattersSBAPI test
Dec 2 2019, 12:25 PM
aadsm closed D70884: [lldb] Fix TestFormattersSBAPI test.
Dec 2 2019, 12:25 PM · Restricted Project