Page MenuHomePhabricator

aadsm (António Afonso)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 27 2019, 10:34 PM (102 w, 2 d)

Recent Activity

Feb 21 2021

aadsm added a reverting change for rG1f21d488bd79: [lldb-vscode] Emit the breakpoint changed event on location resolved: rG878d82c4f2b3: Revert "[lldb-vscode] Emit the breakpoint changed event on location resolved".
Feb 21 2021, 1:08 PM
aadsm committed rG878d82c4f2b3: Revert "[lldb-vscode] Emit the breakpoint changed event on location resolved" (authored by aadsm).
Revert "[lldb-vscode] Emit the breakpoint changed event on location resolved"
Feb 21 2021, 1:08 PM
aadsm added a reverting change for D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved: rG878d82c4f2b3: Revert "[lldb-vscode] Emit the breakpoint changed event on location resolved".
Feb 21 2021, 1:08 PM · Restricted Project
aadsm added a reverting change for rGa83a825e9902: Make sure the interpreter module was loaded before making checks against it: rGb19d3b092d4e: Revert "Make sure the interpreter module was loaded before making checks….
Feb 21 2021, 10:39 AM
aadsm committed rGb19d3b092d4e: Revert "Make sure the interpreter module was loaded before making checks… (authored by aadsm).
Revert "Make sure the interpreter module was loaded before making checks…
Feb 21 2021, 10:39 AM
aadsm added a reverting change for D96637: Make sure the interpreter module was loaded before making checks against it: rGb19d3b092d4e: Revert "Make sure the interpreter module was loaded before making checks….
Feb 21 2021, 10:39 AM · Restricted Project
aadsm committed rG1f21d488bd79: [lldb-vscode] Emit the breakpoint changed event on location resolved (authored by aadsm).
[lldb-vscode] Emit the breakpoint changed event on location resolved
Feb 21 2021, 9:47 AM
aadsm closed D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved.
Feb 21 2021, 9:46 AM · Restricted Project
aadsm added a comment to D96637: Make sure the interpreter module was loaded before making checks against it.

oh no, I picked the wrong commit to land :(. I think this is fine because I already addressed the comments, but if there's still something I should work on here, I'll put another diff up.

Feb 21 2021, 9:37 AM · Restricted Project
aadsm committed rGa83a825e9902: Make sure the interpreter module was loaded before making checks against it (authored by aadsm).
Make sure the interpreter module was loaded before making checks against it
Feb 21 2021, 9:28 AM
aadsm closed D96637: Make sure the interpreter module was loaded before making checks against it.
Feb 21 2021, 9:28 AM · Restricted Project

Feb 20 2021

aadsm updated the diff for D96637: Make sure the interpreter module was loaded before making checks against it.

Checks the module is not loaded right after we attach

Feb 20 2021, 11:11 AM · Restricted Project
aadsm added inline comments to D96637: Make sure the interpreter module was loaded before making checks against it.
Feb 20 2021, 10:44 AM · Restricted Project
aadsm added inline comments to D96637: Make sure the interpreter module was loaded before making checks against it.
Feb 20 2021, 10:36 AM · Restricted Project

Feb 19 2021

aadsm updated the diff for D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved.

Removed unnecessary comment

Feb 19 2021, 4:52 PM · Restricted Project
aadsm updated the diff for D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved.

Add test

Feb 19 2021, 4:51 PM · Restricted Project

Feb 18 2021

aadsm added a comment to D96637: Make sure the interpreter module was loaded before making checks against it.

I don't think this does what you think it does. The $() doesn't give you the process id of anything -- it substitutes a string by the result of running that string as a shell command. So, the PID variable would get the (entire) stdout of %s.out

Feb 18 2021, 8:36 PM · Restricted Project
aadsm updated the diff for D96637: Make sure the interpreter module was loaded before making checks against it.

Add api test

Feb 18 2021, 8:32 PM · Restricted Project
aadsm updated the diff for D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved.

revert last amend: added the test to the wrong diff

Feb 18 2021, 8:29 PM · Restricted Project
aadsm updated the diff for D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved.

Add api test

Feb 18 2021, 8:25 PM · Restricted Project

Feb 16 2021

aadsm added a comment to D96637: Make sure the interpreter module was loaded before making checks against it.

We should have a test for this.

Feb 16 2021, 6:46 PM · Restricted Project

Feb 14 2021

aadsm requested review of D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved.
Feb 14 2021, 6:44 PM · Restricted Project

Feb 12 2021

aadsm added a reviewer for D96637: Make sure the interpreter module was loaded before making checks against it: clayborg.
Feb 12 2021, 3:30 PM · Restricted Project
aadsm added a comment to D96520: Reduce time spent parsing support files.

can you share the profiles you got? I'm curious on the speed up as I also with large c++ binaries.

Feb 12 2021, 3:28 PM · Restricted Project
aadsm requested review of D96637: Make sure the interpreter module was loaded before making checks against it.
Feb 12 2021, 2:37 PM · Restricted Project

Jan 20 2021

aadsm added inline comments to D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided..
Jan 20 2021, 10:45 AM · Restricted Project

Jan 19 2021

aadsm added a reverting change for rGa9dcd15f50dc: Revert "Ignores functions that have a range starting outside of a code section": D95008: Revert "Revert "Ignores functions that have a range starting outside of a code section"".
Jan 19 2021, 3:45 PM
aadsm requested review of D95008: Revert "Revert "Ignores functions that have a range starting outside of a code section"".
Jan 19 2021, 3:45 PM · Restricted Project

Nov 19 2020

aadsm added a comment to D87173: Ignores functions that have a range starting outside of a code section.

When I landed this I got test errors on the windows machine (the same tests pass on the other machine). I tried to repro this on 2 different machines I was able to get access but to no avail.
These are the failing tests: http://lab.llvm.org:8011/#/builders/83/builds/644 but when I ran lldb-test on the find-basic-function the output was what I would expect so not really sure how I can figure this out. Any ideas?

Nov 19 2020, 10:39 AM · Restricted Project

Nov 9 2020

aadsm added a reverting change for rG265a38fbc547: Check if debug line sequences are starting after the first code segment: rGd7be9a46475f: Revert "Check if debug line sequences are starting after the first code segment".
Nov 9 2020, 11:48 AM
aadsm committed rGd7be9a46475f: Revert "Check if debug line sequences are starting after the first code segment" (authored by aadsm).
Revert "Check if debug line sequences are starting after the first code segment"
Nov 9 2020, 11:48 AM
aadsm added a reverting change for D87172: Check if debug line sequences are starting after the first code segment: rGd7be9a46475f: Revert "Check if debug line sequences are starting after the first code segment".
Nov 9 2020, 11:48 AM · Restricted Project
aadsm added a comment to D87172: Check if debug line sequences are starting after the first code segment.

reverting because I'm not able to repro the fails, so need more time to figure it out.

Nov 9 2020, 11:46 AM · Restricted Project
aadsm added a reverting change for rGdf30bc0168d2: Ignores functions that have a range starting outside of a code section: rGa9dcd15f50dc: Revert "Ignores functions that have a range starting outside of a code section".
Nov 9 2020, 9:08 AM
aadsm committed rGa9dcd15f50dc: Revert "Ignores functions that have a range starting outside of a code section" (authored by aadsm).
Revert "Ignores functions that have a range starting outside of a code section"
Nov 9 2020, 9:08 AM
aadsm added a reverting change for D87173: Ignores functions that have a range starting outside of a code section: rGa9dcd15f50dc: Revert "Ignores functions that have a range starting outside of a code section".
Nov 9 2020, 9:08 AM · Restricted Project
aadsm committed rGdf30bc0168d2: Ignores functions that have a range starting outside of a code section (authored by aadsm).
Ignores functions that have a range starting outside of a code section
Nov 9 2020, 8:27 AM
aadsm committed rG265a38fbc547: Check if debug line sequences are starting after the first code segment (authored by aadsm).
Check if debug line sequences are starting after the first code segment
Nov 9 2020, 8:27 AM
aadsm closed D87173: Ignores functions that have a range starting outside of a code section.
Nov 9 2020, 8:26 AM · Restricted Project
aadsm closed D87172: Check if debug line sequences are starting after the first code segment.
Nov 9 2020, 8:26 AM · Restricted Project

Nov 8 2020

aadsm updated the diff for D87173: Ignores functions that have a range starting outside of a code section.

Merged the 2 run/checks into one

Nov 8 2020, 6:32 PM · Restricted Project
aadsm committed rG32d239a75882: Fix debug_abbrev emitter to only assign table id once (authored by aadsm).
Fix debug_abbrev emitter to only assign table id once
Nov 8 2020, 6:13 PM
aadsm closed D87179: Fix debug_abbrev emitter to only assign table id once.
Nov 8 2020, 6:12 PM · Restricted Project

Nov 1 2020

aadsm updated the diff for D70885: [lldb] Use explicit lldb commands on tests.

Use set and rebase

Nov 1 2020, 3:54 PM · Restricted Project
aadsm updated the diff for D87868: [RFC] When calling the process mmap try to call all found instead of just the first one.

Also set the symbol as external when it is weak

Nov 1 2020, 3:46 PM · Restricted Project
aadsm updated the diff for D87179: Fix debug_abbrev emitter to only assign table id once.

Address all comments (I hope)

Nov 1 2020, 10:25 AM · Restricted Project
aadsm added inline comments to D87172: Check if debug line sequences are starting after the first code segment.
Nov 1 2020, 8:46 AM · Restricted Project
aadsm updated the diff for D87173: Ignores functions that have a range starting outside of a code section.

Used -s to feed commands and disabled errors when interpreting them

Nov 1 2020, 8:44 AM · Restricted Project

Oct 28 2020

aadsm updated the diff for D87173: Ignores functions that have a range starting outside of a code section.

Rewrote the test in lit.

Oct 28 2020, 6:55 PM · Restricted Project
aadsm updated the diff for D87172: Check if debug line sequences are starting after the first code segment.
  • Fixed formatting issues
  • Updated comment on the reason we need to do this
  • Improved the lit test by also checking how many matches it found
Oct 28 2020, 2:59 PM · Restricted Project

Oct 22 2020

aadsm updated the diff for D87172: Check if debug line sequences are starting after the first code segment.

Check all child sections and makes sure the section is an actual code section.

Oct 22 2020, 6:20 PM · Restricted Project
aadsm added inline comments to D87172: Check if debug line sequences are starting after the first code segment.
Oct 22 2020, 6:10 PM · Restricted Project

Oct 19 2020

aadsm added inline comments to D87172: Check if debug line sequences are starting after the first code segment.
Oct 19 2020, 3:29 PM · Restricted Project

Oct 18 2020

aadsm added a comment to D87868: [RFC] When calling the process mmap try to call all found instead of just the first one.

Should I still go ahead with this since @labath implemented the memory allocation on lldb-server?

Oct 18 2020, 4:52 PM · Restricted Project
aadsm updated the diff for D87172: Check if debug line sequences are starting after the first code segment.

Addressed all comments:

Oct 18 2020, 4:47 PM · Restricted Project

Oct 6 2020

aadsm added inline comments to D87868: [RFC] When calling the process mmap try to call all found instead of just the first one.
Oct 6 2020, 8:49 AM · Restricted Project
aadsm added inline comments to D87868: [RFC] When calling the process mmap try to call all found instead of just the first one.
Oct 6 2020, 8:47 AM · Restricted Project

Oct 5 2020

aadsm added inline comments to D87868: [RFC] When calling the process mmap try to call all found instead of just the first one.
Oct 5 2020, 3:52 PM · Restricted Project
aadsm updated the diff for D87868: [RFC] When calling the process mmap try to call all found instead of just the first one.

I explored Greg's suggestion of checking if the functions were external symbols. As suspected the overriden mmap is not external, so we can use this check to avoid calling it!

Oct 5 2020, 10:24 AM · Restricted Project

Sep 21 2020

aadsm added a comment to D87868: [RFC] When calling the process mmap try to call all found instead of just the first one.

It seems like calling any 'mmap' definition should work. Is the interposed mmap implementation failing and correctly returning -1, or is it succeeding and incorrectly returning -1? In either case, it seems like it's worth digging into why it's failing / returning the wrong result

Sep 21 2020, 9:08 PM · Restricted Project

Sep 20 2020

aadsm added a comment to D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message.

Why would we be doing something (particularly a thing which will be hard to do in a cross-platform manner, and will very likely border on, or downright cross into, undefined behavior territory), if we get that from vscode for free?

Sep 20 2020, 11:16 PM · Restricted Project
aadsm added inline comments to D87172: Check if debug line sequences are starting after the first code segment.
Sep 20 2020, 2:48 PM · Restricted Project
aadsm added inline comments to D87179: Fix debug_abbrev emitter to only assign table id once.
Sep 20 2020, 2:38 PM · Restricted Project

Sep 17 2020

aadsm updated the summary of D87868: [RFC] When calling the process mmap try to call all found instead of just the first one.
Sep 17 2020, 4:14 PM · Restricted Project
aadsm requested review of D87868: [RFC] When calling the process mmap try to call all found instead of just the first one.
Sep 17 2020, 4:10 PM · Restricted Project

Sep 14 2020

aadsm added inline comments to D87179: Fix debug_abbrev emitter to only assign table id once.
Sep 14 2020, 9:41 AM · Restricted Project

Sep 13 2020

aadsm updated the diff for D87179: Fix debug_abbrev emitter to only assign table id once.

Make sure there's an empty abbrev table as the last table.

Sep 13 2020, 7:56 AM · Restricted Project

Sep 12 2020

aadsm added a comment to D87179: Fix debug_abbrev emitter to only assign table id once.

@Higuoxing I didn't realize the DWARF section was completely new until I read your GSOC project. Thanks a lot for this work otherwise it would have been impossible for me to create the tests I needed for my other diff!

Sep 12 2020, 11:55 PM · Restricted Project

Sep 5 2020

aadsm updated the diff for D87173: Ignores functions that have a range starting outside of a code section.

Check lowest code address instead of checking if the section is code.

Sep 5 2020, 5:04 PM · Restricted Project
aadsm updated the diff for D87172: Check if debug line sequences are starting after the first code segment.

Address comments

Sep 5 2020, 4:53 PM · Restricted Project
aadsm added inline comments to D87172: Check if debug line sequences are starting after the first code segment.
Sep 5 2020, 4:23 PM · Restricted Project
aadsm updated the diff for D87179: Fix debug_abbrev emitter to only assign table id once.

Moved the increment to the outer loop and used the already existing debug_info test instead of creating a new one.

Sep 5 2020, 4:14 PM · Restricted Project
aadsm added inline comments to D87179: Fix debug_abbrev emitter to only assign table id once.
Sep 5 2020, 12:23 PM · Restricted Project

Sep 4 2020

aadsm added inline comments to D87179: Fix debug_abbrev emitter to only assign table id once.
Sep 4 2020, 10:05 PM · Restricted Project
aadsm requested review of D87179: Fix debug_abbrev emitter to only assign table id once.
Sep 4 2020, 10:03 PM · Restricted Project
aadsm added inline comments to D87173: Ignores functions that have a range starting outside of a code section.
Sep 4 2020, 6:35 PM · Restricted Project
aadsm added inline comments to D87172: Check if debug line sequences are starting after the first code segment.
Sep 4 2020, 6:33 PM · Restricted Project
aadsm added inline comments to D87172: Check if debug line sequences are starting after the first code segment.
Sep 4 2020, 5:04 PM · Restricted Project
aadsm requested review of D87173: Ignores functions that have a range starting outside of a code section.
Sep 4 2020, 5:03 PM · Restricted Project
aadsm added inline comments to D87172: Check if debug line sequences are starting after the first code segment.
Sep 4 2020, 5:00 PM · Restricted Project
aadsm requested review of D87172: Check if debug line sequences are starting after the first code segment.
Sep 4 2020, 4:58 PM · Restricted Project

Aug 24 2020

aadsm added a reviewer for D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message: wallace.
Aug 24 2020, 5:35 PM · Restricted Project

Aug 22 2020

aadsm committed rG52381938bcc8: Create ${swig_target}-scripts target instead of lldb-python-scripts (authored by aadsm).
Create ${swig_target}-scripts target instead of lldb-python-scripts
Aug 22 2020, 7:38 PM
aadsm closed D86402: Avoid creating lldb-python-scripts target more than once.
Aug 22 2020, 7:38 PM · Restricted Project
aadsm updated the diff for D86402: Avoid creating lldb-python-scripts target more than once.

Update to create 2 separate install targets

Aug 22 2020, 11:58 AM · Restricted Project
aadsm added a comment to D86402: Avoid creating lldb-python-scripts target more than once.

Sounds good, will update. In my mind it would be easier to just install all configured python scripts by specifying a single distribution component.

Aug 22 2020, 11:26 AM · Restricted Project
aadsm committed rG5d8eedee917d: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it (authored by aadsm).
Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it
Aug 22 2020, 10:44 AM
aadsm closed D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it.
Aug 22 2020, 10:44 AM · Restricted Project
aadsm requested review of D86402: Avoid creating lldb-python-scripts target more than once.
Aug 22 2020, 10:27 AM · Restricted Project
aadsm added inline comments to rG02bf5632a94d: Fix swig scripts install target name.
Aug 22 2020, 10:26 AM

Aug 21 2020

aadsm updated the diff for D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it.

After reading a bit more how clang-tidy works this isn't fixable because it actually needs to compile it. I also didn't find a way to exclude a file from it.
My plan is to just land this and then make a PR to add this file to https://github.com/google/llvm-premerge-checks/blob/master/scripts/clang-tidy.ignore

Aug 21 2020, 10:26 PM · Restricted Project
aadsm updated the diff for D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it.

Moved the header file to be in Plugins/ScriptInterpreter/Python so clang-tidy doesn't get confused solving include paths.

Aug 21 2020, 7:22 PM · Restricted Project
aadsm updated the diff for D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it.

Added include guards, clang-format and python include

Aug 21 2020, 6:35 PM · Restricted Project
aadsm requested review of D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it.
Aug 21 2020, 3:32 PM · Restricted Project
aadsm committed rG02bf5632a94d: Fix swig scripts install target name (authored by aadsm).
Fix swig scripts install target name
Aug 21 2020, 2:53 PM
aadsm closed D86235: Fix swig scripts install target name.
Aug 21 2020, 2:53 PM · Restricted Project
aadsm updated the diff for D86235: Fix swig scripts install target name.

Updated to use more friendly component name lldb-python-scripts name instead of finish_swig_python_scripts

Aug 21 2020, 2:24 PM · Restricted Project
aadsm added inline comments to D77480: Fix illegal early call to PyBuffer_Release in swig typemaps.
Aug 21 2020, 1:46 PM · Restricted Project
aadsm added inline comments to D77480: Fix illegal early call to PyBuffer_Release in swig typemaps.
Aug 21 2020, 10:40 AM · Restricted Project

Aug 19 2020

aadsm added a comment to D86235: Fix swig scripts install target name.

@JDevlieghere thanks for the quick review, but on the name I mean the actual finish_swig_python_scripts, this sounds like a step name and not a component distributed by llvm like liblldb ot lldb-server. That was the reason at the time I named it lldb-python-scripts because it was very clear what was being installed.
Would you be fine with me changing swig_scripts_target back to lldb-python-scripts?

Aug 19 2020, 1:34 PM · Restricted Project