This is an archive of the discontinued LLVM Phabricator instance.

[Vectorizers][TTI] remove option to bypass creation of vector reduction intrinsics
ClosedPublic

Authored by spatel on Feb 11 2021, 2:36 PM.

Details

Summary

The vector reduction intrinsics started life as experimental ops, so backend support was lacking. As part of promoting them to 1st-class intrinsics, however, codegen support was added/improved:
D58015
D90247

So I think it is safe to now remove this complication from IR.

Note that we still have an IR-level codegen expansion pass for these as discussed in D95690. Removing that is another step in simplifying the logic. Also note that x86 was already unconditionally forming reductions in IR, so there should be no difference for x86.

I spot checked a couple of the tests here by running them though opt+llc and did not see any asm diffs.

Diff Detail

Event Timeline

spatel created this revision.Feb 11 2021, 2:36 PM
spatel requested review of this revision.Feb 11 2021, 2:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2021, 2:36 PM
nikic accepted this revision.Feb 11 2021, 2:40 PM

LGTM

This revision is now accepted and ready to land.Feb 11 2021, 2:40 PM
dmgreen accepted this revision.Feb 12 2021, 12:12 AM

Nice. I agree. Sounds good to me.