This is an archive of the discontinued LLVM Phabricator instance.

Differential D96493

[ARM] Copy-paste error in ARMv87a architecture definition.
ClosedPublic

Authored by simon_tatham on Feb 11 2021, 5:12 AM.

Download Raw Diff

Details

Reviewers

ostannard
pratlucas
momchil.velikov

Commits

rG69f1a7ad82fd: [ARM] Copy-paste error in ARMv87a architecture definition.

Summary

In the tablegen architecture definition, the Name field for the
ARMv87a record read "ARMv86a". All the other records contain their own
names.

Corrected it to "ARMv87a", and added the necessary value in
ARMArchEnum for that to refer to.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

simon_tatham created this revision.Feb 11 2021, 5:12 AM

Herald added subscribers: danielkiss, hiraditya, kristof.beyls. · View Herald TranscriptFeb 11 2021, 5:13 AM

simon_tatham requested review of this revision.Feb 11 2021, 5:13 AM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2021, 5:13 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster completed remote builds in B88787: Diff 322956.Feb 11 2021, 5:19 AM

Ahem. Now actually tested, and with the necessary extra enum definition.

LGTM.

This revision is now accepted and ready to land.Feb 11 2021, 5:31 AM

This revision was landed with ongoing or failed builds.Feb 11 2021, 5:36 AM

Closed by commit rG69f1a7ad82fd: [ARM] Copy-paste error in ARMv87a architecture definition. (authored by simon_tatham). · Explain Why

This revision was automatically updated to reflect the committed changes.

simon_tatham added a commit: rG69f1a7ad82fd: [ARM] Copy-paste error in ARMv87a architecture definition..

Harbormaster completed remote builds in B88789: Diff 322961.Feb 11 2021, 6:04 AM

Revision Contents

Path

Size

llvm/

lib/

Target/

ARM/

2 lines

1 line

Diff 322963

llvm/lib/Target/ARM/ARM.td

	Show First 20 Lines • Show All 846 Lines • ▼ Show 20 Lines		def ARMv86a : Architecture<"armv8.6-a", "ARMv86a", [HasV8_6aOps,
	FeatureDSP,			FeatureDSP,
	FeatureTrustZone,			FeatureTrustZone,
	FeatureMP,			FeatureMP,
	FeatureVirtualization,			FeatureVirtualization,
	FeatureCrypto,			FeatureCrypto,
	FeatureCRC,			FeatureCRC,
	FeatureRAS,			FeatureRAS,
	FeatureDotProd]>;			FeatureDotProd]>;
	def ARMv87a : Architecture<"armv8.7-a", "ARMv86a", [HasV8_7aOps,			def ARMv87a : Architecture<"armv8.7-a", "ARMv87a", [HasV8_7aOps,
	FeatureAClass,			FeatureAClass,
	FeatureDB,			FeatureDB,
	FeatureFPARMv8,			FeatureFPARMv8,
	FeatureNEON,			FeatureNEON,
	FeatureDSP,			FeatureDSP,
	FeatureTrustZone,			FeatureTrustZone,
	FeatureMP,			FeatureMP,
	FeatureVirtualization,			FeatureVirtualization,
	▲ Show 20 Lines • Show All 549 Lines • Show Last 20 Lines

llvm/lib/Target/ARM/ARMSubtarget.h

	Show First 20 Lines • Show All 111 Lines • ▼ Show 20 Lines		enum ARMArchEnum {
	ARMv7r,			ARMv7r,
	ARMv7ve,			ARMv7ve,
	ARMv81a,			ARMv81a,
	ARMv82a,			ARMv82a,
	ARMv83a,			ARMv83a,
	ARMv84a,			ARMv84a,
	ARMv85a,			ARMv85a,
	ARMv86a,			ARMv86a,
				ARMv87a,
	ARMv8a,			ARMv8a,
	ARMv8mBaseline,			ARMv8mBaseline,
	ARMv8mMainline,			ARMv8mMainline,
	ARMv8r,			ARMv8r,
	ARMv81mMainline,			ARMv81mMainline,
	};			};

	public:			public:
	▲ Show 20 Lines • Show All 798 Lines • Show Last 20 Lines