Page MenuHomePhabricator

[test][Dexter] Fix test failure if space in python path
ClosedPublic

Authored by jhenderson on Feb 10 2021, 7:20 AM.

Details

Summary

The '%dexter_regression_test' substitution was missing quotes around the python executable, unlike other substitutions of a similar nature in the file. This changes fixes the issue.

Diff Detail

Event Timeline

jhenderson requested review of this revision.Feb 10 2021, 7:20 AM
jhenderson created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2021, 7:20 AM
jmorse accepted this revision.Feb 10 2021, 7:36 AM

From the file history, this has happened a few times before :(. Ship it.

This revision is now accepted and ready to land.Feb 10 2021, 7:36 AM

From the file history, this has happened a few times before :(. Ship it.

I'm not convinced we don't need some kind of general purpose lit solution that solves this, but that's a bigger task than I'm willing to take a stab at currently!

aganea accepted this revision.Feb 10 2021, 8:29 AM

LGTM.

For the record this fixes the issue below on Windows:

******************** TEST 'debuginfo-tests :: dexter/feature_tests/commands/penalty/unreachable.cpp' FAILED ********************
Script:
--
: 'RUN: at line 8';   not C:/Program Files/Python39/python.exe F:/aganea/llvm-project/debuginfo-tests\dexter\dexter.py test --fail-lt 1.0 -w --builder clang-cl_vs2015 --debugger dbgeng --cflags "/Zi /Od" --ldflags "/Zi" -- F:\aganea\llvm-project\debuginfo-tests\dexter\feature_tests\commands\penalty\unreachable.cpp | f:\aganea\llvm-project\buildtest\bin\filecheck.exe F:\aganea\llvm-project\debuginfo-tests\dexter\feature_tests\commands\penalty\unreachable.cpp
--
Exit Code: 2

Command Output (stdout):
--
$ ":" "RUN: at line 8"
$ "not" "C:/Program" "Files/Python39/python.exe" "F:/aganea/llvm-project/debuginfo-tests\dexter\dexter.py" "test" "--fail-lt" "1.0" "-w" "--builder" "clang-cl_vs2015" "--debugger" "dbgeng" "--cflags" "/Zi /Od" "--ldflags" "/Zi" "--" "F:\aganea\llvm-project\debuginfo-tests\dexter\feature_tests\commands\penalty\unreachable.cpp"
# command stderr:
error: program not executable

Python happens to be installed as "available to all users" on this machine, so it was installed on "C:\Program Files" (which before was missing quotes at the right place).