Add NoSideEffect trait to shape.split_at and shape.concat

[jpienaar]

Thanks!

[Jing]

Thanks for the review! Could you help commit it? I don't have the access.

[jpienaar]

Will do

mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td

let description = [{
 
     Note: This is intended for testing and debugging only.
   }];
 
   let arguments = (ins Shape_ShapeOrSizeType:$input);
   let results =  (outs Shape_ShapeOrSizeType:$output);
 }
 
-def Shape_SplitAtOp : Shape_Op<"split_at", []> {
+def Shape_SplitAtOp : Shape_Op<"split_at", [NoSideEffect]> {
   let summary = "Splits a shape at a given index";
   let description = [{
     Splits a shape at a given dimension `index`, returning two shapes.
     If `index` is negative, it is treated as indexing from the back of the
     shape. This negative-handling behavior is important when handling unranked
     shapes, where the positive index is not necessarily knowable due to a
     dynamic number of leading dimensions.
 
let description = [{
     - `index` is in the range [-rank(operand),rank(operand)]
   }];
 
   let arguments = (ins Shape_ShapeOrExtentTensorType:$operand, I32:$index);
   let results = (outs Shape_ShapeType:$head, Shape_ShapeType:$tail);
   let hasFolder = 1;
 }
 
-def Shape_ConcatOp : Shape_Op<"concat", []> {
+def Shape_ConcatOp : Shape_Op<"concat", [NoSideEffect]> {
   let summary = "Concatenates two shapes";
   let description = [{
     Creates a shape whose dimensions consist of first the dimensions from `lhs`
     followed by the dimensions of `rhs`.
 
     Example:
     concat([2,3], [4,5]) -> [2,3,4,5]
     concat([], []) -> []