Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Jing (Jing Pu)
User

Projects

User does not belong to any projects.

User Details

User Since
May 19 2020, 4:39 PM (185 w, 5 d)

Recent Activity

Nov 10 2021

Jing added a comment to D113619: Add an overloaded "removeResultAttr" method that takes StringRef..

What is the motivation here? Just convenience at call site?

Nov 10 2021, 5:42 PM · Restricted Project
Jing requested review of D113619: Add an overloaded "removeResultAttr" method that takes StringRef..
Nov 10 2021, 2:43 PM · Restricted Project

Sep 24 2021

Jing accepted D110457: [mlir:ElementsAttr] Avoid crash on empty contiguous ranges.
Sep 24 2021, 4:48 PM · Restricted Project

May 5 2021

Jing accepted D101969: [mlir] Store the flag for dynamic operand storage in the low bits.
May 5 2021, 7:58 PM · Restricted Project

Mar 17 2021

Jing accepted D98808: [mlir][IR] Support parsing hex float values in the DialectSymbolParser.

Thanks for fixing this!

Mar 17 2021, 12:55 PM · Restricted Project

Feb 24 2021

Jing added a comment to D97261: Allow !shape.size type operands in "shape.from_extents" op..

Thanks! Could you help submit the patch?

Feb 24 2021, 12:10 PM · Restricted Project
Jing updated the diff for D97261: Allow !shape.size type operands in "shape.from_extents" op..

Add a test that uses !shape.size type

Feb 24 2021, 12:09 PM · Restricted Project
Jing added a comment to D97261: Allow !shape.size type operands in "shape.from_extents" op..

Ping?

Feb 24 2021, 10:01 AM · Restricted Project

Feb 23 2021

Jing accepted D96086: [mlir][Inliner] Use llvm::parallelForEach instead of llvm::parallelTransformReduce.

Nice improvement!

Feb 23 2021, 10:47 AM · Restricted Project
Jing requested review of D97261: Allow !shape.size type operands in "shape.from_extents" op..
Feb 23 2021, 12:11 AM · Restricted Project

Feb 18 2021

Jing added a comment to D96907: Add DivOp to the Shape dialect.

Could you help me land the path?

Feb 18 2021, 2:02 PM · Restricted Project
Jing updated the diff for D96907: Add DivOp to the Shape dialect.

Resolved review comments.

Feb 18 2021, 2:01 PM · Restricted Project

Feb 17 2021

Jing requested review of D96907: Add DivOp to the Shape dialect.
Feb 17 2021, 3:00 PM · Restricted Project

Feb 9 2021

Jing requested review of D96377: Change type constraint of the "index" in "shape.split_at" to Shape_SizeOrIndexType.
Feb 9 2021, 3:17 PM · Restricted Project
Jing added a comment to D96358: Add NoSideEffect trait to shape.split_at and shape.concat.

Thanks for the review! Could you help commit it? I don't have the access.

Feb 9 2021, 3:04 PM · Restricted Project
Jing requested review of D96358: Add NoSideEffect trait to shape.split_at and shape.concat.
Feb 9 2021, 10:46 AM · Restricted Project

Nov 12 2020

Jing accepted D91402: [mlir][DenseElementsAttr] Allow for custom floating point types in `getValues`.
Nov 12 2020, 10:40 PM · Restricted Project

Aug 22 2020

Jing accepted D86409: Add an optional dialect_registration callback for "translations" registered with mlir-translate.
Aug 22 2020, 5:12 PM · Restricted Project

Aug 11 2020

Jing accepted D85748: [mlir] Expose printing functions in C API.
Aug 11 2020, 2:55 PM · Restricted Project

Aug 10 2020

Jing added a comment to D85629: Free the memory allocated by mlirOperationStateAddXXX methods in mlirOperationCreate..

Thanks! I don't have commit access. Can someone help me land it?

Aug 10 2020, 1:03 AM · Restricted Project
Jing added a reviewer for D85629: Free the memory allocated by mlirOperationStateAddXXX methods in mlirOperationCreate.: ftynse.
Aug 10 2020, 12:27 AM · Restricted Project
Jing updated the summary of D85629: Free the memory allocated by mlirOperationStateAddXXX methods in mlirOperationCreate..
Aug 10 2020, 12:27 AM · Restricted Project
Jing requested review of D85629: Free the memory allocated by mlirOperationStateAddXXX methods in mlirOperationCreate..
Aug 10 2020, 12:24 AM · Restricted Project

Jul 29 2020

Jing added a comment to D83310: [mlir] Initial version of C APIs.

This is looking good! Thanks for the work!

Jul 29 2020, 11:16 PM · Restricted Project

May 25 2020

Jing added a comment to D80258: Fix SourceMgrDiagnosticHandler::convertLocToSMLoc for unknown line/column scenerio..

I found there are some internal tests (on diagnostics) that rely on column zero being the first column.
I am not so sure whether we should adopt that behavior and change API (i.e. treating only row zero being an unknown location) or fix the tests.

May 25 2020, 10:28 PM · Restricted Project, Restricted Project

May 19 2020

Jing added inline comments to D80258: Fix SourceMgrDiagnosticHandler::convertLocToSMLoc for unknown line/column scenerio..
May 19 2020, 7:49 PM · Restricted Project, Restricted Project
Jing updated the summary of D80258: Fix SourceMgrDiagnosticHandler::convertLocToSMLoc for unknown line/column scenerio..
May 19 2020, 5:09 PM · Restricted Project, Restricted Project
Jing created D80258: Fix SourceMgrDiagnosticHandler::convertLocToSMLoc for unknown line/column scenerio..
May 19 2020, 5:06 PM · Restricted Project, Restricted Project