Page MenuHomePhabricator

[NewPM][HelloWorld] Move HelloWorld to Utils
ClosedPublic

Authored by aeubanks on Feb 2 2021, 4:46 PM.

Details

Summary

To prevent creating a new component, which creates a new library.

Diff Detail

Event Timeline

aeubanks created this revision.Feb 2 2021, 4:46 PM
aeubanks requested review of this revision.Feb 2 2021, 4:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2021, 4:46 PM
aeubanks updated this revision to Diff 320951.Feb 2 2021, 4:49 PM

fix quoting

ychen accepted this revision.Feb 3 2021, 12:22 PM

LGTM

This revision is now accepted and ready to land.Feb 3 2021, 12:22 PM
ychen added inline comments.Feb 3 2021, 12:23 PM
llvm/docs/WritingAnLLVMNewPMPass.rst
51–55

creating a new directory involves messing around with more CMake files than we want

aeubanks updated this revision to Diff 321200.Feb 3 2021, 12:59 PM

switch words around

This revision was landed with ongoing or failed builds.Feb 3 2021, 1:00 PM
This revision was automatically updated to reflect the committed changes.