This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] Updated comments to reflect D85817
ClosedPublic

Authored by RedDocMD on Feb 1 2021, 8:04 PM.

Details

Summary

Changed DeclaratorDecl in comment to NamedDecl

Diff Detail

Event Timeline

RedDocMD created this revision.Feb 1 2021, 8:04 PM
RedDocMD requested review of this revision.Feb 1 2021, 8:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2021, 8:04 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
vsavchenko accepted this revision.Feb 2 2021, 5:46 AM

Thanks for doing that!
I have a minor nit-picking comment, it is preferable to use present-tense imperative-style commit messages, i.e. "Update comment...".

This revision is now accepted and ready to land.Feb 2 2021, 5:46 AM

Thanks for doing that!
I have a minor nit-picking comment, it is preferable to use present-tense imperative-style commit messages, i.e. "Update comment...".

Noted. I will do that in future.

This revision was landed with ongoing or failed builds.Feb 15 2021, 12:48 AM
This revision was automatically updated to reflect the committed changes.