clang-extra: fix incorrect use of std::lock_guard by adding variable name (identified by MSVC [[nodiscard]] error)

[poelmanc]

Summary

std::lock_guard is an RAII class that needs a variable name whose scope determines the guard's lifetime. This particular usage lacked a variable name, meaning the guard could be destroyed before the line that it was indented to protect.

This line was identified by building clang with the latest MSVC preview release, which declares the std::lock_guard constructor to be [[nodiscard]] to draw attention to such issues.

[kadircet]

thanks, lgtm!

clang-tools-extra/clangd/support/Function.h

54

nit: we prefer Lock rather than Guard in other places. so s/Guard/Lock/

[poelmanc]

Change Guard to Lock.

[poelmanc]

s/Guard/Lock/! I don't have commit access so appreciate a push.

clang-tools-extra/clangd/support/Function.h

public:
   public:
     Subscription() : Parent(nullptr) {}
     Subscription(Subscription &&Other) : Parent(nullptr) {
       *this = std::move(Other);
     }
     Subscription &operator=(Subscription &&Other) {
       // If *this is active, unsubscribe.
       if (Parent) {
-        std::lock_guard<std::recursive_mutex>(Parent->ListenersMu);
+        std::lock_guard<std::recursive_mutex> Lock(Parent->ListenersMu);
         llvm::erase_if(Parent->Listeners,
                        [&](const std::pair<Listener, unsigned> &P) {
                          return P.second == ListenerID;
                        });
       }
       // Take over the other subscription, and mark it inactive.
       std::tie(Parent, ListenerID) = std::tie(Other.Parent, Other.ListenerID);
       Other.Parent = nullptr;