Page MenuHomePhabricator

Use type alias for large tuples
ClosedPublic

Authored by jpienaar on Jan 29 2021, 4:52 PM.

Details

Summary

Tuples types can occupy quite a lot of space, instead of printing out tuple
type everywhere, just use the type alias if larger (arbitrarily chose a bound
for now).

Diff Detail

Event Timeline

jpienaar created this revision.Jan 29 2021, 4:52 PM
jpienaar requested review of this revision.Jan 29 2021, 4:52 PM
jpienaar updated this revision to Diff 320251.Jan 29 2021, 5:36 PM

Fix style

LGTM, though we could even drop it lower than 16 IMO.

rriddle accepted this revision.Jan 29 2021, 5:37 PM
This revision is now accepted and ready to land.Jan 29 2021, 5:37 PM
This revision was landed with ongoing or failed builds.Jan 29 2021, 5:42 PM
This revision was automatically updated to reflect the committed changes.

Can you add a test for this please?

Can you add a test for this please?

Yes, will do. I'll have it just verify this happens but not at a specific size (e.g., create tuple with 40 elements) as the exact number may change. I'll submit one later today