Some cases may be transformed into 32 bit splats before hitting the boolean statement, which may cause incorrect behaviour and provide XXSPLTI32DX with the incorrect values of splat. The condition was reversed so that the shortcut prevents this problem.
nemanjai saghir lei
- Group Reviewers
- rG2e470e03b49f: [PowerPC][Power10] Fix XXSPLI32DX not correctly exploiting specific cases
LGTM as long as the nits are addressed on the commit.
// Check the type first to short-circuit so we don't modify APSplatBits if // this block isn't executed.
We can get rid of this now that the problem is fixed (i.e. this can go back to just being an else).
Get rid of this test case now. It is redundant.
Get rid of this comment now, the FIXME has been addressed.