This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] use typenames for opaque pointers
ClosedPublic

Authored by aartbik on Jan 27 2021, 11:09 PM.

Details

Diff Detail

Event Timeline

aartbik created this revision.Jan 27 2021, 11:09 PM
aartbik requested review of this revision.Jan 27 2021, 11:09 PM
bixia added inline comments.Jan 28 2021, 9:10 AM
mlir/integration_test/Sparse/CPU/frostt-example.mlir
21–24

I can tell that the new order of these declarations is the same as the order the routines are used. Is this a guideline for ordering declarations?
How about Alphabetical order?

ftynse accepted this revision.Jan 28 2021, 9:16 AM
This revision is now accepted and ready to land.Jan 28 2021, 9:16 AM
aartbik marked an inline comment as done.Jan 28 2021, 9:21 AM
aartbik added inline comments.
mlir/integration_test/Sparse/CPU/frostt-example.mlir
21–24

I don't think we have a fixed order (although usually alphabetical works).
Here I indeed thought it was a good idea to order this in the order used.

This revision was landed with ongoing or failed builds.Jan 28 2021, 9:23 AM
This revision was automatically updated to reflect the committed changes.
aartbik marked an inline comment as done.