This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Mark V_SET_INACTIVE as defining SCC
ClosedPublic

Authored by critson on Jan 26 2021, 11:51 PM.

Details

Summary

V_SET_INACTIVE is implemented with S_NOT which clobbers SCC.
Mark sure it is marked appropriately.

Diff Detail

Event Timeline

critson created this revision.Jan 26 2021, 11:51 PM
critson requested review of this revision.Jan 26 2021, 11:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 26 2021, 11:51 PM
foad added a comment.Jan 27 2021, 2:53 AM

Looks fine modulo the inline comment.

llvm/test/CodeGen/AMDGPU/llvm.amdgcn.set.inactive.ll
47

It's not clear to me what the generated code here looks like, such that it passes these checks. The code generated by globalisel would fail these checks I think.

Maybe autogenerate the checks for this whole file?

critson added inline comments.Jan 27 2021, 3:04 AM
llvm/test/CodeGen/AMDGPU/llvm.amdgcn.set.inactive.ll
47

I had to change the GlobalISel to a generate file exactly because the output is different.
I can switch this to be generated, which case I'll do it as a pre-commit.

foad added inline comments.Jan 27 2021, 3:32 AM
llvm/test/CodeGen/AMDGPU/llvm.amdgcn.set.inactive.ll
47

Yes please, I think generated checks would be better.

critson marked 2 inline comments as done.Jan 27 2021, 7:42 PM
critson updated this revision to Diff 319742.Jan 27 2021, 7:43 PM
  • Rebase onto pre-committed tests.
piotr accepted this revision.Jan 27 2021, 11:27 PM
This revision is now accepted and ready to land.Jan 27 2021, 11:27 PM
This revision was landed with ongoing or failed builds.Jan 28 2021, 4:47 PM
This revision was automatically updated to reflect the committed changes.