This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP][deviceRTLs] Remove omp_is_initial_device
ClosedPublic

Authored by tianshilei1992 on Jan 25 2021, 2:52 PM.

Details

Summary

omp_is_initial_device in device code was implemented as a builtin
function in D38968 for a better performance. Therefore there is no chance that
this function will be called to deviceRTLs. As we're moving to build deviceRTLs
with OpenMP compiler, this function can lead to a compilation error. This patch
just simply removes it.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Jan 25 2021, 2:52 PM
tianshilei1992 requested review of this revision.Jan 25 2021, 2:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2021, 2:52 PM
JonChesterfield accepted this revision.Jan 25 2021, 3:31 PM

Yep, thanks. When we replace the builtin with something using variant, we can reinstate this. Until then, & doesn't work anyway.

This revision is now accepted and ready to land.Jan 25 2021, 3:31 PM
This revision was automatically updated to reflect the committed changes.