This is an archive of the discontinued LLVM Phabricator instance.

Differential D95324

[Test][AArch64] Add s32 legalizer test for UADDE/USUBE
ClosedPublic

Authored by porglezomp on Jan 24 2021, 5:54 PM.

Details

Reviewers
paquette
aemerson
Commits
rGfdbfda2178a7: [Test][AArch64] Add s32 legalizer test for UADDE/USUBE

Diff Detail

Event Timeline

porglezomp created this revision.Jan 24 2021, 5:54 PM
Herald added subscribers: danielkiss, kristof.beyls. · View Herald TranscriptJan 24 2021, 5:54 PM
porglezomp requested review of this revision.Jan 24 2021, 5:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2021, 5:54 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
porglezomp added a parent revision: D95323: [Test][AArch64] Move overflow add/sub tests to their own file. NFC.Jan 24 2021, 5:55 PM
porglezomp added a child revision: D95325: [AArch64][GlobalISel] Make G_SADDE and G_SSUBE legal.Jan 24 2021, 5:59 PM
Harbormaster completed remote builds in B86490: Diff 318883.Jan 24 2021, 6:32 PM
paquette accepted this revision.Jan 25 2021, 10:53 AM

LGTM aside from nit

llvm/test/CodeGen/AArch64/GlobalISel/legalize-uadde.mir
2

Nit: The more recent test runlines tend to look like this.

This revision is now accepted and ready to land.Jan 25 2021, 10:53 AM
porglezomp updated this revision to Diff 319061.Jan 25 2021, 10:53 AM

Update test run line to match suggestions on D95323

Harbormaster completed remote builds in B86600: Diff 319061.Jan 25 2021, 10:54 AM
This revision was landed with ongoing or failed builds.Jan 25 2021, 7:05 PM
Closed by commit rGfdbfda2178a7: [Test][AArch64] Add s32 legalizer test for UADDE/USUBE (authored by porglezomp). · Explain Why
This revision was automatically updated to reflect the committed changes.
porglezomp added a commit: rGfdbfda2178a7: [Test][AArch64] Add s32 legalizer test for UADDE/USUBE.

Revision Contents

PathSize
llvm/
test/
CodeGen/
AArch64/
GlobalISel/
26 lines
26 lines

Diff 318883

llvm/test/CodeGen/AArch64/GlobalISel/legalize-uadde.mir

  • This file was added.
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
# RUN: llc -march=aarch64 -run-pass=legalizer %s -o - | FileCheck %s
paquetteUnsubmitted
Not Done
ReplyInline Actions
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
- # RUN: llc -march=aarch64 -run-pass=legalizer %s -o - | FileCheck %s
+ # RUN: llc -mtriple aarch64 -verify-machineinstrs -debugify-and-strip-all-safe --run-pass=legalizer %s -o - | FileCheck %s
---
name: test_scalar_uadde_32

Nit: The more recent test runlines tend to look like this.

paquette: Nit: The more recent test runlines tend to look like this.
---
name: test_scalar_uadde_32
body: |
bb.0.entry:
; CHECK-LABEL: name: test_scalar_uadde_32
; CHECK: [[COPY:%[0-9]+]]:_(s32) = COPY $w0
; CHECK: [[COPY1:%[0-9]+]]:_(s32) = COPY $w1
; CHECK: [[COPY2:%[0-9]+]]:_(s32) = COPY $w2
; CHECK: [[TRUNC:%[0-9]+]]:_(s1) = G_TRUNC [[COPY2]](s32)
; CHECK: [[UADDE:%[0-9]+]]:_(s32), [[UADDE1:%[0-9]+]]:_(s1) = G_UADDE [[COPY]], [[COPY1]], [[TRUNC]]
; CHECK: [[COPY3:%[0-9]+]]:_(s32) = COPY [[COPY2]](s32)
; CHECK: $w0 = COPY [[UADDE]](s32)
; CHECK: $w1 = COPY [[COPY3]](s32)
%0:_(s32) = COPY $w0
%1:_(s32) = COPY $w1
%2:_(s32) = COPY $w2
%3:_(s1) = G_TRUNC %2
%4:_(s32), %5:_(s1) = G_UADDE %0, %1, %3
%6:_(s32) = G_ANYEXT %3
$w0 = COPY %4(s32)
$w1 = COPY %6(s32)
...

llvm/test/CodeGen/AArch64/GlobalISel/legalize-usube.mir

  • This file was added.
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
# RUN: llc -march=aarch64 -run-pass=legalizer %s -o - | FileCheck %s
---
name: test_scalar_usube_32
body: |
bb.0.entry:
; CHECK-LABEL: name: test_scalar_usube_32
; CHECK: [[COPY:%[0-9]+]]:_(s32) = COPY $w0
; CHECK: [[COPY1:%[0-9]+]]:_(s32) = COPY $w1
; CHECK: [[COPY2:%[0-9]+]]:_(s32) = COPY $w2
; CHECK: [[TRUNC:%[0-9]+]]:_(s1) = G_TRUNC [[COPY2]](s32)
; CHECK: [[USUBE:%[0-9]+]]:_(s32), [[USUBE1:%[0-9]+]]:_(s1) = G_USUBE [[COPY]], [[COPY1]], [[TRUNC]]
; CHECK: [[COPY3:%[0-9]+]]:_(s32) = COPY [[COPY2]](s32)
; CHECK: $w0 = COPY [[USUBE]](s32)
; CHECK: $w1 = COPY [[COPY3]](s32)
%0:_(s32) = COPY $w0
%1:_(s32) = COPY $w1
%2:_(s32) = COPY $w2
%3:_(s1) = G_TRUNC %2
%4:_(s32), %5:_(s1) = G_USUBE %0, %1, %3
%6:_(s32) = G_ANYEXT %3
$w0 = COPY %4(s32)
$w1 = COPY %6(s32)
...