This is an archive of the discontinued LLVM Phabricator instance.

Differential D94971

[AArch64] Add missing "flagm" feature to the .arch_extension directive. Depends on D94970
ClosedPublic

Authored by MarkMurrayARM on Jan 19 2021, 6:54 AM.

Details

Reviewers
john.brawn
Commits
rGcab20f610577: [AArch64] Add missing "flagm" feature to the .arch_extension directive.

Diff Detail

Revision Contents

PathSize
llvm/
lib/
Target/
AArch64/
AsmParser/
1 line
test/
MC/
AArch64/
6 lines
9 lines
4 lines

Diff 317829

llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp

Show First 20 Lines • Show All 2,910 Lines • ▼ Show 20 Lines const FeatureBitset Features;
{"sve2", {AArch64::FeatureSVE2}}, {"sve2", {AArch64::FeatureSVE2}},
{"sve2-aes", {AArch64::FeatureSVE2AES}}, {"sve2-aes", {AArch64::FeatureSVE2AES}},
{"sve2-sm4", {AArch64::FeatureSVE2SM4}}, {"sve2-sm4", {AArch64::FeatureSVE2SM4}},
{"sve2-sha3", {AArch64::FeatureSVE2SHA3}}, {"sve2-sha3", {AArch64::FeatureSVE2SHA3}},
{"sve2-bitperm", {AArch64::FeatureSVE2BitPerm}}, {"sve2-bitperm", {AArch64::FeatureSVE2BitPerm}},
{"ls64", {AArch64::FeatureLS64}}, {"ls64", {AArch64::FeatureLS64}},
{"xs", {AArch64::FeatureXS}}, {"xs", {AArch64::FeatureXS}},
{"pauth", {AArch64::FeaturePAuth}}, {"pauth", {AArch64::FeaturePAuth}},
{"flagm", {AArch64::FeatureFlagM}},
// FIXME: Unsupported extensions // FIXME: Unsupported extensions
{"pan", {}}, {"pan", {}},
{"lor", {}}, {"lor", {}},
{"rdma", {}}, {"rdma", {}},
{"profile", {}}, {"profile", {}},
}; };
static void setRequiredFeatureString(FeatureBitset FBS, std::string &Str) { static void setRequiredFeatureString(FeatureBitset FBS, std::string &Str) {
▲ Show 20 Lines • Show All 3,418 Lines • Show Last 20 Lines

llvm/test/MC/AArch64/armv8.4a-flagm.s

  • This file was added.
// RUN: llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=+flagm < %s | FileCheck %s
cfinv
// CHECK: .text
cfinv // encoding: [0x1f,0x40,0x00,0xd5]

llvm/test/MC/AArch64/directive-arch_extension-negative.s

// RUN: not llvm-mc -triple aarch64 \ // RUN: not llvm-mc -triple aarch64 \
// RUN: -mattr=+crc,+sm4,+sha3,+sha2,+aes,+fp,+neon,+ras,+lse,+predres,+ccdp,+mte,+tlb-rmi,+pan-rwv,+ccpp,+rcpc,+ls64 \ // RUN: -mattr=+crc,+sm4,+sha3,+sha2,+aes,+fp,+neon,+ras,+lse,+predres,+ccdp,+mte,+tlb-rmi,+pan-rwv,+ccpp,+rcpc,+ls64,+flagm \
// RUN: -filetype asm -o - %s 2>&1 | FileCheck %s // RUN: -filetype asm -o - %s 2>&1 | FileCheck %s
.arch_extension axp64 .arch_extension axp64
// CHECK: error: unknown architectural extension: axp64 // CHECK: error: unknown architectural extension: axp64
// CHECK-NEXT: .arch_extension axp64 // CHECK-NEXT: .arch_extension axp64
crc32cx w0, w1, x3 crc32cx w0, w1, x3
// CHECK-NOT: [[@LINE-1]]:1: error: instruction requires: crc // CHECK-NOT: [[@LINE-1]]:1: error: instruction requires: crc
▲ Show 20 Lines • Show All 108 Lines • ▼ Show 20 Lines
// CHECK-NEXT: ldapr x0, [x1] // CHECK-NEXT: ldapr x0, [x1]
ld64b x0, [x13] ld64b x0, [x13]
// CHECK-NOT: [[@LINE-1]]:1: error: instruction requires: ls64 // CHECK-NOT: [[@LINE-1]]:1: error: instruction requires: ls64
.arch_extension nols64 .arch_extension nols64
ld64b x0, [x13] ld64b x0, [x13]
// CHECK: [[@LINE-1]]:1: error: instruction requires: ls64 // CHECK: [[@LINE-1]]:1: error: instruction requires: ls64
// CHECK-NEXT: ld64b x0, [x13] // CHECK-NEXT: ld64b x0, [x13]
cfinv
// CHECK-NOT: [[@LINE-1]]:1: error: instruction requires: flagm
.arch_extension noflagm
cfinv
// CHECK: [[@LINE-1]]:1: error: instruction requires: flagm
// CHECK-NEXT: cfinv

llvm/test/MC/AArch64/directive-arch_extension.s

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lines
.arch_extension ls64 .arch_extension ls64
ld64b x0, [x13] ld64b x0, [x13]
// CHECK: ld64b x0, [x13] // CHECK: ld64b x0, [x13]
.arch_extension pauth .arch_extension pauth
paciasp paciasp
// CHECK: paciasp // CHECK: paciasp
.arch_extension flagm
cfinv
// CHECK: cfinv